Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1089

Remove uses of FileContext#isFile, isDirectory and exists

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Here's an HDFS jira for the second part of HADOOP-6678: removing uses of FileContext#isFile, isDirectory and exists.

      1. hdfs-1089-1.patch
        2 kB
        Eli Collins
      2. hdfs-1089-2.patch
        4 kB
        Eli Collins

        Issue Links

          Activity

          Hide
          Hairong Kuang added a comment -

          I committed the second patch. Thanks again, Eli!

          Show
          Hairong Kuang added a comment - I committed the second patch. Thanks again, Eli!
          Hide
          Hairong Kuang added a comment -

          +1. I ran both ant run-test-hdfs-fault-injection and ant run-commit-test. Both were passed.

          Show
          Hairong Kuang added a comment - +1. I ran both ant run-test-hdfs-fault-injection and ant run-commit-test. Both were passed.
          Hide
          Eli Collins added a comment -

          Patch attached. ant run-test-hdfs-fault-inject compiles and is running now.

          Show
          Eli Collins added a comment - Patch attached. ant run-test-hdfs-fault-inject compiles and is running now.
          Hide
          Hairong Kuang added a comment -

          Sorry that I missed the fault injection tests. I reverted the patch.

          Show
          Hairong Kuang added a comment - Sorry that I missed the fault injection tests. I reverted the patch.
          Hide
          Konstantin Shvachko added a comment -

          Looks like there is more use cases in FI that need to be fixed.
          ant target compile-fault-injection fails with java errors.
          I am reopening this.

          Show
          Konstantin Shvachko added a comment - Looks like there is more use cases in FI that need to be fixed. ant target compile-fault-injection fails with java errors. I am reopening this.
          Hide
          Hairong Kuang added a comment -

          I've just committed this. Thanks Eli!

          Show
          Hairong Kuang added a comment - I've just committed this. Thanks Eli!
          Hide
          Hairong Kuang added a comment -

          +1 Now that HADOOP-6678 made it to HDFS, let me commit this patch.

          Show
          Hairong Kuang added a comment - +1 Now that HADOOP-6678 made it to HDFS, let me commit this patch.
          Hide
          Eli Collins added a comment -

          Kick hudson. HADOOP-6678 should have made it into the common jar by now.

          Show
          Eli Collins added a comment - Kick hudson. HADOOP-6678 should have made it into the common jar by now.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch
          against trunk revision 939091.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch against trunk revision 939091. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Submitting to hudson now that HADOOP-6678 is in.

          Show
          Eli Collins added a comment - Submitting to hudson now that HADOOP-6678 is in.
          Hide
          Eli Collins added a comment -

          Agreed, this jira, HADOOP-6678, HADOOP-6692, and HADOOP-6678 (and it's associated hdfs and mr jiras) since they remove methods from the FileContext API. Hoping these all get reviewed and checked in before Tom pulls trunk into the branch.

          Show
          Eli Collins added a comment - Agreed, this jira, HADOOP-6678 , HADOOP-6692 , and HADOOP-6678 (and it's associated hdfs and mr jiras) since they remove methods from the FileContext API. Hoping these all get reviewed and checked in before Tom pulls trunk into the branch.
          Hide
          dhruba borthakur added a comment -

          we should probably try to fix this before the new 0.21 release?

          Show
          dhruba borthakur added a comment - we should probably try to fix this before the new 0.21 release?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch
          against trunk revision 931675.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch against trunk revision 931675. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Trivial patch, depends on the new exists method in FileContextTestHelper.

          Show
          Eli Collins added a comment - Trivial patch, depends on the new exists method in FileContextTestHelper.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development