Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1089

Remove uses of FileContext#isFile, isDirectory and exists

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Here's an HDFS jira for the second part of HADOOP-6678: removing uses of FileContext#isFile, isDirectory and exists.

      1. hdfs-1089-1.patch
        2 kB
        Eli Collins
      2. hdfs-1089-2.patch
        4 kB
        Eli Collins

        Issue Links

          Activity

          Eli Collins created issue -
          Eli Collins made changes -
          Field Original Value New Value
          Link This issue blocks HADOOP-6678 [ HADOOP-6678 ]
          Hide
          Eli Collins added a comment -

          Trivial patch, depends on the new exists method in FileContextTestHelper.

          Show
          Eli Collins added a comment - Trivial patch, depends on the new exists method in FileContextTestHelper.
          Eli Collins made changes -
          Attachment hdfs-1089-1.patch [ 12441110 ]
          Eli Collins made changes -
          Link This issue depends on HADOOP-6678 [ HADOOP-6678 ]
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch
          against trunk revision 931675.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch against trunk revision 931675. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/151/console This message is automatically generated.
          Hide
          dhruba borthakur added a comment -

          we should probably try to fix this before the new 0.21 release?

          Show
          dhruba borthakur added a comment - we should probably try to fix this before the new 0.21 release?
          dhruba borthakur made changes -
          Fix Version/s 0.21.0 [ 12314046 ]
          Hide
          Eli Collins added a comment -

          Agreed, this jira, HADOOP-6678, HADOOP-6692, and HADOOP-6678 (and it's associated hdfs and mr jiras) since they remove methods from the FileContext API. Hoping these all get reviewed and checked in before Tom pulls trunk into the branch.

          Show
          Eli Collins added a comment - Agreed, this jira, HADOOP-6678 , HADOOP-6692 , and HADOOP-6678 (and it's associated hdfs and mr jiras) since they remove methods from the FileContext API. Hoping these all get reviewed and checked in before Tom pulls trunk into the branch.
          Hide
          Eli Collins added a comment -

          Submitting to hudson now that HADOOP-6678 is in.

          Show
          Eli Collins added a comment - Submitting to hudson now that HADOOP-6678 is in.
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch
          against trunk revision 939091.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12441110/hdfs-1089-1.patch against trunk revision 939091. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/166/console This message is automatically generated.
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Eli Collins added a comment -

          Kick hudson. HADOOP-6678 should have made it into the common jar by now.

          Show
          Eli Collins added a comment - Kick hudson. HADOOP-6678 should have made it into the common jar by now.
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hairong Kuang added a comment -

          +1 Now that HADOOP-6678 made it to HDFS, let me commit this patch.

          Show
          Hairong Kuang added a comment - +1 Now that HADOOP-6678 made it to HDFS, let me commit this patch.
          Hide
          Hairong Kuang added a comment -

          I've just committed this. Thanks Eli!

          Show
          Hairong Kuang added a comment - I've just committed this. Thanks Eli!
          Hairong Kuang made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Konstantin Shvachko added a comment -

          Looks like there is more use cases in FI that need to be fixed.
          ant target compile-fault-injection fails with java errors.
          I am reopening this.

          Show
          Konstantin Shvachko added a comment - Looks like there is more use cases in FI that need to be fixed. ant target compile-fault-injection fails with java errors. I am reopening this.
          Konstantin Shvachko made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Hairong Kuang added a comment -

          Sorry that I missed the fault injection tests. I reverted the patch.

          Show
          Hairong Kuang added a comment - Sorry that I missed the fault injection tests. I reverted the patch.
          Hide
          Eli Collins added a comment -

          Patch attached. ant run-test-hdfs-fault-inject compiles and is running now.

          Show
          Eli Collins added a comment - Patch attached. ant run-test-hdfs-fault-inject compiles and is running now.
          Eli Collins made changes -
          Attachment hdfs-1089-2.patch [ 12443312 ]
          Eli Collins made changes -
          Status Reopened [ 4 ] Patch Available [ 10002 ]
          Hide
          Hairong Kuang added a comment -

          +1. I ran both ant run-test-hdfs-fault-injection and ant run-commit-test. Both were passed.

          Show
          Hairong Kuang added a comment - +1. I ran both ant run-test-hdfs-fault-injection and ant run-commit-test. Both were passed.
          Hide
          Hairong Kuang added a comment -

          I committed the second patch. Thanks again, Eli!

          Show
          Hairong Kuang added a comment - I committed the second patch. Thanks again, Eli!
          Hairong Kuang made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks HADOOP-6678 [ HADOOP-6678 ]
          Gavin made changes -
          Link This issue is depended upon by HADOOP-6678 [ HADOOP-6678 ]
          Gavin made changes -
          Link This issue depends on HADOOP-6678 [ HADOOP-6678 ]
          Gavin made changes -
          Link This issue depends upon HADOOP-6678 [ HADOOP-6678 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          19h 15m 2 Eli Collins 29/Apr/10 19:58
          Open Open Patch Available Patch Available
          20d 20h 48m 3 Eli Collins 29/Apr/10 20:00
          Resolved Resolved Reopened Reopened
          1h 10m 1 Konstantin Shvachko 30/Apr/10 18:36
          Reopened Reopened Patch Available Patch Available
          27m 24s 1 Eli Collins 30/Apr/10 19:04
          Patch Available Patch Available Resolved Resolved
          22h 53m 2 Hairong Kuang 30/Apr/10 20:32
          Resolved Resolved Closed Closed
          116d 20m 1 Tom White 24/Aug/10 20:52

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development