Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10870

Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.6.5
    • Component/s: documentation
    • Labels:
      None
    • Target Version/s:

      Description

      Wrong dfs.namenode.acls.enabled = true in HdfsPermissionsGuide.apt.vm. The default should be false as correctly stated in the description and in DFS_NAMENODE_ACLS_ENABLED_DEFAULT:

           * <<<dfs.namenode.acls.enabled = true>>>
      
             Set to true to enable support for HDFS ACLs (Access Control Lists).  By
             default, ACLs are disabled.  When ACLs are disabled, the NameNode rejects
             all attempts to set an ACL.
      
      DFSConfigKeys.java
        public static final String  DFS_NAMENODE_ACLS_ENABLED_KEY = "dfs.namenode.acls.enabled";
        public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
      

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Patch 001:

        • Change default from true to false for dfs.namenode.acls.enabled
        Show
        jzhuge John Zhuge added a comment - Patch 001: Change default from true to false for dfs.namenode.acls.enabled
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 24s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 8m 6s branch-2.6 passed
        +1 mvnsite 1m 6s branch-2.6 passed
        +1 mvnsite 1m 0s the patch passed
        -1 whitespace 0m 0s The patch has 1161 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 27s The patch 18 line(s) with tabs.
        -1 asflicense 0m 29s The patch generated 38 ASF License warnings.
        12m 4s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:44eef0e
        JIRA Issue HDFS-10870
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829230/HDFS-10870-branch-2.6.001.patch
        Optional Tests asflicense mvnsite
        uname Linux 21a1874fac54 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 7ee4982
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/whitespace-tabs.txt
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16793/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 8m 6s branch-2.6 passed +1 mvnsite 1m 6s branch-2.6 passed +1 mvnsite 1m 0s the patch passed -1 whitespace 0m 0s The patch has 1161 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 27s The patch 18 line(s) with tabs. -1 asflicense 0m 29s The patch generated 38 ASF License warnings. 12m 4s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Issue HDFS-10870 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829230/HDFS-10870-branch-2.6.001.patch Optional Tests asflicense mvnsite uname Linux 21a1874fac54 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 7ee4982 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/whitespace-tabs.txt asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16793/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        The whitespace and asflicense warnings are unrelated. Probably Yetus problem?

        Show
        jzhuge John Zhuge added a comment - The whitespace and asflicense warnings are unrelated. Probably Yetus problem?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 11m 26s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 7m 45s branch-2.6 passed
        +1 mvnsite 0m 58s branch-2.6 passed
        +1 mvnsite 0m 56s the patch passed
        -1 whitespace 0m 0s The patch has 1317 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 33s The patch 18 line(s) with tabs.
        -1 asflicense 0m 29s The patch generated 38 ASF License warnings.
        22m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:44eef0e
        JIRA Issue HDFS-10870
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829230/HDFS-10870-branch-2.6.001.patch
        Optional Tests asflicense mvnsite
        uname Linux 1fdfb472c5f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 7ee4982
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/whitespace-tabs.txt
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16794/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 7m 45s branch-2.6 passed +1 mvnsite 0m 58s branch-2.6 passed +1 mvnsite 0m 56s the patch passed -1 whitespace 0m 0s The patch has 1317 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 33s The patch 18 line(s) with tabs. -1 asflicense 0m 29s The patch generated 38 ASF License warnings. 22m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Issue HDFS-10870 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829230/HDFS-10870-branch-2.6.001.patch Optional Tests asflicense mvnsite uname Linux 1fdfb472c5f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 7ee4982 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/whitespace-tabs.txt asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16794/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        +1. LGTM.

        The warnings are not relevant.

        Show
        eddyxu Lei (Eddy) Xu added a comment - +1. LGTM. The warnings are not relevant.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Committed to branch-2.6 and branch-2.6.5. Thanks John Zhuge for the work.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Committed to branch-2.6 and branch-2.6.5. Thanks John Zhuge for the work.
        Hide
        raviprak Ravi Prakash added a comment -

        Sorry. Never mind. This is just a change in the doc. Thanks Eddy and John

        Show
        raviprak Ravi Prakash added a comment - Sorry. Never mind. This is just a change in the doc. Thanks Eddy and John
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Lei (Eddy) Xu for the review and commit!

        Thanks Ravi Prakash, this fix is to prevent users from wrongly expecting ACLs to be enabled.

        Show
        jzhuge John Zhuge added a comment - Thanks Lei (Eddy) Xu for the review and commit! Thanks Ravi Prakash , this fix is to prevent users from wrongly expecting ACLs to be enabled.

          People

          • Assignee:
            jzhuge John Zhuge
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development