Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10861

Refactor StripeReaders and use ECChunk version decode API

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Refactor StatefulStripeReader and PositionStripeReader, use ECChunk version decode API. After the refactor, it is approaching very near now to the ideal state desired by next step, employing ErasureCoder API instead of RawErasureCoder API.

      1. HDFS-10861-v1.patch
        20 kB
        SammiChen
      2. HDFS-10861-v2.patch
        20 kB
        SammiChen
      3. HDFS-10861-v3.patch
        61 kB
        SammiChen
      4. HDFS-10861-v4.patch
        73 kB
        SammiChen
      5. HDFS-10861-v5.patch
        74 kB
        SammiChen
      6. HDFS-10861-v6.patch
        74 kB
        SammiChen

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 25s trunk passed
          +1 compile 7m 41s trunk passed
          +1 checkstyle 1m 28s trunk passed
          +1 mvnsite 1m 35s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 0s trunk passed
          +1 javadoc 1m 9s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 7m 38s the patch passed
          +1 javac 7m 38s the patch passed
          -0 checkstyle 1m 29s root: The patch generated 5 new + 64 unchanged - 4 fixed = 69 total (was 68)
          +1 mvnsite 1m 34s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 17s the patch passed
          +1 javadoc 1m 8s the patch passed
          -1 unit 7m 46s hadoop-common in the patch failed.
          +1 unit 0m 59s hadoop-hdfs-client in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          50m 16s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10861
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828194/HDFS-10861-v1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9a834bd94ddb 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f0876b8
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16732/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16732/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16732/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16732/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 25s trunk passed +1 compile 7m 41s trunk passed +1 checkstyle 1m 28s trunk passed +1 mvnsite 1m 35s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 0s trunk passed +1 javadoc 1m 9s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 7m 38s the patch passed +1 javac 7m 38s the patch passed -0 checkstyle 1m 29s root: The patch generated 5 new + 64 unchanged - 4 fixed = 69 total (was 68) +1 mvnsite 1m 34s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 17s the patch passed +1 javadoc 1m 8s the patch passed -1 unit 7m 46s hadoop-common in the patch failed. +1 unit 0m 59s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 50m 16s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10861 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828194/HDFS-10861-v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9a834bd94ddb 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f0876b8 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16732/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16732/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16732/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16732/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Sammi SammiChen added a comment -

          Fixed 3 checkstyle issues. Other 2 checkstyle issues are not necessary.

          Show
          Sammi SammiChen added a comment - Fixed 3 checkstyle issues. Other 2 checkstyle issues are not necessary.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 3m 43s Maven dependency ordering for branch
          +1 mvninstall 7m 6s trunk passed
          +1 compile 7m 33s trunk passed
          +1 checkstyle 1m 26s trunk passed
          +1 mvnsite 2m 3s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 27s trunk passed
          +1 javadoc 1m 9s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 20s the patch passed
          +1 compile 9m 39s the patch passed
          +1 javac 9m 39s the patch passed
          -0 checkstyle 1m 30s root: The patch generated 2 new + 64 unchanged - 4 fixed = 66 total (was 68)
          +1 mvnsite 1m 31s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 11s the patch passed
          +1 javadoc 1m 16s the patch passed
          +1 unit 8m 22s hadoop-common in the patch passed.
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          57m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10861
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828409/HDFS-10861-v2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e94483e07cfb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ea0c2b8
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16738/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16738/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16738/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 3m 43s Maven dependency ordering for branch +1 mvninstall 7m 6s trunk passed +1 compile 7m 33s trunk passed +1 checkstyle 1m 26s trunk passed +1 mvnsite 2m 3s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 27s trunk passed +1 javadoc 1m 9s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 9m 39s the patch passed +1 javac 9m 39s the patch passed -0 checkstyle 1m 30s root: The patch generated 2 new + 64 unchanged - 4 fixed = 66 total (was 68) +1 mvnsite 1m 31s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 11s the patch passed +1 javadoc 1m 16s the patch passed +1 unit 8m 22s hadoop-common in the patch passed. +1 unit 1m 0s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 57m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10861 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828409/HDFS-10861-v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e94483e07cfb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea0c2b8 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16738/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16738/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16738/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Thanks SammiChen for working on this.

          Is it possible to extract these StripReaders and make them separate? In future we can evolve further to share the facilities in other places.

          Show
          drankye Kai Zheng added a comment - Thanks SammiChen for working on this. Is it possible to extract these StripReaders and make them separate? In future we can evolve further to share the facilities in other places.
          Hide
          Sammi SammiChen added a comment -

          extract StripeReader from DfsStripedInputStream class

          Show
          Sammi SammiChen added a comment - extract StripeReader from DfsStripedInputStream class
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 31s Maven dependency ordering for branch
          +1 mvninstall 6m 37s trunk passed
          +1 compile 6m 49s trunk passed
          +1 checkstyle 1m 28s trunk passed
          +1 mvnsite 1m 30s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 2m 39s trunk passed
          +1 javadoc 1m 4s trunk passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 8s the patch passed
          +1 compile 6m 46s the patch passed
          -1 javac 6m 46s root generated 1 new + 707 unchanged - 1 fixed = 708 total (was 708)
          -0 checkstyle 1m 27s root: The patch generated 14 new + 98 unchanged - 26 fixed = 112 total (was 124)
          +1 mvnsite 1m 26s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 58s the patch passed
          +1 javadoc 1m 4s the patch passed
          +1 unit 8m 8s hadoop-common in the patch passed.
          +1 unit 0m 57s hadoop-hdfs-client in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          48m 7s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10861
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829133/HDFS-10861-v3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux df47f7f8472f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3552c2b
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16787/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16787/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16787/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16787/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 6m 37s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 1m 28s trunk passed +1 mvnsite 1m 30s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 2m 39s trunk passed +1 javadoc 1m 4s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 6m 46s the patch passed -1 javac 6m 46s root generated 1 new + 707 unchanged - 1 fixed = 708 total (was 708) -0 checkstyle 1m 27s root: The patch generated 14 new + 98 unchanged - 26 fixed = 112 total (was 124) +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 58s the patch passed +1 javadoc 1m 4s the patch passed +1 unit 8m 8s hadoop-common in the patch passed. +1 unit 0m 57s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 48m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10861 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829133/HDFS-10861-v3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux df47f7f8472f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3552c2b Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HDFS-Build/16787/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16787/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16787/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16787/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Sammi SammiChen added a comment -

          After discussion with Kai, I re-factored the patch. Here is the difference,
          1. move StripeRange from DFSStripedInputStream to StripedBlockUtil .
          2. move BlockReaderInfo from DFSStripedInputStream to StripeReader
          3. move finalizeDecodeInputs, decodeAndFillBuffer, prepareErasedIndices from StripedBlockUtil to StripeReader

          Show
          Sammi SammiChen added a comment - After discussion with Kai, I re-factored the patch. Here is the difference, 1. move StripeRange from DFSStripedInputStream to StripedBlockUtil . 2. move BlockReaderInfo from DFSStripedInputStream to StripeReader 3. move finalizeDecodeInputs , decodeAndFillBuffer , prepareErasedIndices from StripedBlockUtil to StripeReader
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 40s Maven dependency ordering for branch
          +1 mvninstall 7m 0s trunk passed
          +1 compile 6m 54s trunk passed
          +1 checkstyle 1m 30s trunk passed
          +1 mvnsite 1m 34s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 2m 44s trunk passed
          +1 javadoc 1m 5s trunk passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 7s the patch passed
          +1 compile 6m 50s the patch passed
          -1 javac 6m 50s root generated 1 new + 707 unchanged - 1 fixed = 708 total (was 708)
          -0 checkstyle 1m 29s root: The patch generated 15 new + 73 unchanged - 52 fixed = 88 total (was 125)
          +1 mvnsite 1m 27s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 7s the patch passed
          +1 javadoc 1m 4s the patch passed
          +1 unit 7m 29s hadoop-common in the patch passed.
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          48m 28s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10861
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829154/HDFS-10861-v4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 315ffababf70 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3552c2b
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16790/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16790/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16790/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16790/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 7m 0s trunk passed +1 compile 6m 54s trunk passed +1 checkstyle 1m 30s trunk passed +1 mvnsite 1m 34s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 2m 44s trunk passed +1 javadoc 1m 5s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 7s the patch passed +1 compile 6m 50s the patch passed -1 javac 6m 50s root generated 1 new + 707 unchanged - 1 fixed = 708 total (was 708) -0 checkstyle 1m 29s root: The patch generated 15 new + 73 unchanged - 52 fixed = 88 total (was 125) +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 7s the patch passed +1 javadoc 1m 4s the patch passed +1 unit 7m 29s hadoop-common in the patch passed. +1 unit 0m 55s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 48m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10861 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829154/HDFS-10861-v4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 315ffababf70 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3552c2b Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HDFS-Build/16790/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16790/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16790/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16790/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Sammi SammiChen added a comment -

          Update the patch,
          1. fix 1 code style
          2. refine code, import protected inner class, avoid long class reference chain

          Show
          Sammi SammiChen added a comment - Update the patch, 1. fix 1 code style 2. refine code, import protected inner class, avoid long class reference chain
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 34s Maven dependency ordering for branch
          +1 mvninstall 7m 20s trunk passed
          +1 compile 8m 11s trunk passed
          +1 checkstyle 1m 35s trunk passed
          +1 mvnsite 2m 34s trunk passed
          +1 mvneclipse 0m 39s trunk passed
          +1 findbugs 5m 11s trunk passed
          +1 javadoc 2m 13s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 8s the patch passed
          +1 compile 7m 50s the patch passed
          -1 javac 7m 50s root generated 1 new + 708 unchanged - 1 fixed = 709 total (was 709)
          -0 checkstyle 1m 31s root: The patch generated 19 new + 87 unchanged - 52 fixed = 106 total (was 139)
          +1 mvnsite 2m 37s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 5m 36s the patch passed
          +1 javadoc 2m 13s the patch passed
          +1 unit 9m 6s hadoop-common in the patch passed.
          +1 unit 0m 59s hadoop-hdfs-client in the patch passed.
          -1 unit 58m 23s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          122m 26s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10861
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829166/HDFS-10861-v5.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 416e5b6a6284 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b8a30f2
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16791/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16791/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16791/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16791/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 34s Maven dependency ordering for branch +1 mvninstall 7m 20s trunk passed +1 compile 8m 11s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 2m 34s trunk passed +1 mvneclipse 0m 39s trunk passed +1 findbugs 5m 11s trunk passed +1 javadoc 2m 13s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 8s the patch passed +1 compile 7m 50s the patch passed -1 javac 7m 50s root generated 1 new + 708 unchanged - 1 fixed = 709 total (was 709) -0 checkstyle 1m 31s root: The patch generated 19 new + 87 unchanged - 52 fixed = 106 total (was 139) +1 mvnsite 2m 37s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 36s the patch passed +1 javadoc 2m 13s the patch passed +1 unit 9m 6s hadoop-common in the patch passed. +1 unit 0m 59s hadoop-hdfs-client in the patch passed. -1 unit 58m 23s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 122m 26s Reason Tests Failed junit tests hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestReadStripedFileWithMissingBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10861 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829166/HDFS-10861-v5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 416e5b6a6284 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b8a30f2 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HDFS-Build/16791/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16791/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16791/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16791/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16791/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Looks like the two failures are relevant.

          Show
          drankye Kai Zheng added a comment - Looks like the two failures are relevant.
          Hide
          drankye Kai Zheng added a comment -

          Note two links broken in StripedBlockUtil.

          Show
          drankye Kai Zheng added a comment - Note two links broken in StripedBlockUtil.
          Hide
          Sammi SammiChen added a comment -

          Fix 2 failed test cases

          Show
          Sammi SammiChen added a comment - Fix 2 failed test cases
          Hide
          Sammi SammiChen added a comment -

          The broken link in StripedBlockUtil is also fixed.

          Show
          Sammi SammiChen added a comment - The broken link in StripedBlockUtil is also fixed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 8m 52s trunk passed
          +1 compile 7m 42s trunk passed
          +1 checkstyle 1m 29s trunk passed
          +1 mvnsite 2m 23s trunk passed
          +1 mvneclipse 0m 38s trunk passed
          +1 findbugs 4m 25s trunk passed
          +1 javadoc 1m 59s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 2m 3s the patch passed
          +1 compile 8m 47s the patch passed
          -1 javac 8m 47s root generated 1 new + 707 unchanged - 1 fixed = 708 total (was 708)
          -0 checkstyle 1m 32s root: The patch generated 19 new + 87 unchanged - 52 fixed = 106 total (was 139)
          +1 mvnsite 2m 27s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 48s the patch passed
          +1 javadoc 2m 10s the patch passed
          -1 unit 8m 59s hadoop-common in the patch failed.
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed.
          -1 unit 60m 40s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          122m 38s



          Reason Tests
          Failed junit tests hadoop.ipc.TestIPC
            hadoop.ipc.TestRPC
            hadoop.hdfs.TestReadStripedFileWithDecoding
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10861
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829166/HDFS-10861-v5.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9a495465eefd 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e52d6e7
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16805/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16805/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 8m 52s trunk passed +1 compile 7m 42s trunk passed +1 checkstyle 1m 29s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 4m 25s trunk passed +1 javadoc 1m 59s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 2m 3s the patch passed +1 compile 8m 47s the patch passed -1 javac 8m 47s root generated 1 new + 707 unchanged - 1 fixed = 708 total (was 708) -0 checkstyle 1m 32s root: The patch generated 19 new + 87 unchanged - 52 fixed = 106 total (was 139) +1 mvnsite 2m 27s the patch passed +1 mvneclipse 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 48s the patch passed +1 javadoc 2m 10s the patch passed -1 unit 8m 59s hadoop-common in the patch failed. +1 unit 1m 0s hadoop-hdfs-client in the patch passed. -1 unit 60m 40s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 122m 38s Reason Tests Failed junit tests hadoop.ipc.TestIPC   hadoop.ipc.TestRPC   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestReadStripedFileWithMissingBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10861 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829166/HDFS-10861-v5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9a495465eefd 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e52d6e7 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16805/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16805/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16805/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Sammi SammiChen added a comment -

          Resubmit patch v6 to trigger Hadoop QA run the test against v6

          Show
          Sammi SammiChen added a comment - Resubmit patch v6 to trigger Hadoop QA run the test against v6
          Hide
          Sammi SammiChen added a comment -

          Hadoop QA run the test with the old v5 patch

          Show
          Sammi SammiChen added a comment - Hadoop QA run the test with the old v5 patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 24s Maven dependency ordering for branch
          +1 mvninstall 7m 14s trunk passed
          +1 compile 6m 57s trunk passed
          +1 checkstyle 1m 29s trunk passed
          +1 mvnsite 2m 23s trunk passed
          +1 mvneclipse 0m 38s trunk passed
          +1 findbugs 4m 27s trunk passed
          +1 javadoc 1m 59s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 53s the patch passed
          +1 compile 6m 50s the patch passed
          -1 javac 6m 50s root generated 1 new + 708 unchanged - 1 fixed = 709 total (was 709)
          -0 checkstyle 1m 27s root: The patch generated 18 new + 88 unchanged - 51 fixed = 106 total (was 139)
          +1 mvnsite 2m 20s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 58s the patch passed
          +1 javadoc 2m 7s the patch passed
          +1 unit 8m 50s hadoop-common in the patch passed.
          +1 unit 1m 4s hadoop-hdfs-client in the patch passed.
          +1 unit 64m 0s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          121m 31s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10861
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829332/HDFS-10861-v6.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6449481a0d82 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e52d6e7
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16806/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16806/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16806/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16806/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 7m 14s trunk passed +1 compile 6m 57s trunk passed +1 checkstyle 1m 29s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 4m 27s trunk passed +1 javadoc 1m 59s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 53s the patch passed +1 compile 6m 50s the patch passed -1 javac 6m 50s root generated 1 new + 708 unchanged - 1 fixed = 709 total (was 709) -0 checkstyle 1m 27s root: The patch generated 18 new + 88 unchanged - 51 fixed = 106 total (was 139) +1 mvnsite 2m 20s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 58s the patch passed +1 javadoc 2m 7s the patch passed +1 unit 8m 50s hadoop-common in the patch passed. +1 unit 1m 4s hadoop-hdfs-client in the patch passed. +1 unit 64m 0s hadoop-hdfs in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 121m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10861 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829332/HDFS-10861-v6.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6449481a0d82 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e52d6e7 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HDFS-Build/16806/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16806/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16806/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16806/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Thanks SammiChen for the update! The latest patch LGTM now. +1 and will commit it shortly.

          Show
          drankye Kai Zheng added a comment - Thanks SammiChen for the update! The latest patch LGTM now. +1 and will commit it shortly.
          Hide
          drankye Kai Zheng added a comment -

          Committed to trunk. Thanks SammiChen for the contribution!

          Show
          drankye Kai Zheng added a comment - Committed to trunk. Thanks SammiChen for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10465 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10465/)
          HDFS-10861. Refactor StripeReaders and use ECChunk version decode API. (kai.zheng: rev 734d54c1a8950446e68098f62d8964e02ecc2890)

          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestStripedBlockUtil.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/ElasticByteBufferPool.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ECChunk.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StatefulStripeReader.java
          • (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripeReader.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/CoderUtil.java
          • (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/PositionStripeReader.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedInputStream.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10465 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10465/ ) HDFS-10861 . Refactor StripeReaders and use ECChunk version decode API. (kai.zheng: rev 734d54c1a8950446e68098f62d8964e02ecc2890) (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestStripedBlockUtil.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/ElasticByteBufferPool.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ECChunk.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StatefulStripeReader.java (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripeReader.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/CoderUtil.java (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/PositionStripeReader.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedInputStream.java
          Hide
          Sammi SammiChen added a comment -

          Thanks Kai for take time review the patch and commit it!

          Show
          Sammi SammiChen added a comment - Thanks Kai for take time review the patch and commit it!

            People

            • Assignee:
              Sammi SammiChen
              Reporter:
              Sammi SammiChen
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development