Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: httpfs
    • Labels:
      None

      Description

      Typo in method hadoop_usage of httpfs.sh. The kms words should be replaced with httpfs:

      function hadoop_usage
      {
        hadoop_add_subcommand "run" "Start kms in the current window"
        hadoop_add_subcommand "run -security" "Start in the current window with security manager"
        hadoop_add_subcommand "start" "Start kms in a separate window"
        hadoop_add_subcommand "start -security" "Start in a separate window with security manager"
        hadoop_add_subcommand "status" "Return the LSB compliant status"
        hadoop_add_subcommand "stop" "Stop kms, waiting up to 5 seconds for the process to end"
        hadoop_add_subcommand "top n" "Stop kms, waiting up to n seconds for the process to end"
        hadoop_add_subcommand "stop -force" "Stop kms, wait up to 5 seconds and then use kill -KILL if still running"
        hadoop_add_subcommand "stop n -force" "Stop kms, wait up to n seconds and then use kill -KILL if still running"
        hadoop_generate_usage "${MYNAME}" false
      }
      
      1. HDFS-10835.001.patch
        2 kB
        John Zhuge
      2. HDFS-10835.002.patch
        2 kB
        John Zhuge
      3. HDFS-10835.003.patch
        2 kB
        John Zhuge
      4. HDFS-10835.004.patch
        2 kB
        John Zhuge
      5. HDFS-10835.005.patch
        2 kB
        John Zhuge

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Patch 001:

        • Replace words kms with https
        • No unit test for startup script

        Manual test output:

        $ sbin/httpfs.sh -h
        Usage: httpfs.sh [OPTIONS] SUBCOMMAND [SUBCOMMAND OPTIONS]
        
          OPTIONS is none or any of:
        
        --config dir   Hadoop config directory
        --debug        turn on shell script debug mode
        --help         usage information
        
          SUBCOMMAND is one of:
        
        run -security     Start in the current window with security manager
        run               Start httpfs in the current window
        start -security   Start in a separate window with security manager
        start             Start httpfs in a separate window
        status            Return the LSB compliant status
        stop -force       Stop httpfs, wait up to 5 seconds and then use kill -KILL if still running
        stop n -force     Stop httpfs, wait up to n seconds and then use kill -KILL if still running
        stop              Stop httpfs, waiting up to 5 seconds for the process to end
        top n             Stop httpfs, waiting up to n seconds for the process to end
        
        SUBCOMMAND may print help when invoked w/o parameters or with -h.
        
        Show
        jzhuge John Zhuge added a comment - Patch 001: Replace words kms with https No unit test for startup script Manual test output: $ sbin/httpfs.sh -h Usage: httpfs.sh [OPTIONS] SUBCOMMAND [SUBCOMMAND OPTIONS] OPTIONS is none or any of: --config dir Hadoop config directory --debug turn on shell script debug mode --help usage information SUBCOMMAND is one of: run -security Start in the current window with security manager run Start httpfs in the current window start -security Start in a separate window with security manager start Start httpfs in a separate window status Return the LSB compliant status stop -force Stop httpfs, wait up to 5 seconds and then use kill -KILL if still running stop n -force Stop httpfs, wait up to n seconds and then use kill -KILL if still running stop Stop httpfs, waiting up to 5 seconds for the process to end top n Stop httpfs, waiting up to n seconds for the process to end SUBCOMMAND may print help when invoked w/o parameters or with -h.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        0 shelldocs 0m 24s Shelldocs was not available.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 2s trunk passed
        +1 mvnsite 0m 34s trunk passed
        +1 mvnsite 0m 27s the patch passed
        +1 shellcheck 0m 13s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 0m 16s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        11m 34s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10835
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826934/HDFS-10835.001.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux 86f9b74a9f8e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f6ea9be
        shellcheck v0.4.4
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16622/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16622/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. 0 shelldocs 0m 24s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 2s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvnsite 0m 27s the patch passed +1 shellcheck 0m 13s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 16s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 11m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10835 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826934/HDFS-10835.001.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 86f9b74a9f8e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f6ea9be shellcheck v0.4.4 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16622/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16622/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        Why is this marked as affecting 2.6.0? How can this possibly target 2.8.0?

        Show
        aw Allen Wittenauer added a comment - Why is this marked as affecting 2.6.0? How can this possibly target 2.8.0?
        Hide
        jzhuge John Zhuge added a comment -

        Patch 002:

        • Use the official name HttpFS
        Show
        jzhuge John Zhuge added a comment - Patch 002: Use the official name HttpFS
        Hide
        jzhuge John Zhuge added a comment -

        Fixed. Thanks for catching my mistakes.

        Show
        jzhuge John Zhuge added a comment - Fixed. Thanks for catching my mistakes.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks John Zhuge for working on this, and Allen Wittenauer for commenting.

        To explain Allen's comment, the typo seems to be introduced by HADOOP-12249, which is 3.0 only.
        Suggest to update versions accordingly.

        • please also update the comment to be consistent on HttpFS
        • you probably already know this: kms.sh is pretty much the same. Have we considered abstract the helper function somehow?
        Show
        xiaochen Xiao Chen added a comment - Thanks John Zhuge for working on this, and Allen Wittenauer for commenting. To explain Allen's comment, the typo seems to be introduced by HADOOP-12249 , which is 3.0 only. Suggest to update versions accordingly. please also update the comment to be consistent on HttpFS you probably already know this: kms.sh is pretty much the same. Have we considered abstract the helper function somehow?
        Hide
        jzhuge John Zhuge added a comment -

        Patch 003:

        • Use HttpFS in the comment

        Thanks Xiao Chen for the explanation. Already fixed the versions. As for abstracting the helper, I feel it is an overkill right now. If another component starts using Tomcat Catalina, it would be a good idea.

        Show
        jzhuge John Zhuge added a comment - Patch 003: Use HttpFS in the comment Thanks Xiao Chen for the explanation. Already fixed the versions. As for abstracting the helper, I feel it is an overkill right now. If another component starts using Tomcat Catalina, it would be a good idea.
        Hide
        xiaochen Xiao Chen added a comment -

        hadoop_add_subcommand "top n" "Stop $name, waiting up to n seconds for the process to end"
        Let's correct the typo here as well. s/top/stop/g.

        Otherwise LGTM. I'm okay to keep this just a simple typo fix. Thanks John.

        Any comments Allen Wittenauer?

        Show
        xiaochen Xiao Chen added a comment - hadoop_add_subcommand "top n" "Stop $name, waiting up to n seconds for the process to end" Let's correct the typo here as well. s/top/stop/g. Otherwise LGTM. I'm okay to keep this just a simple typo fix. Thanks John. Any comments Allen Wittenauer ?
        Hide
        jzhuge John Zhuge added a comment -

        Patch 004:

        • Fix misspelled "top" with "stop"

        Xiao Chen, thanks for catching that typo.

        Show
        jzhuge John Zhuge added a comment - Patch 004: Fix misspelled "top" with "stop" Xiao Chen , thanks for catching that typo.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        0 shelldocs 0m 6s Shelldocs was not available.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 8s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvnsite 0m 25s the patch passed
        +1 shellcheck 0m 14s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 0m 17s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        11m 7s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10835
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826958/HDFS-10835.004.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux 66c908feb5ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 07650bc
        shellcheck v0.4.4
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16628/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16628/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. 0 shelldocs 0m 6s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 8s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvnsite 0m 25s the patch passed +1 shellcheck 0m 14s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 17s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 11m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10835 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826958/HDFS-10835.004.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 66c908feb5ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 07650bc shellcheck v0.4.4 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16628/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16628/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        you probably already know this: kms.sh is pretty much the same. Have we considered abstract the helper function somehow?

        It's almost all boiler plate now. Plus every three months someone says "we are using an old version of tomcat" followed by a "we shouldn't really be using tomcat" and then nothing happens. As soon as someone actually does the work to get us off of tomcat, this code should hopefully re-arrange into something else that looks more like the rest of Hadoop rather than clearly written as a one-off.

        As to the code, I don't really understand why the name var exists, but whatever.

        Show
        aw Allen Wittenauer added a comment - you probably already know this: kms.sh is pretty much the same. Have we considered abstract the helper function somehow? It's almost all boiler plate now. Plus every three months someone says "we are using an old version of tomcat" followed by a "we shouldn't really be using tomcat" and then nothing happens. As soon as someone actually does the work to get us off of tomcat, this code should hopefully re-arrange into something else that looks more like the rest of Hadoop rather than clearly written as a one-off. As to the code, I don't really understand why the name var exists, but whatever.
        Hide
        jzhuge John Zhuge added a comment -

        Patch 005:

        • Do not use local var name

        Allen Wittenauer, Xiao Chen and I are planning to convert both HttpFS and KMS from Tomcat to Jetty 9 pretty soon. It is for real this time I will probably create 2 sub-tasks under HADOOP-10075.

        Show
        jzhuge John Zhuge added a comment - Patch 005: Do not use local var name Allen Wittenauer , Xiao Chen and I are planning to convert both HttpFS and KMS from Tomcat to Jetty 9 pretty soon. It is for real this time I will probably create 2 sub-tasks under HADOOP-10075 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        0 shelldocs 0m 35s Shelldocs was not available.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 24s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvnsite 0m 23s the patch passed
        +1 shellcheck 0m 12s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 0m 16s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        10m 40s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10835
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827201/HDFS-10835.005.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux c1fb9543dead 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 62a9667
        shellcheck v0.4.4
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16646/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16646/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. 0 shelldocs 0m 35s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 24s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvnsite 0m 23s the patch passed +1 shellcheck 0m 12s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 16s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 10m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10835 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827201/HDFS-10835.005.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux c1fb9543dead 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 62a9667 shellcheck v0.4.4 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16646/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16646/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        +1 on patch 5, committing this.

        Show
        xiaochen Xiao Chen added a comment - +1 on patch 5, committing this.
        Hide
        xiaochen Xiao Chen added a comment -

        Committed to trunk.

        Thanks John Zhuge for fixing the issue, and Allen Wittenauer for reviews.

        Show
        xiaochen Xiao Chen added a comment - Committed to trunk. Thanks John Zhuge for fixing the issue, and Allen Wittenauer for reviews.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Xiao Chen for the review and commit, Allen Wittenauer for the review.

        Show
        jzhuge John Zhuge added a comment - Thanks Xiao Chen for the review and commit, Allen Wittenauer for the review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10399 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10399/)
        HDFS-10835. Fix typos in httpfs.sh. Contributed by John Zhuge. (xiao: rev 7c213c341d047362e6f8b66ab3ffafaf639d8d31)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/sbin/httpfs.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10399 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10399/ ) HDFS-10835 . Fix typos in httpfs.sh. Contributed by John Zhuge. (xiao: rev 7c213c341d047362e6f8b66ab3ffafaf639d8d31) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/sbin/httpfs.sh

          People

          • Assignee:
            jzhuge John Zhuge
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development