Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10795

Fix an error in ReaderStrategy#ByteBufferStrategy

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ReaderStrategy#ByteBufferStrategy's function readFromBlock allocate a temp ByteBuffer, but not used. Refactor to make it more reasonable.

        Activity

        Hide
        Sammi SammiChen added a comment -

        upload the patch

        Show
        Sammi SammiChen added a comment - upload the patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 41s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 29s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 0m 37s the patch passed
        +1 javac 0m 37s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvnsite 0m 42s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 21s the patch passed
        +1 unit 1m 4s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        18m 48s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825450/HDFS-10795-v1.patch
        JIRA Issue HDFS-10795
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 38cad42e3941 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 525d52b
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16536/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16536/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 41s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 0m 37s the patch passed +1 javac 0m 37s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 42s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 21s the patch passed +1 unit 1m 4s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 18m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825450/HDFS-10795-v1.patch JIRA Issue HDFS-10795 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 38cad42e3941 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 525d52b Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16536/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16536/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        The patch LGTM and +1.

        Show
        drankye Kai Zheng added a comment - The patch LGTM and +1.
        Hide
        drankye Kai Zheng added a comment -

        Committed to 3.0.0-alpha1 and trunk branches. Thanks SammiChen for the contribution.

        Show
        drankye Kai Zheng added a comment - Committed to 3.0.0-alpha1 and trunk branches. Thanks SammiChen for the contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10350 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10350/)
        HDFS-10795. Fix an error in ReaderStrategy#ByteBufferStrategy. (kai.zheng: rev f4a21d3abaa7c5a9f0a0d8417e81f7eaf3d1b29a)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReaderStrategy.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10350 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10350/ ) HDFS-10795 . Fix an error in ReaderStrategy#ByteBufferStrategy. (kai.zheng: rev f4a21d3abaa7c5a9f0a0d8417e81f7eaf3d1b29a) (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReaderStrategy.java

          People

          • Assignee:
            Sammi SammiChen
            Reporter:
            Sammi SammiChen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development