Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10747

o.a.h.hdfs.tools.DebugAdmin usage message is misleading

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.7.4
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-6917 added a helpful hdfs debug command to validate blocks and call recoverlease. The usage doc is kinda misleading, as following:

      $ hdfs debug verify
      creating a new configuration
      verify [-meta <metadata-file>] [-block <block-file>]
        Verify HDFS metadata and block files.  If a block file is specified, we
        will verify that the checksums in the metadata file match the block
        file.
      

      Actually the -meta <metadata-file> is necessary. [] is for optional arguments, if we follow the convention.

      $ hdfs debug recoverLease
      creating a new configuration
      recoverLease [-path <path>] [-retries <num-retries>]
        Recover the lease on the specified path.  The path must reside on an
        HDFS filesystem.  The default number of retries is 1.
      

      -path <path> is also the same case.

        Issue Links

          Activity

          Hide
          liuml07 Mingliang Liu added a comment -

          Ping Colin P. McCabe and Vijay Bhat for thoughts. Thanks.

          Show
          liuml07 Mingliang Liu added a comment - Ping Colin P. McCabe and Vijay Bhat for thoughts. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 31s trunk passed
          +1 compile 0m 55s trunk passed
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 1m 2s trunk passed
          +1 mvninstall 0m 54s the patch passed
          +1 compile 0m 48s the patch passed
          +1 javac 0m 48s the patch passed
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 0s the patch passed
          +1 javadoc 0m 56s the patch passed
          +1 unit 61m 53s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          84m 5s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823123/HDFS-10747.000.patch
          JIRA Issue HDFS-10747
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7915b9a31572 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 89c0bff
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16392/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16392/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 31s trunk passed +1 compile 0m 55s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 2s trunk passed +1 mvninstall 0m 54s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 0m 56s the patch passed +1 unit 61m 53s hadoop-hdfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 84m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823123/HDFS-10747.000.patch JIRA Issue HDFS-10747 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7915b9a31572 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 89c0bff Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16392/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16392/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Yes the usage is misleading. Thanks Mingliang Liu for bringing this up. I think the patch looks good to me.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Yes the usage is misleading. Thanks Mingliang Liu for bringing this up. I think the patch looks good to me.
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed from trunk through branch-2.7. Thanks Wei-Chiu Chuang for review.

          Show
          liuml07 Mingliang Liu added a comment - Committed from trunk through branch-2.7 . Thanks Wei-Chiu Chuang for review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10280 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10280/)
          HDFS-10747. o.a.h.hdfs.tools.DebugAdmin usage message is misleading. (liuml07: rev ef55fe171691446d38e6a14e92c1fd4d3d0c64c5)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10280 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10280/ ) HDFS-10747 . o.a.h.hdfs.tools.DebugAdmin usage message is misleading. (liuml07: rev ef55fe171691446d38e6a14e92c1fd4d3d0c64c5) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development