Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10731

FSDirectory#verifyMaxDirItems does not log path name

    Details

      Description

      2016-08-05 14:42:04,687 ERROR org.apache.hadoop.hdfs.server.namenode.NameNode: FSDirectory.verifyMaxDirItems: The directory item limit of null is exceeded: limit=1048576 items=1048576

      The error message above logs the path name incorrectly (null). Without the path name it is hard to tell which directory is in trouble. The exception should set the path name before being logged.

      This bug was seen on a CDH 5.5.2 cluster, but CDH5.5.2 is roughly up to date with Apache Hadoop 2.7.2.

      1. HDFS-10731.001.patch
        2 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Attach v01 patch to add path name in the constructor of MaxDirectoryItemsExceededException.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Attach v01 patch to add path name in the constructor of MaxDirectoryItemsExceededException .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 19s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 56s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 43s the patch passed
          +1 javac 0m 43s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 56s the patch passed
          -1 unit 64m 8s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          84m 54s



          Reason Tests
          Failed junit tests hadoop.security.TestRefreshUserMappings
            hadoop.tracing.TestTracing
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822598/HDFS-10731.001.patch
          JIRA Issue HDFS-10731
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f0972731230d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d3af47
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16338/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16338/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16338/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 19s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 56s the patch passed -1 unit 64m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 84m 54s Reason Tests Failed junit tests hadoop.security.TestRefreshUserMappings   hadoop.tracing.TestTracing   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822598/HDFS-10731.001.patch JIRA Issue HDFS-10731 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f0972731230d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d3af47 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16338/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16338/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16338/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment - - edited

          TestRefreshUserMappings.testRefreshSuperUserGroupsConfiguration is an existing failure being tracked by HADOOP-13469. It is also failing in my local tree without the patch.

          TestTracing.testTracing has been failing for quite some time. It's also failing in my local tree without the patch.

          TestFailureToReadEdits.testCheckpointStartingMidEditsFile is an existing bug reported in HDFS-9591. It passed in my local tree.

          Show
          jojochuang Wei-Chiu Chuang added a comment - - edited TestRefreshUserMappings.testRefreshSuperUserGroupsConfiguration is an existing failure being tracked by HADOOP-13469 . It is also failing in my local tree without the patch. TestTracing.testTracing has been failing for quite some time. It's also failing in my local tree without the patch. TestFailureToReadEdits.testCheckpointStartingMidEditsFile is an existing bug reported in HDFS-9591 . It passed in my local tree.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Filed HDFS-10732 for the failure of TestTracing.testTracing.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Filed HDFS-10732 for the failure of TestTracing.testTracing.
          Hide
          xiaochen Xiao Chen added a comment -

          This changes the constructor of the exception, but since the class is marked as Private and Evolving, we should be good. Agree with assessment on test failures too.
          +1, thanks Wei-Chiu.

          Show
          xiaochen Xiao Chen added a comment - This changes the constructor of the exception, but since the class is marked as Private and Evolving , we should be good. Agree with assessment on test failures too. +1, thanks Wei-Chiu.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Committed to trunk, branch-2 and branch-2.8
          Thanks Xiao Chen for reviewing the patch!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Committed to trunk, branch-2 and branch-2.8 Thanks Xiao Chen for reviewing the patch!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10268 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10268/)
          HDFS-10731. FSDirectory#verifyMaxDirItems does not log path name. (weichiu: rev 9019606b69bfb7019c8642b6cbcbb93645cc19e3)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSLimitException.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10268 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10268/ ) HDFS-10731 . FSDirectory#verifyMaxDirItems does not log path name. (weichiu: rev 9019606b69bfb7019c8642b6cbcbb93645cc19e3) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSLimitException.java

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development