Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10694

BlockManager.processReport() should print blockReportId in each log message.

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently BlockManager.processReport() is printing blockReportId in some log message, but doesn't in other. It should consistently print blockReportId. This is helpful in debugging block report problems, so that you could see which message belongs to which report.

      1. HDFS-10694.001.patch
        5 kB
        Yuanbo Liu
      2. HDFS-10694.002.patch
        5 kB
        Yuanbo Liu
      3. HDFS-10694.003.patch
        5 kB
        Yuanbo Liu
      4. HDFS-10694.004.patch
        6 kB
        Yuanbo Liu
      5. HDFS-10694-branch-2.7.001.patch
        5 kB
        Yuanbo Liu
      6. HDFS-10694-branch-2.001.patch
        5 kB
        Yuanbo Liu

        Activity

        Hide
        yuanbo Yuanbo Liu added a comment -

        Thanks very much! Konstantin Shvachko

        Show
        yuanbo Yuanbo Liu added a comment - Thanks very much! Konstantin Shvachko
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10253 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10253/)
        HDFS-10694. processReport() should print blockReportId in each log (shv: rev 10e84c6a6e831fe2bea061fb21bd0dfe32bc9953)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10253 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10253/ ) HDFS-10694 . processReport() should print blockReportId in each log (shv: rev 10e84c6a6e831fe2bea061fb21bd0dfe32bc9953) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        shv Konstantin Shvachko added a comment -

        I just committed this to trunk, branch-2, 2.8 and 2.7. Thank you Yuanbo Liu.

        Show
        shv Konstantin Shvachko added a comment - I just committed this to trunk, branch-2, 2.8 and 2.7. Thank you Yuanbo Liu.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 51s branch-2 passed
        +1 compile 0m 44s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 47s branch-2 passed with JDK v1.7.0_101
        +1 checkstyle 0m 30s branch-2 passed
        +1 mvnsite 0m 53s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 1m 59s branch-2 passed
        +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 36s branch-2 passed with JDK v1.7.0_101
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.8.0_101
        +1 javac 0m 46s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.7.0_101
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 15s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 33s the patch passed with JDK v1.7.0_101
        -1 unit 47m 31s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        124m 22s



        Reason Tests
        JDK v1.8.0_101 Failed junit tests hadoop.tracing.TestTracing
          hadoop.security.TestRefreshUserMappings
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
        JDK v1.7.0_101 Failed junit tests hadoop.tracing.TestTracing
          hadoop.security.TestRefreshUserMappings



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822718/HDFS-10694-branch-2.001.patch
        JIRA Issue HDFS-10694
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1612110fd402 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 427b540
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16353/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16353/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16353/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 51s branch-2 passed +1 compile 0m 44s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 47s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 30s branch-2 passed +1 mvnsite 0m 53s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 59s branch-2 passed +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 36s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 50s the patch passed +1 compile 0m 46s the patch passed with JDK v1.8.0_101 +1 javac 0m 46s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_101 +1 javac 0m 46s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 15s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 33s the patch passed with JDK v1.7.0_101 -1 unit 47m 31s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 124m 22s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.tracing.TestTracing   hadoop.security.TestRefreshUserMappings   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery JDK v1.7.0_101 Failed junit tests hadoop.tracing.TestTracing   hadoop.security.TestRefreshUserMappings Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822718/HDFS-10694-branch-2.001.patch JIRA Issue HDFS-10694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1612110fd402 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 427b540 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16353/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16353/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16353/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        uploaded branch-2, branch-2.7 patch for this issue.
        Konstantin Shvachko Please take a look if you have time.

        Show
        yuanbo Yuanbo Liu added a comment - uploaded branch-2, branch-2.7 patch for this issue. Konstantin Shvachko Please take a look if you have time.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Sure

        Show
        yuanbo Yuanbo Liu added a comment - Sure
        Hide
        shv Konstantin Shvachko added a comment -

        Hey Yuanbo, could you please also submit a patch for branch-2 and branch-2.7 if they are different.

        Show
        shv Konstantin Shvachko added a comment - Hey Yuanbo, could you please also submit a patch for branch-2 and branch-2.7 if they are different.
        Hide
        shv Konstantin Shvachko added a comment -

        +1 looks good.
        Test failures unrelated.

        Show
        shv Konstantin Shvachko added a comment - +1 looks good. Test failures unrelated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 36s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 48s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 52s the patch passed
        -1 unit 59m 14s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        81m 16s



        Reason Tests
        Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController
          hadoop.security.TestRefreshUserMappings
          hadoop.tracing.TestTracing
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822246/HDFS-10694.004.patch
        JIRA Issue HDFS-10694
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fc58eeee90e1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 18d9e6e
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16330/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16330/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16330/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 36s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 59m 14s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 81m 16s Reason Tests Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.security.TestRefreshUserMappings   hadoop.tracing.TestTracing   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822246/HDFS-10694.004.patch JIRA Issue HDFS-10694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fc58eeee90e1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 18d9e6e Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16330/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16330/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16330/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Konstantin Shvachko Sure, uploaded v4 patch to address your comments. Thanks for your suggestion.

        Show
        yuanbo Yuanbo Liu added a comment - Konstantin Shvachko Sure, uploaded v4 patch to address your comments. Thanks for your suggestion.
        Hide
        shv Konstantin Shvachko added a comment -
        1. You are right there is no context in processReport(). So would it make sense to replace two parameters ordered and reportId with one context? Then you can get the former two inside processReport().
          processReport(storageInfo, report, context) throws IOException
        2. Good that you noticed. For "first storage report" we should probably replace LOG with blockLog to make it consistent with other messages.
          Also could please use substitutions in the message rather than string concatenation. People are trying to covert to sl4j style I was told.
        Show
        shv Konstantin Shvachko added a comment - You are right there is no context in processReport(). So would it make sense to replace two parameters ordered and reportId with one context? Then you can get the former two inside processReport(). processReport(storageInfo, report, context) throws IOException Good that you noticed. For "first storage report" we should probably replace LOG with blockLog to make it consistent with other messages. Also could please use substitutions in the message rather than string concatenation. People are trying to covert to sl4j style I was told.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 15s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 41s trunk passed
        +1 javadoc 0m 55s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 52s the patch passed
        -1 unit 69m 20s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        88m 52s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestCrcCorruption
          hadoop.tracing.TestTracing
          hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822022/HDFS-10694.003.patch
        JIRA Issue HDFS-10694
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 68df6fd2ff6c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 08e3338
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16315/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16315/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16315/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 15s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 69m 20s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 88m 52s Reason Tests Failed junit tests hadoop.hdfs.TestCrcCorruption   hadoop.tracing.TestTracing   hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822022/HDFS-10694.003.patch JIRA Issue HDFS-10694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 68df6fd2ff6c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 08e3338 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16315/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16315/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16315/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Konstantin Shvachko Thanks for your comments.
        1. Actually context is not a parameter of the private method processReport, see the code as below:

                invalidatedBlocks = processReport(storageInfo, newReport,
                    context != null ? context.isSorted() : false, strBlockReportId);
        

        context is used in ternary expression, so I keep this change in my patch.
        2.

        Also did you miss "Processing first storage report ..."?

        It's printed by process log, not block blog. But it's good to print block id here.
        I uploaded v3 patch to address your comments, hope to get your thoughts. Thanks again for your time.

        Show
        yuanbo Yuanbo Liu added a comment - Konstantin Shvachko Thanks for your comments. 1. Actually context is not a parameter of the private method processReport , see the code as below: invalidatedBlocks = processReport(storageInfo, newReport, context != null ? context.isSorted() : false , strBlockReportId); context is used in ternary expression, so I keep this change in my patch. 2. Also did you miss "Processing first storage report ..."? It's printed by process log, not block blog. But it's good to print block id here. I uploaded v3 patch to address your comments, hope to get your thoughts. Thanks again for your time.
        Hide
        shv Konstantin Shvachko added a comment -

        I don't think it is a good idea to add parameter to processReport() as it already passed via context.
        Also did you miss "Processing first storage report ..."?

        Show
        shv Konstantin Shvachko added a comment - I don't think it is a good idea to add parameter to processReport() as it already passed via context. Also did you miss "Processing first storage report ..."?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 17m 51s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 49s trunk passed
        +1 compile 0m 50s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 1m 8s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 2m 4s trunk passed
        +1 javadoc 1m 2s trunk passed
        +1 mvninstall 1m 2s the patch passed
        +1 compile 0m 58s the patch passed
        +1 javac 0m 58s the patch passed
        +1 checkstyle 0m 29s the patch passed
        +1 mvnsite 1m 5s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 0m 54s the patch passed
        -1 unit 75m 44s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        116m 38s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821251/HDFS-10694.002.patch
        JIRA Issue HDFS-10694
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f117a2e2b178 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 34ccaa8
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16271/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16271/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16271/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 17m 51s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 49s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 2s trunk passed +1 mvninstall 1m 2s the patch passed +1 compile 0m 58s the patch passed +1 javac 0m 58s the patch passed +1 checkstyle 0m 29s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 75m 44s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 116m 38s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821251/HDFS-10694.002.patch JIRA Issue HDFS-10694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f117a2e2b178 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34ccaa8 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16271/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16271/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16271/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Uploaded v2 patch because of checkstyle failure. The test failure is not relate to my code change.

        Show
        yuanbo Yuanbo Liu added a comment - Uploaded v2 patch because of checkstyle failure. The test failure is not relate to my code change.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 7s trunk passed
        +1 compile 1m 0s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 1m 10s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 1m 5s trunk passed
        +1 mvninstall 1m 2s the patch passed
        +1 compile 0m 55s the patch passed
        +1 javac 0m 55s the patch passed
        -0 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 128 unchanged - 0 fixed = 130 total (was 128)
        +1 mvnsite 1m 8s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 0m 58s the patch passed
        -1 unit 69m 13s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        93m 16s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821204/HDFS-10694.001.patch
        JIRA Issue HDFS-10694
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 126d2c4299a9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3d191cc
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16270/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16270/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16270/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16270/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 7s trunk passed +1 compile 1m 0s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 5s trunk passed +1 mvninstall 1m 2s the patch passed +1 compile 0m 55s the patch passed +1 javac 0m 55s the patch passed -0 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 128 unchanged - 0 fixed = 130 total (was 128) +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 0m 58s the patch passed -1 unit 69m 13s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 93m 16s Reason Tests Failed junit tests hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821204/HDFS-10694.001.patch JIRA Issue HDFS-10694 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 126d2c4299a9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3d191cc Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16270/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16270/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16270/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16270/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Konstantin Shvachko Thanks for filing it.
        This issue is relate to log info improvement, so I think it's ok not to write test case here.

        Show
        yuanbo Yuanbo Liu added a comment - Konstantin Shvachko Thanks for filing it. This issue is relate to log info improvement, so I think it's ok not to write test case here.

          People

          • Assignee:
            yuanbo Yuanbo Liu
            Reporter:
            shv Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development