Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10693

metaSave should print blocks, not LightWeightHashSet

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.1
    • Fix Version/s: 2.7.4
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      metaSave command does not print actually block info for invalid blocks. This is because it is trying to print instances of LightWeightHashSet<Block>, which is not informative.
      See InvalidateBlocks.dump() method.

        Activity

        Hide
        yuanbo Yuanbo Liu added a comment -

        Konstantin Shvachko
        Thanks for filing this. I've prepared v1 patch for this issue.
        To my knowledge, metaSave is some kind of report tool, it will not cause compatible problem if I change the output form of metaSave, am I right?

        Show
        yuanbo Yuanbo Liu added a comment - Konstantin Shvachko Thanks for filing this. I've prepared v1 patch for this issue. To my knowledge, metaSave is some kind of report tool, it will not cause compatible problem if I change the output form of metaSave, am I right?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 50s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 49s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 54s trunk passed
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 44s the patch passed
        +1 javac 0m 44s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 54s the patch passed
        -1 unit 74m 7s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        93m 6s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821200/HDFS-10693.001.patch
        JIRA Issue HDFS-10693
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cc2bc3c5509f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3d191cc
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16269/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16269/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 50s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 74m 7s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 93m 6s Reason Tests Failed junit tests hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821200/HDFS-10693.001.patch JIRA Issue HDFS-10693 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cc2bc3c5509f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3d191cc Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16269/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16269/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        the test failure is not related to my change.

        Show
        yuanbo Yuanbo Liu added a comment - the test failure is not related to my change.
        Hide
        shv Konstantin Shvachko added a comment -

        +1. This looks good.

        Show
        shv Konstantin Shvachko added a comment - +1. This looks good.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Konstantin ShvachkoThanks for your review. Is there anything else I should do before this patch is committed?

        Show
        yuanbo Yuanbo Liu added a comment - Konstantin Shvachko Thanks for your review. Is there anything else I should do before this patch is committed?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        LGTM. +1

        Show
        brahmareddy Brahma Reddy Battula added a comment - LGTM. +1
        Hide
        shv Konstantin Shvachko added a comment -

        I just committed this to trunk, branch-2, 2.8 and 2.7. Thank you Yuanbo Liu.

        Show
        shv Konstantin Shvachko added a comment - I just committed this to trunk, branch-2, 2.8 and 2.7. Thank you Yuanbo Liu.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10231 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10231/)
        HDFS-10693. metaSave should print blocks, not LightWeightHashSet. (shv: rev 4d3af47f2765f6f57936d316ef2a4150b787cc97)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestMetaSave.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10231 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10231/ ) HDFS-10693 . metaSave should print blocks, not LightWeightHashSet. (shv: rev 4d3af47f2765f6f57936d316ef2a4150b787cc97) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestMetaSave.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java
        Hide
        yuanbo Yuanbo Liu added a comment -
        Show
        yuanbo Yuanbo Liu added a comment - Konstantin Shvachko Brahma Reddy Battula Thanks for your time!

          People

          • Assignee:
            yuanbo Yuanbo Liu
            Reporter:
            shv Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development