Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
3.0.0-alpha2
-
None
-
Reviewed
-
ShortCircuitCache
Description
Currently in ShortCircuitCache, two TreeMap objects are used to track the cached replicas.
private final TreeMap<Long, ShortCircuitReplica> evictable = new TreeMap<>();
private final TreeMap<Long, ShortCircuitReplica> evictableMmapped = new TreeMap<>();
TreeMap employs Red-Black tree for sorting. This isn't an issue when using traditional HDD. But when using high-performance SSD/PCIe Flash, the cost inserting/removing an entry becomes considerable.
To mitigate it, we designed a new list-based for replica tracking.
The list is a double-linked FIFO. FIFO is time-based, thus insertion is a very low cost operation. On the other hand, list is not lookup-friendly. To address this issue, we introduce two references into ShortCircuitReplica object.
ShortCircuitReplica next = null;
ShortCircuitReplica prev = null;
In this way, lookup is not needed when removing a replica from the list. We only need to modify its predecessor's and successor's references in the lists.
Our tests showed up to 15-50% performance improvement when using PCIe flash as storage media.
The original patch is against 2.6.4, now I am porting to Hadoop trunk, and patch will be posted soon.
Attachments
Attachments
Issue Links
- is related to
-
HBASE-15619 Performance regression observed: Empty random read(get) performance of branch-1 worse than 0.98
-
- Resolved
-
- relates to
-
-
- Open
-
