Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10623

Remove unused import of httpclient.HttpConnection from TestWebHdfsTokens.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.3
    • Component/s: hdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestWebHdfsTokens imports httpclient.HttpConnection, and causes unnecessary reference to httpclient. This can be removed.

      1. HDFS-10623.000.patch
        0.7 kB
        Hanisha Koneru
      2. HDFS-10623-branch-2.7.3.000.patch
        0.7 kB
        Hanisha Koneru

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HDFS-10623 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817991/HDFS-10623.000.patch
          JIRA Issue HDFS-10623
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16058/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HDFS-10623 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817991/HDFS-10623.000.patch JIRA Issue HDFS-10623 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16058/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 this doesn't need a full Jenkins run.

          The test builds and passes with the patch so I will commit it shortly.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 this doesn't need a full Jenkins run. The test builds and passes with the patch so I will commit it shortly.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed to branch-2.7 and branch-2.7.3. Thank you for the contribution Hanisha Koneru.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed to branch-2.7 and branch-2.7.3. Thank you for the contribution Hanisha Koneru .
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Thank you Arpit Agarwal for reviewing and committing the patch.

          Show
          hanishakoneru Hanisha Koneru added a comment - Thank you Arpit Agarwal for reviewing and committing the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 32s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 39s branch-2.7.3 passed
          +1 compile 1m 10s branch-2.7.3 passed with JDK v1.8.0_91
          +1 compile 1m 4s branch-2.7.3 passed with JDK v1.7.0_101
          +1 checkstyle 0m 23s branch-2.7.3 passed
          +1 mvnsite 1m 2s branch-2.7.3 passed
          +1 mvneclipse 0m 15s branch-2.7.3 passed
          +1 findbugs 3m 9s branch-2.7.3 passed
          +1 javadoc 1m 20s branch-2.7.3 passed with JDK v1.8.0_91
          +1 javadoc 2m 3s branch-2.7.3 passed with JDK v1.7.0_101
          +1 mvninstall 0m 55s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.8.0_91
          +1 javac 0m 58s the patch passed
          +1 compile 1m 0s the patch passed with JDK v1.7.0_101
          +1 javac 1m 0s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          -1 whitespace 0m 0s The patch has 1382 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 37s The patch 70 line(s) with tabs.
          +1 findbugs 3m 14s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 55s the patch passed with JDK v1.7.0_101
          -1 unit 54m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 21s The patch generated 3 ASF License warnings.
          138m 14s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
          JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.web.TestWebHdfsTokens
            hadoop.hdfs.TestDataTransferKeepalive
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.TestRollingUpgrade



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818002/HDFS-10623-branch-2.7.3.000.patch
          JIRA Issue HDFS-10623
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b54152e8465e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7.3 / 66eb447
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16061/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16061/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 39s branch-2.7.3 passed +1 compile 1m 10s branch-2.7.3 passed with JDK v1.8.0_91 +1 compile 1m 4s branch-2.7.3 passed with JDK v1.7.0_101 +1 checkstyle 0m 23s branch-2.7.3 passed +1 mvnsite 1m 2s branch-2.7.3 passed +1 mvneclipse 0m 15s branch-2.7.3 passed +1 findbugs 3m 9s branch-2.7.3 passed +1 javadoc 1m 20s branch-2.7.3 passed with JDK v1.8.0_91 +1 javadoc 2m 3s branch-2.7.3 passed with JDK v1.7.0_101 +1 mvninstall 0m 55s the patch passed +1 compile 0m 58s the patch passed with JDK v1.8.0_91 +1 javac 0m 58s the patch passed +1 compile 1m 0s the patch passed with JDK v1.7.0_101 +1 javac 1m 0s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 1382 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 37s The patch 70 line(s) with tabs. +1 findbugs 3m 14s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_101 -1 unit 54m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 21s The patch generated 3 ASF License warnings. 138m 14s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818002/HDFS-10623-branch-2.7.3.000.patch JIRA Issue HDFS-10623 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b54152e8465e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7.3 / 66eb447 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16061/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16061/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16061/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              hanishakoneru Hanisha Koneru
              Reporter:
              jnp Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development