Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10620

StringBuilder created and appended even if logging is disabled

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.6.4
    • 2.9.0, 3.0.0-alpha1
    • namenode
    • None

    Description

      In BlockManager.addToInvalidates the StringBuilder is appended to during the delete even if logging isn't active.

      Could avoid allocating the StringBuilder as well, but not sure if it is really worth it to add null handling in the code.

      Attachments

        1. HDFS-10620.001.patch
          0.9 kB
          Staffan Friberg
        2. HDFS-10620.002.patch
          1 kB
          Akira Ajisaka
        3. HDFS-10620-branch-2.01.patch
          1 kB
          Akira Ajisaka

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sfriberg Staffan Friberg
            sfriberg Staffan Friberg
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment