[HDFS-10620] StringBuilder created and appended even if logging is disabled

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.4
• Fix Version/s: 2.9.0, 3.0.0-alpha1
• Component/s: namenode
• Target Version/s: 2.9.0, 3.0.0-alpha4
• Hadoop Flags: Reviewed
• Assignee: Staffan Friberg
• Reporter: Staffan Friberg
• Created: 13/Jul/16 21:00
• Updated: 21/Apr/17 21:21
• Resolved: 24/Feb/17 19:18

Description

In BlockManager.addToInvalidates the StringBuilder is appended to during the delete even if logging isn't active.

Could avoid allocating the StringBuilder as well, but not sure if it is really worth it to add null handling in the code.