Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10576 DiskBalancer followup work items
  3. HDFS-10600

PlanCommand#getThrsholdPercentage should not use throughput value.

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.9.0, 3.0.0-beta1
    • 3.0.0-alpha1
    • diskbalancer
    • None

    Description

      In PlanCommand#getThresholdPercentage

       private double getThresholdPercentage(CommandLine cmd) {
      ....
          if ((value <= 0.0) || (value > 100.0)) {
            value = getConf().getDouble(
                DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT,
                DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT_DEFAULT);
          }
          return value;
        }
      

      DISK_THROUGHPUT has the unit of "MB", so it does not make sense to return throughput as a percentage value.

      Btw, we should use THROUGHPUT instead of THRUPUT.

      Attachments

        1. HDFS-10600.002.patch
          5 kB
          Yiqun Lin
        2. HDFS-10600.001.patch
          5 kB
          Yiqun Lin

        Issue Links

          Activity

            People

              linyiqun Yiqun Lin
              eddyxu Lei (Eddy) Xu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: