[HDFS-10594] HDFS-4949 should support recursive cache directives

• Type: Improvement
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.7.1
• Component/s: caching
• Assignee: Yiqun Lin
• Reporter: Yiqun Lin
• Created: 05/Jul/16 13:27
• Updated: 13/Jul/16 00:34

Description

In CacheReplicationMonitor#rescanCacheDirectives, it should recursively rescan the path when the inode of the path is a directory. In these code:

} else if (node.isDirectory()) {
        INodeDirectory dir = node.asDirectory();
        ReadOnlyList<INode> children = dir
            .getChildrenList(Snapshot.CURRENT_STATE_ID);
        for (INode child : children) {
          if (child.isFile()) {
            rescanFile(directive, child.asFile());
          }
        }
       }

If we did the this logic, it means that some inode files will be ignored when the child inode is also a directory and there are some other child inode file in it. Finally the child's child file which belong to this path will not be cached.