Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10581

Hide redundant table on NameNode WebUI when no nodes are decomissioning

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: hdfs, ui
    • Labels:
    • Target Version/s:

      Description

      A minor user experience Improvement on namenode UI. Propose to improve it from before.jpg to after.jpg.

      1. after.2.jpg
        62 kB
        Weiwei Yang
      2. after.jpg
        45 kB
        Weiwei Yang
      3. before.jpg
        52 kB
        Weiwei Yang
      4. HDFS-10581.001.patch
        0.6 kB
        Weiwei Yang
      5. HDFS-10581.002.patch
        0.6 kB
        Weiwei Yang
      6. HDFS-10581.03.patch
        0.6 kB
        Weiwei Yang

        Activity

        Hide
        cheersyang Weiwei Yang added a comment -

        A trivial patch uploaded.

        Show
        cheersyang Weiwei Yang added a comment - A trivial patch uploaded.
        Hide
        shahrs87 Rushabh S Shah added a comment -

        In the after case, do we even need the Decommissioning header also ?

        Show
        shahrs87 Rushabh S Shah added a comment - In the after case, do we even need the Decommissioning header also ?
        Hide
        cheersyang Weiwei Yang added a comment -

        Hello Rushabh Shah

        Yeah, we can remove the header in this case also, that will give a more nice and clean page. I'll revise the patch to do so. Thanks for your comment.

        Show
        cheersyang Weiwei Yang added a comment - Hello Rushabh Shah Yeah, we can remove the header in this case also, that will give a more nice and clean page. I'll revise the patch to do so. Thanks for your comment.
        Hide
        cheersyang Weiwei Yang added a comment -

        Uploaded v2 patch according to Rushabh Shah's comment.

        Show
        cheersyang Weiwei Yang added a comment - Uploaded v2 patch according to Rushabh Shah 's comment.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 40s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        1m 26s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814012/HDFS-10581.002.patch
        JIRA Issue HDFS-10581
        Optional Tests asflicense
        uname Linux aa0405f07ddb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7d20704
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15926/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 40s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 1m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814012/HDFS-10581.002.patch JIRA Issue HDFS-10581 Optional Tests asflicense uname Linux aa0405f07ddb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7d20704 modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15926/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cheersyang Weiwei Yang added a comment - - edited

        This is a pretty simple patch, can somebody help to review ? Attached the screen shot after this patch is applied. See after.2.jpg

        Show
        cheersyang Weiwei Yang added a comment - - edited This is a pretty simple patch, can somebody help to review ? Attached the screen shot after this patch is applied. See after.2.jpg
        Hide
        djp Junping Du added a comment -

        Remove elements in UI is not a trivial thing, especially some UI test could check things for consistent user experience across release to release. Comparing with confusion from people, redundant is less guilty.
        What other HDFS guys think? CCJing Zhao, Arpit Agarwal and Andrew Wang.

        Show
        djp Junping Du added a comment - Remove elements in UI is not a trivial thing, especially some UI test could check things for consistent user experience across release to release. Comparing with confusion from people, redundant is less guilty. What other HDFS guys think? CC Jing Zhao , Arpit Agarwal and Andrew Wang .
        Hide
        cheersyang Weiwei Yang added a comment -

        Hello Junping Du and folks on CC

        Thanks for looking at this one. I thought this is a minor change to improve user experience and won't cause any problem. Please let me know your concern and problems it would make.

        Thank You.

        Show
        cheersyang Weiwei Yang added a comment - Hello Junping Du and folks on CC Thanks for looking at this one. I thought this is a minor change to improve user experience and won't cause any problem. Please let me know your concern and problems it would make. Thank You.
        Hide
        andrew.wang Andrew Wang added a comment -

        Seems like a nice change, thanks for working on this Weiwei Yang!

        Re Junping's question, the webui is explicitly excluded by our compatibility guidelines, so this is okay to do in branch-2.

        I'd actually prefer to keep the Decommissioning header, but can we get a better error message than "No data is available"? e.g. "No nodes are decommisioning"? Otherwise I'm +1.

        Show
        andrew.wang Andrew Wang added a comment - Seems like a nice change, thanks for working on this Weiwei Yang! Re Junping's question, the webui is explicitly excluded by our compatibility guidelines, so this is okay to do in branch-2. I'd actually prefer to keep the Decommissioning header, but can we get a better error message than "No data is available"? e.g. "No nodes are decommisioning"? Otherwise I'm +1.
        Hide
        cheersyang Weiwei Yang added a comment - - edited

        According to Andrew Wang's comment, retain the header and displays message "No nodes are decommissioning". Thanks.

        Show
        cheersyang Weiwei Yang added a comment - - edited According to Andrew Wang 's comment, retain the header and displays message "No nodes are decommissioning". Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        0m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-10581
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841871/HDFS-10581.03.patch
        Optional Tests asflicense
        uname Linux 426bf6ed9392 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a2b5d60
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17767/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 0m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10581 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841871/HDFS-10581.03.patch Optional Tests asflicense uname Linux 426bf6ed9392 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a2b5d60 modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17767/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk, branch-2, branch-2.8. Thanks for the contribution Weiwei Yang!

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk, branch-2, branch-2.8. Thanks for the contribution Weiwei Yang!
        Hide
        cheersyang Weiwei Yang added a comment -

        My pleasure, thank you Andrew Wang .

        Show
        cheersyang Weiwei Yang added a comment - My pleasure, thank you Andrew Wang .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10944 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10944/)
        HDFS-10581. Hide redundant table on NameNode WebUI when no nodes are (wang: rev 8e63fa98eabac55bdb2254306584ad1e759c79eb)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10944 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10944/ ) HDFS-10581 . Hide redundant table on NameNode WebUI when no nodes are (wang: rev 8e63fa98eabac55bdb2254306584ad1e759c79eb) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
        Hide
        djp Junping Du added a comment -

        The latest patch indeed becomes a trivial fix which looks good to me.
        Per Andrew's response above, I am not saying compatibility for UI element, but rather a stable issue as a mature product. Like 02 patch's work, people/admin could get confused where is page for checking decommissioning node after upgrade which probably even worse than previous redundancy. My 2 cents is user experience is not only a static picture but also a historic view. Thoughts?

        Show
        djp Junping Du added a comment - The latest patch indeed becomes a trivial fix which looks good to me. Per Andrew's response above, I am not saying compatibility for UI element, but rather a stable issue as a mature product. Like 02 patch's work, people/admin could get confused where is page for checking decommissioning node after upgrade which probably even worse than previous redundancy. My 2 cents is user experience is not only a static picture but also a historic view. Thoughts?
        Hide
        cheersyang Weiwei Yang added a comment -

        Thanks Junping Du, that makes sense to me.

        Show
        cheersyang Weiwei Yang added a comment - Thanks Junping Du , that makes sense to me.

          People

          • Assignee:
            cheersyang Weiwei Yang
            Reporter:
            cheersyang Weiwei Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development