Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10568

Reuse ObjectMapper instance in CombinedHostsFileReader and CombinedHostsFileWriter

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The ObjectMapper instance is not reused in class CombinedHostsFileReader and CombinedHostsFileWriter. We can reuse them to improve performance.

      Here are related issues: HDFS-9724, HDFS-9768.

      1. HDFS-10568.001.patch
        3 kB
        Yiqun Lin
      2. HDFS-10568.002.patch
        3 kB
        Yiqun Lin

        Issue Links

          Activity

          Hide
          linyiqun Yiqun Lin added a comment -

          Attach a simple patch.

          Show
          linyiqun Yiqun Lin added a comment - Attach a simple patch.
          Hide
          linyiqun Yiqun Lin added a comment -

          It seemed the jenkins was hung, upload the patch file again to trigger the jenkins.

          Show
          linyiqun Yiqun Lin added a comment - It seemed the jenkins was hung, upload the patch file again to trigger the jenkins.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Yiqun Lin for reporting this and creating the patch.

                    READER.readValues(new JsonFactory().createJsonParser(input));
          

          Can we reuse JsonFactory as well?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Yiqun Lin for reporting this and creating the patch. READER.readValues( new JsonFactory().createJsonParser(input)); Can we reuse JsonFactory as well?
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Akira Ajisaka for review. Post the new patch for addressing the comments, pending jenkins.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for review. Post the new patch for addressing the comments, pending jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 18s trunk passed
          +1 compile 0m 31s trunk passed
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 30s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 28s the patch passed
          +1 javac 0m 28s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 32s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 35s the patch passed
          +1 javadoc 0m 17s the patch passed
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          18m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:85209cc
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814021/HDFS-10568.002.patch
          JIRA Issue HDFS-10568
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 27fc044cb388 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4fd37ee
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15928/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15928/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 18s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 35s the patch passed +1 javadoc 0m 17s the patch passed +1 unit 0m 55s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 18m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814021/HDFS-10568.002.patch JIRA Issue HDFS-10568 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 27fc044cb388 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4fd37ee Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15928/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15928/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Yiqun Lin for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Yiqun Lin for the contribution.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Akira Ajisaka for commit!

          Show
          linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for commit!
          Hide
          andrew.wang Andrew Wang added a comment -

          For future git log greppers, this was typo'd as HADOOP-10568 in the commit message.

          Show
          andrew.wang Andrew Wang added a comment - For future git log greppers, this was typo'd as HADOOP-10568 in the commit message.

            People

            • Assignee:
              linyiqun Yiqun Lin
              Reporter:
              linyiqun Yiqun Lin
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development