Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10556

DistCpOptions should be validated automatically

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.8.0
    • 2.8.0
    • distcp
    • None
    • Reviewed

    Description

      DistCpOptions can be set from command-line or may be set manually. In HDFS-10397, we refactored the validation to make it simpler and more efficient. However, the newly added validate() method may not be automatically revoked. This is the major concern for existing downstreams that create the DistCpOptions manually instead of by parser, and have conflicting options.

      This jira is to make the validation happen automatically. A simple fix is to use the approach that validates in individual setters. This is a fix for branch-2. As a long-term fix, in HDFS-10533, we're making the DistCpOptions immutable so that it will be hard, if not impossible, to use it wrongly by downstream applications. However, that code will only go to trunk branch as it breaks backwards-compatibility.

      Attachments

        1. HDFS-10556-branch-2.000.patch
          25 kB
          Mingliang Liu
        2. HDFS-10556-branch-2.001.patch
          28 kB
          Mingliang Liu

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            liuml07 Mingliang Liu
            liuml07 Mingliang Liu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment