[HDFS-10551] o.a.h.h.s.diskbalancer.command.Command does not actually verify options as expected.

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Anu Engineer
• Reporter: Lei (Eddy) Xu
• Created: 20/Jun/16 21:35
• Updated: 24/Jun/16 06:19
• Resolved: 23/Jun/16 00:32

Description

In diskbalancer.command.Command#verifyCommandOptions. The following code does not do what it expected to do:

if (!validArgs.containsKey(opt.getArgName())) {

opt.getArgName() always returns "arg" instead of i.e., report or uri, which is the expected parameter to check.

It should use opt.getLongOpt() to get the option names. It can pass on the branch because opt.getArgName() always returns "arg", which is accidently in validArgs. However I don't think it is the intention for this function.

Additionally, in the following code

validArguments.append("Valid arguments are : %n");

This %n is not used.