Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10516

Fix bug when warming up EDEK cache of more than one encryption zone

    Details

    • Target Version/s:

      Description

      Had a typo in HDFS-9405, causing more than 1 edek warm up to fail.

        Issue Links

          Activity

          Hide
          xiaochen Xiao Chen added a comment -

          Typo is no ++ in the for loop. The NPE got threw out and appears in stderr, but that's not the easiest way to figure out, so added a log. Updated test case to fail-before-pass-after.

          Andrew Wang, I'm really sorry for having this bug from HDFS-9405. Could you please take a look? Thanks again.

          Show
          xiaochen Xiao Chen added a comment - Typo is no ++ in the for loop. The NPE got threw out and appears in stderr, but that's not the easiest way to figure out, so added a log. Updated test case to fail-before-pass-after. Andrew Wang , I'm really sorry for having this bug from HDFS-9405 . Could you please take a look? Thanks again.
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM +1 pending Jenkins, nice find Xiao. My bad for not seeing this during review also.

          Show
          andrew.wang Andrew Wang added a comment - LGTM +1 pending Jenkins, nice find Xiao. My bad for not seeing this during review also.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 53s trunk passed
          +1 compile 0m 47s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 0m 56s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 46s the patch passed
          +1 javac 0m 46s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 51s the patch passed
          +1 javadoc 0m 53s the patch passed
          +1 unit 72m 30s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          92m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809577/HDFS-10516.01.patch
          JIRA Issue HDFS-10516
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux db82410e910f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8a1dcce
          Default Java 1.8.0_91
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15740/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15740/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15740/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 53s trunk passed +1 compile 0m 47s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 72m 30s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 92m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809577/HDFS-10516.01.patch JIRA Issue HDFS-10516 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux db82410e910f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a1dcce Default Java 1.8.0_91 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15740/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15740/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15740/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          The whitespace thing is due to the mechanism of HADOOP-12893, let me fix it in another jira.
          Thank you Andrew!

          Show
          xiaochen Xiao Chen added a comment - The whitespace thing is due to the mechanism of HADOOP-12893 , let me fix it in another jira. Thank you Andrew!
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for the find and fix Xiao, committed this back through branch-2.8.

          Show
          andrew.wang Andrew Wang added a comment - Thanks for the find and fix Xiao, committed this back through branch-2.8.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9954 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9954/)
          HDFS-10516. Fix bug when warming up EDEK cache of more than one (wang: rev 709a814fe0153e86a37806796ea27c8252d9c6d1)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithKMS.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9954 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9954/ ) HDFS-10516 . Fix bug when warming up EDEK cache of more than one (wang: rev 709a814fe0153e86a37806796ea27c8252d9c6d1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithKMS.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Andrew for the commit and correction on the summary!

          Show
          xiaochen Xiao Chen added a comment - Thanks Andrew for the commit and correction on the summary!

            People

            • Assignee:
              xiaochen Xiao Chen
              Reporter:
              xiaochen Xiao Chen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development