Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: namenode, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Per https://builds.apache.org/job/PreCommit-HDFS-Build/15646/testReport/, we had the following failure. Local rerun is successful.

      Stack Trace:

      java.lang.AssertionError: expected:<17> but was:<0>
      at org.junit.Assert.fail(Assert.java:88)
      at org.junit.Assert.failNotEquals(Assert.java:743)
      at org.junit.Assert.assertEquals(Assert.java:118)
      at org.junit.Assert.assertEquals(Assert.java:555)
      at org.junit.Assert.assertEquals(Assert.java:542)
      at org.apache.hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency.testGenerationStampInFuture(TestNameNodeMetadataConsistency.java:113)

      1. HDFS-10499.001.patch
        2 kB
        Yiqun Lin
      2. HDFS-10499.002.patch
        4 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Hi Anu Engineer, I am ready to work on this. I have looked into this, I think one reason is that sometimes the block report haven't been reported to namenode and then the value BytesWithFutureGenerationStamps of future block will be 0. The line waitTil(TimeUnit.SECONDS.toMillis(SCAN_WAIT)); can't gurantee that. Let me know if you are also working on this, Thanks!

        Show
        linyiqun Yiqun Lin added a comment - Hi Anu Engineer , I am ready to work on this. I have looked into this, I think one reason is that sometimes the block report haven't been reported to namenode and then the value BytesWithFutureGenerationStamps of future block will be 0. The line waitTil(TimeUnit.SECONDS.toMillis(SCAN_WAIT)); can't gurantee that. Let me know if you are also working on this, Thanks!
        Hide
        anu Anu Engineer added a comment -

        No I am not, please go ahead and assign this to yourself. Thanks for volunteering to fix this.

        Show
        anu Anu Engineer added a comment - No I am not, please go ahead and assign this to yourself. Thanks for volunteering to fix this.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Anu Engineer. Attach a initial patch for this.

        This test has been fails intermittently for a long time. Hi Brahma Reddy Battula, could you please have a quick look for this? Thanks!

        Show
        linyiqun Yiqun Lin added a comment - Thanks Anu Engineer . Attach a initial patch for this. This test has been fails intermittently for a long time. Hi Brahma Reddy Battula , could you please have a quick look for this? Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 30s trunk passed
        +1 compile 0m 52s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 2m 9s trunk passed
        +1 javadoc 0m 42s trunk passed
        -1 mvninstall 0m 53s hadoop-hdfs in the patch failed.
        -1 compile 0m 58s hadoop-hdfs in the patch failed.
        -1 javac 0m 58s hadoop-hdfs in the patch failed.
        +1 checkstyle 0m 31s the patch passed
        -1 mvnsite 0m 54s hadoop-hdfs in the patch failed.
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 20s hadoop-hdfs in the patch failed.
        +1 javadoc 0m 46s the patch passed
        -1 unit 0m 51s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        21m 21s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10499
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836261/HDFS-10499.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 39cb81c1828c 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7ba74be
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17362/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17362/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 30s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 9s trunk passed +1 javadoc 0m 42s trunk passed -1 mvninstall 0m 53s hadoop-hdfs in the patch failed. -1 compile 0m 58s hadoop-hdfs in the patch failed. -1 javac 0m 58s hadoop-hdfs in the patch failed. +1 checkstyle 0m 31s the patch passed -1 mvnsite 0m 54s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 20s hadoop-hdfs in the patch failed. +1 javadoc 0m 46s the patch passed -1 unit 0m 51s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 21m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10499 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836261/HDFS-10499.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 39cb81c1828c 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7ba74be Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17362/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17362/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17362/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 32s trunk passed
        +1 compile 0m 47s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 1m 3s the patch passed
        +1 compile 0m 58s the patch passed
        +1 javac 0m 58s the patch passed
        +1 checkstyle 0m 29s the patch passed
        +1 mvnsite 1m 4s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 3s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 73m 48s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        94m 48s



        Reason Tests
        Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10499
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836263/HDFS-10499.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6cf5146f4311 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7ba74be
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17363/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17363/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17363/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 32s trunk passed +1 compile 0m 47s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 1m 3s the patch passed +1 compile 0m 58s the patch passed +1 javac 0m 58s the patch passed +1 checkstyle 0m 29s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 3s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 73m 48s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 94m 48s Reason Tests Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10499 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836263/HDFS-10499.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6cf5146f4311 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7ba74be Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17363/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17363/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17363/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yiqun Lin thanks for working on this.

        you can remove the following and replace with GenericTestUtils.waitFor all the places.?

        private void waitTil(long waitPeriod) {
            try {
              Thread.sleep(waitPeriod);
            } catch (InterruptedException e) {
              e.printStackTrace();
            }
          }
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for working on this. you can remove the following and replace with GenericTestUtils.waitFor all the places.? private void waitTil( long waitPeriod) { try { Thread .sleep(waitPeriod); } catch (InterruptedException e) { e.printStackTrace(); } }
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Brahma Reddy Battula for the quick review, good proposal! Attach a new patch to address the comment.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Brahma Reddy Battula for the quick review, good proposal! Attach a new patch to address the comment.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 1s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 48s trunk passed
        +1 compile 1m 0s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 2m 4s trunk passed
        +1 javadoc 0m 46s trunk passed
        +1 mvninstall 0m 54s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 16s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 56m 11s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        79m 9s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10499
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836295/HDFS-10499.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 78bdff27168b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7ba74be
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17366/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17366/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 48s trunk passed +1 compile 1m 0s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 54s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 16s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 56m 11s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 79m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10499 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836295/HDFS-10499.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 78bdff27168b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7ba74be Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17366/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17366/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yiqun Lin thanks for updating the patch.. Latest patch, LGTM,+1... Will commit.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for updating the patch.. Latest patch, LGTM,+1... Will commit.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,Yiqun Lin thanks for contribution and Hanisha Koneru thanks for your contribution.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk, Yiqun Lin thanks for contribution and Hanisha Koneru thanks for your contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10744 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10744/)
        HDFS-10499. TestNameNodeMetadataConsistency#testGenerationStampInFuture (brahma: rev 808f5d8985323bc1afa79a1c5d24b229f535ec3b)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMetadataConsistency.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10744 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10744/ ) HDFS-10499 . TestNameNodeMetadataConsistency#testGenerationStampInFuture (brahma: rev 808f5d8985323bc1afa79a1c5d24b229f535ec3b) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMetadataConsistency.java
        Hide
        linyiqun Yiqun Lin added a comment -
        Show
        linyiqun Yiqun Lin added a comment - Thanks Brahma Reddy Battula .

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            hanishakoneru Hanisha Koneru
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development