Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Found 1 findbugs warning when creating a patch for branch-2 in HDFS-10341 (https://builds.apache.org/job/PreCommit-HDFS-Build/15639/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html)

      Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.FSEditLog.numTransactionsBatchedInSync; locked 50% of time
      Bug type IS2_INCONSISTENT_SYNC (click for details) 
      In class org.apache.hadoop.hdfs.server.namenode.FSEditLog
      Field org.apache.hadoop.hdfs.server.namenode.FSEditLog.numTransactionsBatchedInSync
      Synchronized 50% of the time
      Unsynchronized access at FSEditLog.java:[line 676]
      Unsynchronized access at FSEditLog.java:[line 676]
      Synchronized access at FSEditLog.java:[line 1254]
      Synchronized access at FSEditLog.java:[line 716]
      
      1. HDFS-10485.01.branch-2.patch
        2 kB
        Akira Ajisaka
      2. HDFS-10485.01.patch
        2 kB
        Akira Ajisaka
      3. HDFS-10485.02.branch-2.patch
        2 kB
        Akira Ajisaka
      4. HDFS-10485.03.branch-2.patch
        2 kB
        Akira Ajisaka

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'm thinking numTransactionBatchedInSync should be AtomicLong or LongAdder instead of long. We can use AtomicLong because we support JDK7 in branch-2.

        Show
        ajisakaa Akira Ajisaka added a comment - I'm thinking numTransactionBatchedInSync should be AtomicLong or LongAdder instead of long. We can use AtomicLong because we support JDK7 in branch-2.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Attaching a patch to use AtomicLong for numTransactionBatchedInSync instead of long. This patch applies to trunk as well.

        Show
        ajisakaa Akira Ajisaka added a comment - Attaching a patch to use AtomicLong for numTransactionBatchedInSync instead of long. This patch applies to trunk as well.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 7m 1s Docker failed to build yetus/hadoop:babe025.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808013/HDFS-10485.01.branch-2.patch
        JIRA Issue HDFS-10485
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15642/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 7m 1s Docker failed to build yetus/hadoop:babe025. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808013/HDFS-10485.01.branch-2.patch JIRA Issue HDFS-10485 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15642/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 7m 43s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 17s branch-2 passed
        +1 compile 0m 37s branch-2 passed with JDK v1.8.0_91
        +1 compile 0m 41s branch-2 passed with JDK v1.7.0_101
        +1 checkstyle 0m 28s branch-2 passed
        +1 mvnsite 0m 50s branch-2 passed
        +1 mvneclipse 0m 13s branch-2 passed
        -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 1m 2s branch-2 passed with JDK v1.8.0_91
        +1 javadoc 1m 46s branch-2 passed with JDK v1.7.0_101
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_91
        +1 javac 0m 35s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.7.0_101
        +1 javac 0m 38s the patch passed
        -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 127 unchanged - 2 fixed = 128 total (was 129)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 6s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 43s the patch passed with JDK v1.7.0_101
        -1 unit 60m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        +1 unit 66m 23s hadoop-hdfs in the patch passed with JDK v1.7.0_101.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        158m 50s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.TestDecommission



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:babe025
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808013/HDFS-10485.01.branch-2.patch
        JIRA Issue HDFS-10485
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bbf6aec2c147 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 043a0c2
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15643/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15643/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 7m 43s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 17s branch-2 passed +1 compile 0m 37s branch-2 passed with JDK v1.8.0_91 +1 compile 0m 41s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 0m 50s branch-2 passed +1 mvneclipse 0m 13s branch-2 passed -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 2s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 46s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 44s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_91 +1 javac 0m 35s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_101 +1 javac 0m 38s the patch passed -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 127 unchanged - 2 fixed = 128 total (was 129) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_101 -1 unit 60m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 66m 23s hadoop-hdfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 158m 50s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestDecommission Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808013/HDFS-10485.01.branch-2.patch JIRA Issue HDFS-10485 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bbf6aec2c147 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 043a0c2 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15643/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15643/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15643/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        02 patch:

        • fixes checkstyle warning
        Show
        ajisakaa Akira Ajisaka added a comment - 02 patch: fixes checkstyle warning
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 24s branch-2 passed
        +1 compile 0m 37s branch-2 passed with JDK v1.8.0_91
        +1 compile 0m 40s branch-2 passed with JDK v1.7.0_101
        +1 checkstyle 0m 28s branch-2 passed
        +1 mvnsite 0m 50s branch-2 passed
        +1 mvneclipse 0m 14s branch-2 passed
        -1 findbugs 1m 55s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 1m 5s branch-2 passed with JDK v1.8.0_91
        +1 javadoc 1m 42s branch-2 passed with JDK v1.7.0_101
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 34s the patch passed with JDK v1.8.0_91
        +1 javac 0m 34s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_101
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 127 unchanged - 2 fixed = 127 total (was 129)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 6s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
        +1 javadoc 1m 7s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 43s the patch passed with JDK v1.7.0_101
        -1 unit 53m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 48m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        138m 47s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestAsyncHDFSWithHA
        JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:babe025
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808044/HDFS-10485.02.branch-2.patch
        JIRA Issue HDFS-10485
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6213ffa5d2b9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 7f865bf
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15647/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15647/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 24s branch-2 passed +1 compile 0m 37s branch-2 passed with JDK v1.8.0_91 +1 compile 0m 40s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 0m 50s branch-2 passed +1 mvneclipse 0m 14s branch-2 passed -1 findbugs 1m 55s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 5s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 42s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 45s the patch passed +1 compile 0m 34s the patch passed with JDK v1.8.0_91 +1 javac 0m 34s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_101 +1 javac 0m 40s the patch passed +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 127 unchanged - 2 fixed = 127 total (was 129) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 1m 7s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_101 -1 unit 53m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 48m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 138m 47s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestAsyncHDFSWithHA JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808044/HDFS-10485.02.branch-2.patch JIRA Issue HDFS-10485 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6213ffa5d2b9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 7f865bf Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15647/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15647/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thank you Akira Ajisaka for the v02 patch. Can you explain why this has been removed?

        676	        numTransactionsBatchedInSync += editsBatchedInSync;
        

        It seems numTransactionsBatchedInSync is set to meaningful value nowhere.

        And also, this issue has no cause and effect relation to HDFS-10341, am I right? Thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thank you Akira Ajisaka for the v02 patch. Can you explain why this has been removed? 676 numTransactionsBatchedInSync += editsBatchedInSync; It seems numTransactionsBatchedInSync is set to meaningful value nowhere. And also, this issue has no cause and effect relation to HDFS-10341 , am I right? Thanks.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Xiaobing Zhou for the review comment.

        Can you explain why this has been removed?

        My bad, fixed in 03 patch.

        And also, this issue has no cause and effect relation to HDFS-10341, am I right?

        Yes, you are right. In this jira, precommit jenkins job ran on branch-2 and found that branch-2 is already broken.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Xiaobing Zhou for the review comment. Can you explain why this has been removed? My bad, fixed in 03 patch. And also, this issue has no cause and effect relation to HDFS-10341 , am I right? Yes, you are right. In this jira, precommit jenkins job ran on branch-2 and found that branch-2 is already broken.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thank you for update. The new patch looks good to me. +1 pending Jenkins.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thank you for update. The new patch looks good to me. +1 pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 17s branch-2 passed
        +1 compile 0m 37s branch-2 passed with JDK v1.8.0_91
        +1 compile 0m 40s branch-2 passed with JDK v1.7.0_101
        +1 checkstyle 0m 27s branch-2 passed
        +1 mvnsite 0m 50s branch-2 passed
        +1 mvneclipse 0m 14s branch-2 passed
        -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 1m 1s branch-2 passed with JDK v1.8.0_91
        +1 javadoc 1m 44s branch-2 passed with JDK v1.7.0_101
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_91
        +1 javac 0m 35s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_101
        +1 javac 0m 39s the patch passed
        +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 127 unchanged - 2 fixed = 127 total (was 129)
        +1 mvnsite 0m 46s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 4s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 41s the patch passed with JDK v1.7.0_101
        -1 unit 64m 56s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 69m 10s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        158m 54s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestFSImageWithAcl
          hadoop.hdfs.server.datanode.TestLargeBlockReport
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.datanode.TestDataNodeMXBean
          hadoop.hdfs.qjournal.client.TestQuorumJournalManager
        JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
        JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:babe025
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808115/HDFS-10485.03.branch-2.patch
        JIRA Issue HDFS-10485
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 78398e55abee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / c11c2ee
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15654/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15654/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 17s branch-2 passed +1 compile 0m 37s branch-2 passed with JDK v1.8.0_91 +1 compile 0m 40s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 27s branch-2 passed +1 mvnsite 0m 50s branch-2 passed +1 mvneclipse 0m 14s branch-2 passed -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 1s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 44s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 45s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_91 +1 javac 0m 35s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_101 +1 javac 0m 39s the patch passed +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 127 unchanged - 2 fixed = 127 total (was 129) +1 mvnsite 0m 46s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 4s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 41s the patch passed with JDK v1.7.0_101 -1 unit 64m 56s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 69m 10s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 158m 54s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestFSImageWithAcl   hadoop.hdfs.server.datanode.TestLargeBlockReport   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.datanode.TestDataNodeMXBean   hadoop.hdfs.qjournal.client.TestQuorumJournalManager JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808115/HDFS-10485.03.branch-2.patch JIRA Issue HDFS-10485 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 78398e55abee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c11c2ee Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15654/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15654/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 thanks Akira Ajisaka.

        If the patch applies to trunk we should just commit it to trunk and branch-2. I am changing the jira title, feel free to change it back if this is not applicable to trunk.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 thanks Akira Ajisaka . If the patch applies to trunk we should just commit it to trunk and branch-2. I am changing the jira title, feel free to change it back if this is not applicable to trunk.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        If the patch applies to trunk we should just commit it to trunk and branch-2.

        Agreed. The patch applies to trunk cleanly.

        Show
        ajisakaa Akira Ajisaka added a comment - If the patch applies to trunk we should just commit it to trunk and branch-2. Agreed. The patch applies to trunk cleanly.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Attaching the same patch to run precommit job on trunk.

        Show
        ajisakaa Akira Ajisaka added a comment - Attaching the same patch to run precommit job on trunk.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 54s trunk passed
        +1 compile 0m 42s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 39s trunk passed
        +1 javadoc 1m 4s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 41s the patch passed
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 127 unchanged - 2 fixed = 127 total (was 129)
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 1m 2s the patch passed
        -1 unit 69m 35s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        88m 47s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestAsyncHDFSWithHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808525/HDFS-10485.01.patch
        JIRA Issue HDFS-10485
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 17612163806b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6de9213
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15673/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15673/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 54s trunk passed +1 compile 0m 42s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 1m 4s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 127 unchanged - 2 fixed = 127 total (was 129) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 1m 2s the patch passed -1 unit 69m 35s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 88m 47s Reason Tests Failed junit tests hadoop.hdfs.TestAsyncHDFSWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808525/HDFS-10485.01.patch JIRA Issue HDFS-10485 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 17612163806b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6de9213 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15673/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15673/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        The test failure looks unrelated to the patch. Committing this.

        Show
        ajisakaa Akira Ajisaka added a comment - The test failure looks unrelated to the patch. Committing this.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Xiaobing Zhou and Arpit Agarwal for reviewing this!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Xiaobing Zhou and Arpit Agarwal for reviewing this!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9920 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9920/)
        HDFS-10485. Fix findbugs warning in FSEditLog.java. (aajisaka) (aajisaka: rev e620530301fd3e62537d4b7bc3d8ed296bda1ffc)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9920 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9920/ ) HDFS-10485 . Fix findbugs warning in FSEditLog.java. (aajisaka) (aajisaka: rev e620530301fd3e62537d4b7bc3d8ed296bda1ffc) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the work Akira. I just backported to branch-2.8

        Show
        zhz Zhe Zhang added a comment - Thanks for the work Akira. I just backported to branch-2.8

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development