[HDFS-10463] TestRollingFileSystemSinkWithHdfs needs some cleanup

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.9.0
• Fix Version/s: 2.9.0, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: Daniel Templeton
• Reporter: Daniel Templeton
• Created: 25/May/16 21:09
• Updated: 30/Aug/16 01:15
• Resolved: 26/May/16 21:39

Description

There are three primary issues. The most significant is that the testFlushThread() method doesn't clean up after itself, which can cause other tests to fail. The other big issue is that the testSilentAppend() method is testing the wrong thing. An additional minor issue is that none of the tests are careful about making sure the metrics system gets shutdown in all cases.