Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10458

getFileEncryptionInfo should return quickly for non-encrypted cluster

    Details

      Description

      FSDirectory#getFileEncryptionInfo always acquires readLock and checks if the path belongs to an EZ. For a busy system with potentially many listing operations, this could cause locking contention.

      I think we should add a call EncryptionZoneManager#hasEncryptionZone() to return whether the system has any EZ. If no EZ at all, getFileEncryptionInfo should return null without readLock.

      If hasEncryptionZone is only used in the above scenario, maybe itself doesn't need a readLock – if the system doesn't have any EZ when getFileEncryptionInfo is called on a path, it means the path cannot be encrypted.

      1. HDFSA-10458.02.patch
        3 kB
        Zhe Zhang
      2. HDFSA-10458.01.patch
        3 kB
        Zhe Zhang
      3. HDFS-10458-branch-2.7.00.patch
        5 kB
        Zhe Zhang
      4. HDFS-10458-branch-2.6.01.patch
        4 kB
        Zhe Zhang
      5. HDFS-10458-branch-2.6.00.patch
        4 kB
        Zhe Zhang
      6. HDFS-10458-branch-2.00.patch
        5 kB
        Zhe Zhang
      7. HDFS-10458.05.patch
        5 kB
        Zhe Zhang
      8. HDFS-10458.04.patch
        5 kB
        Zhe Zhang
      9. HDFS-10458.03.patch
        5 kB
        Zhe Zhang
      10. HDFS-10458.00.patch
        0.9 kB
        Zhe Zhang

        Activity

        Hide
        zhz Zhe Zhang added a comment -

        trunk already has a method to get number of EZs without locking. Attaching initial version of patch.

        Show
        zhz Zhe Zhang added a comment - trunk already has a method to get number of EZs without locking. Attaching initial version of patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 5s trunk passed
        +1 compile 0m 51s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 51s trunk passed
        +1 javadoc 1m 13s trunk passed
        +1 mvninstall 0m 58s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 1m 11s the patch passed
        -1 unit 79m 57s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        101m 10s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806138/HDFS-10458.00.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 66a6ff51d4fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9a31e5d
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15561/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15561/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15561/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15561/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 5s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 1m 13s trunk passed +1 mvninstall 0m 58s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 1m 11s the patch passed -1 unit 79m 57s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 101m 10s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806138/HDFS-10458.00.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 66a6ff51d4fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9a31e5d Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15561/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15561/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15561/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15561/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        shv Konstantin Shvachko added a comment -

        The patch looks good.
        I would add a similar condition for empty encryptionZones at the start of EncryptionZoneManager.getEncryptionZoneForPath(). This method is used many times both for write operations, like startFile() and for reads, like getFileInfo(). Even though this will still be under the lock, but returning and releasing the lock quickly should be beneficial.

        Show
        shv Konstantin Shvachko added a comment - The patch looks good. I would add a similar condition for empty encryptionZones at the start of EncryptionZoneManager.getEncryptionZoneForPath() . This method is used many times both for write operations, like startFile() and for reads, like getFileInfo() . Even though this will still be under the lock, but returning and releasing the lock quickly should be beneficial.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Konstantin Shvachko for the review. Attaching new patch to take the suggestion. I think it is a good idea to add the check in getEncryptionZoneForPath.

        However, for uses in startFile etc., we should be more careful about race conditions. Therefore I added a boolean variable that can only be turned on once (can never be turned off). It is turned on before adding any encryption zone so it is safe to assume no EZ exists if the variable is false.

        Show
        zhz Zhe Zhang added a comment - Thanks Konstantin Shvachko for the review. Attaching new patch to take the suggestion. I think it is a good idea to add the check in getEncryptionZoneForPath . However, for uses in startFile etc., we should be more careful about race conditions. Therefore I added a boolean variable that can only be turned on once (can never be turned off). It is turned on before adding any encryption zone so it is safe to assume no EZ exists if the variable is false.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 18s trunk passed
        +1 compile 0m 43s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 49s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 1m 39s trunk passed
        +1 javadoc 1m 4s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 41s the patch passed
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 43s the patch passed
        +1 javadoc 1m 2s the patch passed
        -1 unit 57m 38s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        75m 59s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestAclsEndToEnd
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.TestReservedRawPaths
          hadoop.hdfs.TestEncryptionZonesWithHA
          hadoop.hdfs.server.namenode.TestNestedEncryptionZones
          hadoop.cli.TestCryptoAdminCLI
          hadoop.hdfs.TestEncryptionZonesWithKMS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807467/HDFSA-10458.01.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3c204cb6dc26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5870611
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15623/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15623/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15623/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15623/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 18s trunk passed +1 compile 0m 43s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 1m 4s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 43s the patch passed +1 javadoc 1m 2s the patch passed -1 unit 57m 38s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 75m 59s Reason Tests Failed junit tests hadoop.hdfs.TestAclsEndToEnd   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestReservedRawPaths   hadoop.hdfs.TestEncryptionZonesWithHA   hadoop.hdfs.server.namenode.TestNestedEncryptionZones   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.TestEncryptionZonesWithKMS Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807467/HDFSA-10458.01.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3c204cb6dc26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5870611 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15623/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15623/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15623/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15623/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Oops missed a ! in if condition.

        Show
        zhz Zhe Zhang added a comment - Oops missed a ! in if condition.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 19s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 52s trunk passed
        +1 javadoc 1m 15s trunk passed
        +1 mvninstall 1m 6s the patch passed
        +1 compile 1m 0s the patch passed
        +1 javac 1m 0s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 53s the patch passed
        +1 javadoc 1m 12s the patch passed
        +1 unit 68m 43s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        89m 6s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807494/HDFSA-10458.02.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 77af916c487d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5870611
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15625/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15625/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 19s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 1m 15s trunk passed +1 mvninstall 1m 6s the patch passed +1 compile 1m 0s the patch passed +1 javac 1m 0s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 1m 12s the patch passed +1 unit 68m 43s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 89m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807494/HDFSA-10458.02.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 77af916c487d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5870611 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15625/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15625/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        shv Konstantin Shvachko added a comment -

        I agree we should not optimize when encryption zones are actually used.
        Can we just set encryptionZones = null in the constructor, which would mean that there are no encryption zones yet, and initialize it when the first zone is added. That way we can avoid adding extra field.

        Show
        shv Konstantin Shvachko added a comment - I agree we should not optimize when encryption zones are actually used. Can we just set encryptionZones = null in the constructor, which would mean that there are no encryption zones yet, and initialize it when the first zone is added. That way we can avoid adding extra field.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the comment Konstantin Shvachko. I started updating the patch using encryptionZones == null as condition check, but found that we would have to update all references to encryptionZones with null-handling logic. E.g., in listEncryptionZones and createEncryptionZone, would need to handle null value. It's probably not worth that much code change to avoid adding a field. But LMK your thoughts.

        Show
        zhz Zhe Zhang added a comment - Thanks for the comment Konstantin Shvachko . I started updating the patch using encryptionZones == null as condition check, but found that we would have to update all references to encryptionZones with null-handling logic. E.g., in listEncryptionZones and createEncryptionZone , would need to handle null value. It's probably not worth that much code change to avoid adding a field. But LMK your thoughts.
        Hide
        shv Konstantin Shvachko added a comment -

        Right, will need to handle a few other cases.
        For listEncryptionZones() it should be also good, as it will avoid unnecessary object allocations and all the logic working with the empty array.
        We are saving on a new field and empty map object assigned to encryptionZones now even if encryption is not used, which is in most use cases afaik.

        Show
        shv Konstantin Shvachko added a comment - Right, will need to handle a few other cases. For listEncryptionZones() it should be also good, as it will avoid unnecessary object allocations and all the logic working with the empty array. We are saving on a new field and empty map object assigned to encryptionZones now even if encryption is not used, which is in most use cases afaik.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the suggestion Konstantin Shvachko. Attaching new patch.

        Right now we are passing a null to the constructor of BatchedListEntries. I think it has the logic of handling null.

        Show
        zhz Zhe Zhang added a comment - Thanks for the suggestion Konstantin Shvachko . Attaching new patch. Right now we are passing a null to the constructor of BatchedListEntries . I think it has the logic of handling null.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 11m 12s Docker failed to build yetus/hadoop:2c91fd8.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808073/HDFS-10458.03.patch
        JIRA Issue HDFS-10458
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15648/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 11m 12s Docker failed to build yetus/hadoop:2c91fd8. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808073/HDFS-10458.03.patch JIRA Issue HDFS-10458 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15648/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Not sure why Yetus failed to build. Attaching patch again.

        Show
        zhz Zhe Zhang added a comment - Not sure why Yetus failed to build. Attaching patch again.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 4s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 46s trunk passed
        +1 compile 0m 49s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 52s trunk passed
        +1 javadoc 1m 8s trunk passed
        +1 mvninstall 0m 56s the patch passed
        +1 compile 0m 49s the patch passed
        +1 javac 0m 49s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 1s the patch passed
        +1 javadoc 1m 6s the patch passed
        -1 unit 58m 58s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        91m 29s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestEncryptionZonesWithKMS
          hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
          hadoop.hdfs.TestEncryptionZones



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808076/HDFS-10458.04.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6d5e79c56d60 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 78b3a03
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15650/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15650/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 4s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 46s trunk passed +1 compile 0m 49s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 1m 8s trunk passed +1 mvninstall 0m 56s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 1m 6s the patch passed -1 unit 58m 58s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 91m 29s Reason Tests Failed junit tests hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics   hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808076/HDFS-10458.04.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6d5e79c56d60 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 78b3a03 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15650/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15650/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15650/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        shv Konstantin Shvachko added a comment -

        Looks like in the end you will need to pass an empty list into BatchedListEntries constructor.

        Show
        shv Konstantin Shvachko added a comment - Looks like in the end you will need to pass an empty list into BatchedListEntries constructor.
        Hide
        zhz Zhe Zhang added a comment -

        Updating patch to address unit test failures. Thanks Konstantin Shvachko for the review.

        Show
        zhz Zhe Zhang added a comment - Updating patch to address unit test failures. Thanks Konstantin Shvachko for the review.
        Hide
        shv Konstantin Shvachko added a comment -

        +1. Tests passed locally.

        Show
        shv Konstantin Shvachko added a comment - +1. Tests passed locally.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Konstantin Shvachko. Will commit to trunk ~ branch-2.6 after the latest Jenkins run.

        Show
        zhz Zhe Zhang added a comment - Thanks Konstantin Shvachko . Will commit to trunk ~ branch-2.6 after the latest Jenkins run.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 28s trunk passed
        +1 compile 0m 47s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 38s trunk passed
        +1 javadoc 1m 12s trunk passed
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        -1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 53s the patch passed
        +1 javadoc 1m 3s the patch passed
        -1 unit 75m 52s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        95m 22s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.TestAsyncHDFSWithHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808443/HDFS-10458.05.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 29ca33fd3663 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 35f255b
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15667/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15667/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15667/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15667/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15667/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 28s trunk passed +1 compile 0m 47s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 1m 12s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 1m 3s the patch passed -1 unit 75m 52s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 95m 22s Reason Tests Failed junit tests hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestAsyncHDFSWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808443/HDFS-10458.05.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 29ca33fd3663 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 35f255b Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15667/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15667/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15667/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15667/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15667/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Back porting to 2.7 not clean. Attaching patch to trigger Jenkins.

        Show
        zhz Zhe Zhang added a comment - Back porting to 2.7 not clean. Attaching patch to trigger Jenkins.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9916 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9916/)
        HDFS-10458. getFileEncryptionInfo should return quickly for (zhz: rev 6de9213df111a9a4ed875db995d67af72d08a798)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9916 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9916/ ) HDFS-10458 . getFileEncryptionInfo should return quickly for (zhz: rev 6de9213df111a9a4ed875db995d67af72d08a798) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 29s branch-2.7 passed
        +1 compile 1m 7s branch-2.7 passed with JDK v1.8.0_91
        +1 compile 1m 6s branch-2.7 passed with JDK v1.7.0_101
        +1 checkstyle 0m 28s branch-2.7 passed
        +1 mvnsite 1m 1s branch-2.7 passed
        +1 mvneclipse 0m 21s branch-2.7 passed
        +1 findbugs 3m 13s branch-2.7 passed
        +1 javadoc 1m 12s branch-2.7 passed with JDK v1.8.0_91
        +1 javadoc 1m 51s branch-2.7 passed with JDK v1.7.0_101
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 55s the patch passed with JDK v1.8.0_91
        +1 javac 0m 55s the patch passed
        +1 compile 1m 0s the patch passed with JDK v1.7.0_101
        +1 javac 1m 0s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 2630 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 1m 4s The patch 70 line(s) with tabs.
        +1 findbugs 3m 9s the patch passed
        +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 53s the patch passed with JDK v1.7.0_101
        -1 unit 55m 46s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 56m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 asflicense 0m 19s The patch generated 3 ASF License warnings.
        145m 44s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
        JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:c420dfe
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808501/HDFS-10458-branch-2.7.00.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d0a24f5e8106 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / 97e7966
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15671/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15671/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 29s branch-2.7 passed +1 compile 1m 7s branch-2.7 passed with JDK v1.8.0_91 +1 compile 1m 6s branch-2.7 passed with JDK v1.7.0_101 +1 checkstyle 0m 28s branch-2.7 passed +1 mvnsite 1m 1s branch-2.7 passed +1 mvneclipse 0m 21s branch-2.7 passed +1 findbugs 3m 13s branch-2.7 passed +1 javadoc 1m 12s branch-2.7 passed with JDK v1.8.0_91 +1 javadoc 1m 51s branch-2.7 passed with JDK v1.7.0_101 +1 mvninstall 0m 51s the patch passed +1 compile 0m 55s the patch passed with JDK v1.8.0_91 +1 javac 0m 55s the patch passed +1 compile 1m 0s the patch passed with JDK v1.7.0_101 +1 javac 1m 0s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 2630 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 1m 4s The patch 70 line(s) with tabs. +1 findbugs 3m 9s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 53s the patch passed with JDK v1.7.0_101 -1 unit 55m 46s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 56m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 19s The patch generated 3 ASF License warnings. 145m 44s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808501/HDFS-10458-branch-2.7.00.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d0a24f5e8106 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 97e7966 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15671/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15671/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15671/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        All reported branch-2.7 failures are unrelated and pass locally.

        Back porting to 2.6 was almost clean, but attaching patch to trigger Jenkins to be safe.

        Show
        zhz Zhe Zhang added a comment - All reported branch-2.7 failures are unrelated and pass locally. Back porting to 2.6 was almost clean, but attaching patch to trigger Jenkins to be safe.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 3m 41s Docker failed to build yetus/hadoop:44eef0e.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808548/HDFS-10458-branch-2.6.00.patch
        JIRA Issue HDFS-10458
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15676/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 3m 41s Docker failed to build yetus/hadoop:44eef0e. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808548/HDFS-10458-branch-2.6.00.patch JIRA Issue HDFS-10458 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15676/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 7s branch-2.6 passed
        -1 compile 0m 50s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91.
        -1 compile 0m 44s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
        +1 checkstyle 0m 27s branch-2.6 passed
        +1 mvnsite 1m 0s branch-2.6 passed
        +1 mvneclipse 0m 23s branch-2.6 passed
        -1 findbugs 3m 1s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
        +1 javadoc 1m 15s branch-2.6 passed with JDK v1.8.0_91
        +1 javadoc 1m 54s branch-2.6 passed with JDK v1.7.0_101
        +1 mvninstall 0m 54s the patch passed
        -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 compile 0m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 javac 0m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 3022 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 1m 2s The patch 74 line(s) with tabs.
        +1 findbugs 3m 3s the patch passed
        +1 javadoc 1m 9s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 49s the patch passed with JDK v1.7.0_101
        -1 unit 0m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 0m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 asflicense 0m 38s The patch generated 56 ASF License warnings.
        33m 56s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:44eef0e
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808548/HDFS-10458-branch-2.6.00.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 84be755e0dfe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 7fe08d7
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        findbugs v1.3.9
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15675/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15675/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 7s branch-2.6 passed -1 compile 0m 50s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91. -1 compile 0m 44s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 27s branch-2.6 passed +1 mvnsite 1m 0s branch-2.6 passed +1 mvneclipse 0m 23s branch-2.6 passed -1 findbugs 3m 1s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 15s branch-2.6 passed with JDK v1.8.0_91 +1 javadoc 1m 54s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 0m 54s the patch passed -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 compile 0m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 3022 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 1m 2s The patch 74 line(s) with tabs. +1 findbugs 3m 3s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 49s the patch passed with JDK v1.7.0_101 -1 unit 0m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 0m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 38s The patch generated 56 ASF License warnings. 33m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808548/HDFS-10458-branch-2.6.00.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 84be755e0dfe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 7fe08d7 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15675/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15675/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15675/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Zhe Zhang, I just noticed this breaks branch-2.8 build. So I reverted this from branch-2.8.

        Could you check if it breaks any other branches as well?

        Thanks,

        Show
        leftnoteasy Wangda Tan added a comment - Zhe Zhang , I just noticed this breaks branch-2.8 build. So I reverted this from branch-2.8. Could you check if it breaks any other branches as well? Thanks,
        Hide
        leftnoteasy Wangda Tan added a comment -

        branch-2 has the same issue, reverting patch from branch-2 as well.

        Show
        leftnoteasy Wangda Tan added a comment - branch-2 has the same issue, reverting patch from branch-2 as well.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the update Wangda Tan. I did build locally before pushing to branch-2 and branch-2.8. I also did a fresh Jenkins run for branch-2.7 and it passed.

        Show
        zhz Zhe Zhang added a comment - Thanks for the update Wangda Tan . I did build locally before pushing to branch-2 and branch-2.8. I also did a fresh Jenkins run for branch-2.7 and it passed.
        Hide
        zhz Zhe Zhang added a comment -

        Jenkins run results for branch-2.7 patch.

        Show
        zhz Zhe Zhang added a comment - Jenkins run results for branch-2.7 patch.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Zhe Zhang, perhaps this causes by different JDK version, etc. I didn't investigate further for that. This is Jenkins run with the patch: https://builds.apache.org/job/HADOOP2_Release_Artifacts_Builder/72/console.

        Show
        leftnoteasy Wangda Tan added a comment - Zhe Zhang , perhaps this causes by different JDK version, etc. I didn't investigate further for that. This is Jenkins run with the patch: https://builds.apache.org/job/HADOOP2_Release_Artifacts_Builder/72/console .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 5m 39s branch-2.6 passed
        -1 compile 0m 43s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91.
        -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
        +1 checkstyle 0m 22s branch-2.6 passed
        +1 mvnsite 1m 0s branch-2.6 passed
        +1 mvneclipse 0m 13s branch-2.6 passed
        -1 findbugs 2m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
        +1 javadoc 1m 9s branch-2.6 passed with JDK v1.8.0_91
        +1 javadoc 1m 55s branch-2.6 passed with JDK v1.7.0_101
        +1 mvninstall 0m 58s the patch passed
        -1 compile 0m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 javac 0m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 3402 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 1m 14s The patch 74 line(s) with tabs.
        +1 findbugs 3m 7s the patch passed
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 48s the patch passed with JDK v1.7.0_101
        -1 unit 0m 40s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 0m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 asflicense 0m 30s The patch generated 56 ASF License warnings.
        30m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:44eef0e
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808548/HDFS-10458-branch-2.6.00.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3aed7f426851 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 7fe08d7
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        findbugs v1.3.9
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15677/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15677/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 5m 39s branch-2.6 passed -1 compile 0m 43s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91. -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 22s branch-2.6 passed +1 mvnsite 1m 0s branch-2.6 passed +1 mvneclipse 0m 13s branch-2.6 passed -1 findbugs 2m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 9s branch-2.6 passed with JDK v1.8.0_91 +1 javadoc 1m 55s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 0m 58s the patch passed -1 compile 0m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 javac 0m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 3402 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 1m 14s The patch 74 line(s) with tabs. +1 findbugs 3m 7s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_101 -1 unit 0m 40s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 0m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 30s The patch generated 56 ASF License warnings. 30m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808548/HDFS-10458-branch-2.6.00.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3aed7f426851 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 7fe08d7 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15677/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15677/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15677/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Wangda for pointing this out. Yes I believe it is a JDK version issue. Attaching a branch-2 patch to verify with Jenkins.

        I don't think we need to revert it from branch-2.7. The 2.7 patch was rebased, and the compilation issue (Generics automatically type matching in constructor) was resolved at the rebase time.

        Show
        zhz Zhe Zhang added a comment - Thanks Wangda for pointing this out. Yes I believe it is a JDK version issue. Attaching a branch-2 patch to verify with Jenkins. I don't think we need to revert it from branch-2.7. The 2.7 patch was rebased, and the compilation issue ( Generics automatically type matching in constructor) was resolved at the rebase time.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks, Zhe Zhang!

        Show
        leftnoteasy Wangda Tan added a comment - Thanks, Zhe Zhang !
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 3m 51s Docker failed to build yetus/hadoop:babe025.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808568/HDFS-10458-branch-2.00.patch
        JIRA Issue HDFS-10458
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15680/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 3m 51s Docker failed to build yetus/hadoop:babe025. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808568/HDFS-10458-branch-2.00.patch JIRA Issue HDFS-10458 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15680/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 27s branch-2 passed
        +1 compile 0m 38s branch-2 passed with JDK v1.8.0_91
        +1 compile 0m 41s branch-2 passed with JDK v1.7.0_101
        +1 checkstyle 0m 27s branch-2 passed
        +1 mvnsite 0m 52s branch-2 passed
        +1 mvneclipse 0m 14s branch-2 passed
        -1 findbugs 1m 55s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 1m 3s branch-2 passed with JDK v1.8.0_91
        +1 javadoc 1m 46s branch-2 passed with JDK v1.7.0_101
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_91
        +1 javac 0m 36s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_101
        +1 javac 0m 39s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 1m 1s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 43s the patch passed with JDK v1.7.0_101
        -1 unit 50m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        +1 unit 47m 46s hadoop-hdfs in the patch passed with JDK v1.7.0_101.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        123m 3s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:babe025
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808568/HDFS-10458-branch-2.00.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux eb0588dab6c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / a29f8bd
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15681/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15681/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15681/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 27s branch-2 passed +1 compile 0m 38s branch-2 passed with JDK v1.8.0_91 +1 compile 0m 41s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 27s branch-2 passed +1 mvnsite 0m 52s branch-2 passed +1 mvneclipse 0m 14s branch-2 passed -1 findbugs 1m 55s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 3s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 46s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 47s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_91 +1 javac 0m 36s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_101 +1 javac 0m 39s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_101 -1 unit 50m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 47m 46s hadoop-hdfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 123m 3s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808568/HDFS-10458-branch-2.00.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eb0588dab6c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / a29f8bd Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15681/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/15681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15681/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15681/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 28s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 6s branch-2 passed
        +1 compile 0m 41s branch-2 passed with JDK v1.8.0_74
        +1 compile 0m 39s branch-2 passed with JDK v1.7.0_95
        +1 checkstyle 0m 30s branch-2 passed
        +1 mvnsite 0m 52s branch-2 passed
        +1 mvneclipse 0m 22s branch-2 passed
        -1 findbugs 2m 2s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 1m 3s branch-2 passed with JDK v1.8.0_74
        +1 javadoc 1m 45s branch-2 passed with JDK v1.7.0_95
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 34s the patch passed with JDK v1.8.0_74
        +1 javac 0m 34s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.7.0_95
        +1 javac 0m 39s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 4s the patch passed
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 46s the patch passed with JDK v1.7.0_95
        -1 unit 62m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        +1 unit 64m 56s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        155m 42s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:babe025
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808568/HDFS-10458-branch-2.00.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7a52732729d7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / d30e194
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15679/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15679/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15679/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15679/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15679/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 6s branch-2 passed +1 compile 0m 41s branch-2 passed with JDK v1.8.0_74 +1 compile 0m 39s branch-2 passed with JDK v1.7.0_95 +1 checkstyle 0m 30s branch-2 passed +1 mvnsite 0m 52s branch-2 passed +1 mvneclipse 0m 22s branch-2 passed -1 findbugs 2m 2s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 3s branch-2 passed with JDK v1.8.0_74 +1 javadoc 1m 45s branch-2 passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 0m 34s the patch passed with JDK v1.8.0_74 +1 javac 0m 34s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_95 -1 unit 62m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 64m 56s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 155m 42s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808568/HDFS-10458-branch-2.00.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7a52732729d7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / d30e194 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15679/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/15679/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15679/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15679/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15679/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        I verified branch-2 patch Jenkins failures, all pass locally. I will recommit to branch-2 and branch-2.8 shortly. Thanks again for Wangda Tan's note.

        Attaching branch-2.6 patch again to trigger Jenkins.

        Show
        zhz Zhe Zhang added a comment - I verified branch-2 patch Jenkins failures, all pass locally. I will recommit to branch-2 and branch-2.8 shortly. Thanks again for Wangda Tan 's note. Attaching branch-2.6 patch again to trigger Jenkins.
        Hide
        zhz Zhe Zhang added a comment -

        Committed to branch-2 and branch-2.8. Now only waiting for branch-2.6 Jenkins run.

        Show
        zhz Zhe Zhang added a comment - Committed to branch-2 and branch-2.8. Now only waiting for branch-2.6 Jenkins run.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 24s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 5m 45s branch-2.6 passed
        -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91.
        -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
        +1 checkstyle 0m 22s branch-2.6 passed
        +1 mvnsite 0m 56s branch-2.6 passed
        +1 mvneclipse 0m 13s branch-2.6 passed
        -1 findbugs 2m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
        +1 javadoc 1m 8s branch-2.6 passed with JDK v1.8.0_91
        +1 javadoc 1m 53s branch-2.6 passed with JDK v1.7.0_101
        +1 mvninstall 0m 55s the patch passed
        -1 compile 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 javac 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        -1 whitespace 0m 0s The patch has 4452 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 1m 40s The patch 74 line(s) with tabs.
        +1 findbugs 3m 3s the patch passed
        +1 javadoc 1m 7s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_101
        -1 unit 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 0m 44s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 asflicense 0m 30s The patch generated 56 ASF License warnings.
        31m 10s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:44eef0e
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808701/HDFS-10458-branch-2.6.01.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b2baba844afa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 7fe08d7
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        findbugs v1.3.9
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15689/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15689/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 5m 45s branch-2.6 passed -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91. -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 22s branch-2.6 passed +1 mvnsite 0m 56s branch-2.6 passed +1 mvneclipse 0m 13s branch-2.6 passed -1 findbugs 2m 52s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 8s branch-2.6 passed with JDK v1.8.0_91 +1 javadoc 1m 53s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 0m 55s the patch passed -1 compile 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 javac 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 4452 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 1m 40s The patch 74 line(s) with tabs. +1 findbugs 3m 3s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_101 -1 unit 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 0m 44s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 30s The patch generated 56 ASF License warnings. 31m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808701/HDFS-10458-branch-2.6.01.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b2baba844afa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 7fe08d7 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15689/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15689/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15689/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 15s branch-2.6 passed
        -1 compile 0m 44s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91.
        -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
        +1 checkstyle 0m 26s branch-2.6 passed
        +1 mvnsite 0m 58s branch-2.6 passed
        +1 mvneclipse 0m 20s branch-2.6 passed
        -1 findbugs 2m 59s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
        +1 javadoc 1m 12s branch-2.6 passed with JDK v1.8.0_91
        +1 javadoc 1m 55s branch-2.6 passed with JDK v1.7.0_101
        +1 mvninstall 0m 56s the patch passed
        -1 compile 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 javac 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 4452 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 1m 42s The patch 74 line(s) with tabs.
        +1 findbugs 3m 6s the patch passed
        +1 javadoc 1m 7s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 55s the patch passed with JDK v1.7.0_101
        -1 unit 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 0m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        -1 asflicense 0m 37s The patch generated 56 ASF License warnings.
        34m 11s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:44eef0e
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808701/HDFS-10458-branch-2.6.01.patch
        JIRA Issue HDFS-10458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bd3079ed4679 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 7fe08d7
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        findbugs v1.3.9
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15688/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15688/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 15s branch-2.6 passed -1 compile 0m 44s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91. -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 26s branch-2.6 passed +1 mvnsite 0m 58s branch-2.6 passed +1 mvneclipse 0m 20s branch-2.6 passed -1 findbugs 2m 59s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 12s branch-2.6 passed with JDK v1.8.0_91 +1 javadoc 1m 55s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 0m 56s the patch passed -1 compile 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 javac 0m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 4452 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 1m 42s The patch 74 line(s) with tabs. +1 findbugs 3m 6s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_101 -1 unit 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 0m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 37s The patch generated 56 ASF License warnings. 34m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808701/HDFS-10458-branch-2.6.01.patch JIRA Issue HDFS-10458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bd3079ed4679 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 7fe08d7 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15688/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15688/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15688/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Verified branch-2.6 patch with a local build. Committed to branch-2.6 as well. Resolving the issue now. Thanks Konstantin Shvachko for the review.

        Show
        zhz Zhe Zhang added a comment - Verified branch-2.6 patch with a local build. Committed to branch-2.6 as well. Resolving the issue now. Thanks Konstantin Shvachko for the review.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            zhz Zhe Zhang
            Reporter:
            zhz Zhe Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development