Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10438

When NameNode HA is configured to use the lifeline RPC server, it should log the address of that server.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ha, namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      As reported by KWON BYUNGCHANG:

      I have configured below

      dfs.namenode.servicerpc-address.xdev.nn1=my.host.com:8040
      dfs.namenode.lifeline.rpc-address.xdev.nn1=my.host.com:8041
      

      servicerpc port is 8040, lifeline port is 8041.
      however zkfc daemon is logging using servicerpc port.
      It may cause confusion.

      thank you.

      2016-05-19 19:18:40,566 WARN  ha.HealthMonitor (HealthMonitor.java:doHealthChecks(207)) - Service health check failed for NameNode at my.host.com/10.114.87.91:8040: The NameNode has no resources available
      
      1. HDFS-10438.002.patch
        3 kB
        Chris Nauroth
      2. HDFS-10438.001.patch
        3 kB
        Chris Nauroth

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9835 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9835/)
        HDFS-10438. When NameNode HA is configured to use the lifeline RPC (cnauroth: rev 500e946729e1b85fdc0ce8475d8ce118ba886f46)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/NNHAServiceTarget.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestNNHealthCheck.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9835 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9835/ ) HDFS-10438 . When NameNode HA is configured to use the lifeline RPC (cnauroth: rev 500e946729e1b85fdc0ce8475d8ce118ba886f46) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/NNHAServiceTarget.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestNNHealthCheck.java
        Hide
        cnauroth Chris Nauroth added a comment -

        I have committed this to trunk, branch-2 and branch-2.8. Arpit Agarwal and Kihwal Lee, thank you for the code reviews.

        Show
        cnauroth Chris Nauroth added a comment - I have committed this to trunk, branch-2 and branch-2.8. Arpit Agarwal and Kihwal Lee , thank you for the code reviews.
        Hide
        kihwal Kihwal Lee added a comment -

        Post-precommit +1 as the final nail on the coffin.

        Show
        kihwal Kihwal Lee added a comment - Post-precommit +1 as the final nail on the coffin.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 20s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 44s trunk passed
        +1 javadoc 1m 6s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 51s the patch passed
        +1 javadoc 1m 6s the patch passed
        -1 unit 60m 18s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        79m 23s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestAsyncDFSRename



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805149/HDFS-10438.002.patch
        JIRA Issue HDFS-10438
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 10ff22852954 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9325845
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15510/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15510/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 20s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 1m 6s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 1m 6s the patch passed -1 unit 60m 18s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 79m 23s Reason Tests Failed junit tests hadoop.hdfs.TestAsyncDFSRename Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805149/HDFS-10438.002.patch JIRA Issue HDFS-10438 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 10ff22852954 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9325845 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15510/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15510/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the v002 patch.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the v002 patch.
        Hide
        cnauroth Chris Nauroth added a comment -

        Arpit Agarwal, thank you for the review. I'm attaching patch v002 with just a cosmetic change to satisfy the Checkstyle line length warning. Dos this still look good?

        Show
        cnauroth Chris Nauroth added a comment - Arpit Agarwal , thank you for the review. I'm attaching patch v002 with just a cosmetic change to satisfy the Checkstyle line length warning. Dos this still look good?
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 thanks Chris Nauroth.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 thanks Chris Nauroth .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 32s trunk passed
        +1 compile 0m 56s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 1m 11s trunk passed
        +1 mvninstall 0m 59s the patch passed
        +1 compile 0m 51s the patch passed
        +1 javac 0m 51s the patch passed
        -1 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 208 unchanged - 0 fixed = 209 total (was 208)
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 10s the patch passed
        +1 javadoc 1m 16s the patch passed
        -1 unit 68m 13s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        91m 42s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.hdfs.TestAsyncDFSRename
          hadoop.hdfs.security.TestDelegationTokenForProxyUser



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805078/HDFS-10438.001.patch
        JIRA Issue HDFS-10438
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 99dd3ce764e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 42c22f7
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15505/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15505/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15505/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 32s trunk passed +1 compile 0m 56s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 11s trunk passed +1 mvninstall 0m 59s the patch passed +1 compile 0m 51s the patch passed +1 javac 0m 51s the patch passed -1 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 208 unchanged - 0 fixed = 209 total (was 208) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 16s the patch passed -1 unit 68m 13s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 91m 42s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.TestAsyncDFSRename   hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805078/HDFS-10438.001.patch JIRA Issue HDFS-10438 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 99dd3ce764e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 42c22f7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15505/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15505/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15505/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        Just in case it's not obvious, the toString method I'm changing gets called from org.apache.hadoop.ha.HealthMonitor up in hadoop-common. That's why changing the toString code fixes the log message.

        Show
        cnauroth Chris Nauroth added a comment - Just in case it's not obvious, the toString method I'm changing gets called from org.apache.hadoop.ha.HealthMonitor up in hadoop-common. That's why changing the toString code fixes the log message.
        Hide
        cnauroth Chris Nauroth added a comment -

        I'm attaching a patch that uses the lifeline address in the string that gets logged if a lifeline address is configured. I also updated a test to check for the correct string representation. While working on this, I noticed that MiniDFSCluster was not quite doing the right thing for copying the lifeline address configuration key in a multi-nameservice/multi-namenode setup.

        Show
        cnauroth Chris Nauroth added a comment - I'm attaching a patch that uses the lifeline address in the string that gets logged if a lifeline address is configured. I also updated a test to check for the correct string representation. While working on this, I noticed that MiniDFSCluster was not quite doing the right thing for copying the lifeline address configuration key in a multi-nameservice/multi-namenode setup.

          People

          • Assignee:
            cnauroth Chris Nauroth
            Reporter:
            magnum KWON BYUNGCHANG
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development