Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10429

DataStreamer interrupted warning always appears when using CLI upload file

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.7.3
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Every time I use 'hdfs dfs -put' upload file, this warning is printed:

      16/05/18 20:57:56 WARN hdfs.DataStreamer: Caught exception
      java.lang.InterruptedException
      	at java.lang.Object.wait(Native Method)
      	at java.lang.Thread.join(Thread.java:1245)
      	at java.lang.Thread.join(Thread.java:1319)
      	at org.apache.hadoop.hdfs.DataStreamer.closeResponder(DataStreamer.java:871)
      	at org.apache.hadoop.hdfs.DataStreamer.endBlock(DataStreamer.java:519)
      	at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:696)
      

      The reason is this: originally, DataStreamer::closeResponder always prints a warning about InterruptedException; since HDFS-9812, DFSOutputStream::closeImpl always forces threads to close, which causes InterruptedException.

      A simple fix is to use debug level log instead of warning level.

      1. HDFS-10429.1.patch
        0.7 kB
        Zhiyuan Yang
      2. HDFS-10429.2.patch
        0.8 kB
        Zhiyuan Yang
      3. HDFS-10429.3.patch
        2 kB
        Wei-Chiu Chuang

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 39s trunk passed
        +1 compile 0m 29s trunk passed
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 30s trunk passed
        +1 javadoc 0m 19s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 26s the patch passed
        +1 javac 0m 26s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 31s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 37s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 0m 52s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 16s Patch does not generate ASF License warnings.
        16m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch
        JIRA Issue HDFS-10429
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a50c6e86b0f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 010e6ac
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15486/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15486/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 39s trunk passed +1 compile 0m 29s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 19s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 26s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 0m 52s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 16m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch JIRA Issue HDFS-10429 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a50c6e86b0f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 010e6ac Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15486/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15486/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Hi, Zhiyuan Yang, good catch! Thanks for reporting this! The patch looks good to me.

        Show
        linyiqun Yiqun Lin added a comment - Hi, Zhiyuan Yang , good catch! Thanks for reporting this! The patch looks good to me.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 34s trunk passed
        +1 compile 0m 30s trunk passed
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 32s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 27s the patch passed
        +1 javac 0m 27s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvnsite 0m 32s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 35s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 0m 55s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        16m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch
        JIRA Issue HDFS-10429
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ccf8b26a9d8c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1597630
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15491/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15491/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 34s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 27s the patch passed +1 javac 0m 27s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 35s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 0m 55s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 16m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch JIRA Issue HDFS-10429 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ccf8b26a9d8c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1597630 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15491/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15491/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for working on this, Zhiyuan Yang!

        I can also reproduce the issue in my environment. When DataStreamer#close is called, streamerClosed is first set to false, which may trigger the DataStreamer thread to end its loop and invoke closeInternal. Then while the DataStreamer thread is still waiting for the ResponseProcessor to die (response.join()), the interruption from DataStreamer#close(true) can interrupt the DataStreamer thread and generate the warning msg.

        For the fix, I think it's ok to change the log level to debug. But in the meanwhile, the current closing logic for DFSOutputStream/DataStreamer seems not clean. Based on the current implementation, DataStreamer#closeInternal is expected to be used to correctly close the ResponseProcessor. Thus maybe a simple fix can be to still call closeThreads(false) inside of "try" section of closeImpl, and only when the normal close op has not been triggered or fails, we call closeThreads(true) again in the "finally" section.

        Show
        jingzhao Jing Zhao added a comment - Thanks for working on this, Zhiyuan Yang ! I can also reproduce the issue in my environment. When DataStreamer#close is called, streamerClosed is first set to false, which may trigger the DataStreamer thread to end its loop and invoke closeInternal . Then while the DataStreamer thread is still waiting for the ResponseProcessor to die ( response.join() ), the interruption from DataStreamer#close(true) can interrupt the DataStreamer thread and generate the warning msg. For the fix, I think it's ok to change the log level to debug. But in the meanwhile, the current closing logic for DFSOutputStream/DataStreamer seems not clean. Based on the current implementation, DataStreamer#closeInternal is expected to be used to correctly close the ResponseProcessor. Thus maybe a simple fix can be to still call closeThreads(false) inside of "try" section of closeImpl , and only when the normal close op has not been triggered or fails, we call closeThreads(true) again in the "finally" section.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 52s trunk passed
        +1 compile 0m 29s trunk passed
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 33s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 33s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 27s the patch passed
        +1 javac 0m 27s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 30s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 0m 52s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 15s Patch does not generate ASF License warnings.
        16m 23s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch
        JIRA Issue HDFS-10429
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bdb61420f767 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b4078bd
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15535/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15535/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 52s trunk passed +1 compile 0m 29s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 33s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 27s the patch passed +1 javac 0m 27s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 30s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 0m 52s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 15s Patch does not generate ASF License warnings. 16m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch JIRA Issue HDFS-10429 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bdb61420f767 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b4078bd Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15535/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15535/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 56s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 39s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 28s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 33s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 44s the patch passed
        +1 javadoc 0m 18s the patch passed
        +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        18m 21s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10429
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 06b14025bdd5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 236ac77
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16927/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16927/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 56s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 28s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 18m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10429 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804790/HDFS-10429.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 06b14025bdd5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 236ac77 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16927/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16927/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Ping: Jing Zhao's suggestion sounds good to me. Zhiyuan Yang would you like to submit a new patch? Thanks a lot.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Ping: Jing Zhao 's suggestion sounds good to me. Zhiyuan Yang would you like to submit a new patch? Thanks a lot.
        Hide
        aplusplus Zhiyuan Yang added a comment -

        Sorry for holding this too long...Will do it later today. Thanks for reminding me!

        Show
        aplusplus Zhiyuan Yang added a comment - Sorry for holding this too long...Will do it later today. Thanks for reminding me!
        Hide
        aplusplus Zhiyuan Yang added a comment -

        New patch according to Jing Zhao's comments. Log level hasn't been changed so that we won't hide problems.

        Show
        aplusplus Zhiyuan Yang added a comment - New patch according to Jing Zhao 's comments. Log level hasn't been changed so that we won't hide problems.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 51s trunk passed
        +1 compile 0m 38s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 38s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 37s trunk passed
        +1 javadoc 0m 24s trunk passed
        +1 mvninstall 0m 33s the patch passed
        +1 compile 0m 31s the patch passed
        +1 javac 0m 31s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 38s the patch passed
        +1 javadoc 0m 20s the patch passed
        +1 unit 1m 2s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        19m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10429
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831572/HDFS-10429.2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 02dbeb38c677 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 382307c
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17003/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17003/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 51s trunk passed +1 compile 0m 38s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 24s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 20s the patch passed +1 unit 1m 2s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 19m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10429 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831572/HDFS-10429.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 02dbeb38c677 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 382307c Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17003/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17003/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hello Zhiyuan Yang
        Thanks for submitting a new patch. I have a few questions regarding this patch.

        • First of all, should closeThreads(false); be called before try...completeFile? Pre-HDFS-9812 code had the method call before that.
        • Would you also like to contribute a unit test? Or is there a way to reproduce it? I honestly can't reproduce the warning whether in a unit test or a real cluster.
        • Does DFSStripedOutputStream suffer from the same annoying warning? It seems the logic are mostly the same. Jing Zhao would you mind to comment on this?
        Show
        jojochuang Wei-Chiu Chuang added a comment - Hello Zhiyuan Yang Thanks for submitting a new patch. I have a few questions regarding this patch. First of all, should closeThreads(false); be called before try...completeFile? Pre- HDFS-9812 code had the method call before that. Would you also like to contribute a unit test? Or is there a way to reproduce it? I honestly can't reproduce the warning whether in a unit test or a real cluster. Does DFSStripedOutputStream suffer from the same annoying warning? It seems the logic are mostly the same. Jing Zhao would you mind to comment on this?
        Hide
        aplusplus Zhiyuan Yang added a comment -

        Weird, I'm unable to reproduce it neither... Should we mark this as "cannot reproduce" temporarily and reopen it once problem reappears?

        Show
        aplusplus Zhiyuan Yang added a comment - Weird, I'm unable to reproduce it neither... Should we mark this as "cannot reproduce" temporarily and reopen it once problem reappears?
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        We've got a few cases filed for this issue, so I suppose it's relatively easy to reproduce. However I just don't know if it's because I do not have a proper set up for this issue to surface up. Jing Zhao would you mind to share how you reproduced it?

        Show
        jojochuang Wei-Chiu Chuang added a comment - We've got a few cases filed for this issue, so I suppose it's relatively easy to reproduce. However I just don't know if it's because I do not have a proper set up for this issue to surface up. Jing Zhao would you mind to share how you reproduced it?
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        I think that closeThreads(false) should be called before try...completeFile to allow response processors to close gracefully while the client asks NN to complete the file. It is possible that the threads are not closed when the forceful close() is called, in which case reducing the log level from warn to debug can eliminate user frustration.

        Show
        jojochuang Wei-Chiu Chuang added a comment - I think that closeThreads(false) should be called before try...completeFile to allow response processors to close gracefully while the client asks NN to complete the file. It is possible that the threads are not closed when the forceful close() is called, in which case reducing the log level from warn to debug can eliminate user frustration.
        Hide
        aplusplus Zhiyuan Yang added a comment -

        I'm sorry but I don't think I'm able to handle this for now given my very limited knowledge about HDFS (and limited time...). It seems you're much more familiar with this piece of code than me, so feel free to take over this jira if you want a quick fix.

        Show
        aplusplus Zhiyuan Yang added a comment - I'm sorry but I don't think I'm able to handle this for now given my very limited knowledge about HDFS (and limited time...). It seems you're much more familiar with this piece of code than me, so feel free to take over this jira if you want a quick fix.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Zhiyuan Yang I'd like to submit a new patch:
        Here's a new patch to reduce log level when interrupted, and try to close output stream without force before completing a file.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Zhiyuan Yang I'd like to submit a new patch: Here's a new patch to reduce log level when interrupted, and try to close output stream without force before completing a file.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 9s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 33s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 33s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvnsite 0m 32s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 31s the patch passed
        +1 javadoc 0m 18s the patch passed
        +1 unit 1m 6s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        17m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10429
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832706/HDFS-10429.3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 64e5b10620f6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 809cfd2
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17101/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17101/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 9s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 1m 6s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 17m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10429 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832706/HDFS-10429.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 64e5b10620f6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 809cfd2 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17101/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17101/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hello, I'd like to invite anyone on the watch list to review the patch
        Jing Zhao would you be able to share how to reproduce the issue?

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hello, I'd like to invite anyone on the watch list to review the patch Jing Zhao would you be able to share how to reproduce the issue?
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        I have not been able to make progress on this.

        But for the record, I suspect this bug could result in resource leakage (threads, sockets for example). That said, resource leakage shouldn't be a big issue. Threads will be terminated anyway if CLI command process stops.

        Show
        jojochuang Wei-Chiu Chuang added a comment - I have not been able to make progress on this. But for the record, I suspect this bug could result in resource leakage (threads, sockets for example). That said, resource leakage shouldn't be a big issue. Threads will be terminated anyway if CLI command process stops.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 7s trunk passed
        +1 compile 0m 30s trunk passed
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 32s trunk passed
        -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        +1 javadoc 0m 19s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 34s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 31s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 18s the patch passed
              Other Tests
        +1 unit 1m 20s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        23m 6s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-10429
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832706/HDFS-10429.3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a638c7c51bba 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5f4808c
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20442/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20442/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20442/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 7s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 32s trunk passed -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 19s trunk passed       Patch Compile Tests +1 mvninstall 0m 34s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests +1 unit 1m 20s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 23m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-10429 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832706/HDFS-10429.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a638c7c51bba 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5f4808c Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20442/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20442/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20442/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        boky01 Andras Bokor added a comment - - edited

        I am not confident in this area but I tried out the patch on a cluster with 4 datanodes.
        I have tested with 12000 random files between 1-10 MB. Before the patch I got exceptions. After the patch I run the copy 3 times (which means 36000 files) without exception so it seems the patch fixes the issue.
        Related the code of patch:

        • We should consider introducing some checks in finally to not to call close methods twice. Something like if(!getStreamer().isSocketClosed() || !getStreamer().isAlive()) and call forced close if something is not closed properly. What do you think?
        • I would not hide the InterruptedExceptions where it's not expected. It can show when our thread handling is not clean like in this case.

        Other than the two bullet points I'd give a non-binding +1 since my test shows that the exceptions disappeared and all the files were copied to HDFS.

        Show
        boky01 Andras Bokor added a comment - - edited I am not confident in this area but I tried out the patch on a cluster with 4 datanodes. I have tested with 12000 random files between 1-10 MB. Before the patch I got exceptions. After the patch I run the copy 3 times (which means 36000 files) without exception so it seems the patch fixes the issue. Related the code of patch: We should consider introducing some checks in finally to not to call close methods twice. Something like if(!getStreamer().isSocketClosed() || !getStreamer().isAlive()) and call forced close if something is not closed properly. What do you think? I would not hide the InterruptedExceptions where it's not expected. It can show when our thread handling is not clean like in this case. Other than the two bullet points I'd give a non-binding +1 since my test shows that the exceptions disappeared and all the files were copied to HDFS.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Andras Bokor for review!
        Thanks for sharing the reproduction steps. I'll go ahead and revise the patch base on your comment.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Andras Bokor for review! Thanks for sharing the reproduction steps. I'll go ahead and revise the patch base on your comment.

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            aplusplus Zhiyuan Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:

              Development