Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10417

Improve error message from checkBlockLocalPathAccess

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The exception msg thrown by checkBlockLocalPathAccess is very specific to the implementation detail. It's really hard for users to understand it unless she reads and understands the code.

      The code is shown as follows:

      org.apache.hadoop.hdfs.server.datanode.DataNode
        private void checkBlockLocalPathAccess() throws IOException {
          checkKerberosAuthMethod("getBlockLocalPathInfo()");
          String currentUser = UserGroupInformation.getCurrentUser().getShortUserName();
          if (!usersWithLocalPathAccess.contains(currentUser)) {
            throw new AccessControlException(
                "Can't continue with getBlockLocalPathInfo() "
                    + "authorization. The user " + currentUser
                    + " is not allowed to call getBlockLocalPathInfo");
          }    
        }
      

      (basically she needs to understand the code logic of getBlockLocalPathInfo)


      Note that usersWithLocalPathAccess is a private final purely coming from the configuration settings of dfs.block.local-path-access.user,

      org.apache.hadoop.hdfs.server.datanode.DataNode
      private final List<String> usersWithLocalPathAccess;
      ....
      this.usersWithLocalPathAccess = Arrays.asList(
          conf.getTrimmedStrings(DFSConfigKeys.DFS_BLOCK_LOCAL_PATH_ACCESS_USER_KEY));
      

      In other word, the checking fails simply because the current user is not specified in the configuration setting of dfs.block.local-path-access.user. The log message should be much more clearer to make it easy for users to take actions, as demonstrated in the attached patch.

      Thanks!

      1. HDFS-10417.000.patch
        0.9 kB
        Tianyin Xu
      2. HDFS-10417.001.patch
        2 kB
        Tianyin Xu
      3. HDFS-10417.002.patch
        2 kB
        Tianyin Xu

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9826 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9826/)
        HDFS-10417. Improve error message from checkBlockLocalPathAccess. (kihwal: rev 204de430bf6a931e5688789c7a783c9c568a98c2)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitLocalRead.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9826 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9826/ ) HDFS-10417 . Improve error message from checkBlockLocalPathAccess. (kihwal: rev 204de430bf6a931e5688789c7a783c9c568a98c2) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitLocalRead.java
        Hide
        kihwal Kihwal Lee added a comment -

        Committed this to trunk, branch-2 and branch-2.8. Thanks for the patch, Tianyin Xu.

        Show
        kihwal Kihwal Lee added a comment - Committed this to trunk, branch-2 and branch-2.8. Thanks for the patch, Tianyin Xu .
        Hide
        kihwal Kihwal Lee added a comment -

        +1 for the latest patch.

        Show
        kihwal Kihwal Lee added a comment - +1 for the latest patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 34s trunk passed
        +1 compile 0m 50s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 47s trunk passed
        +1 javadoc 1m 4s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 48s the patch passed
        +1 javadoc 1m 3s the patch passed
        -1 unit 60m 12s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        80m 33s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestFileCreationDelete
          hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805022/HDFS-10417.002.patch
        JIRA Issue HDFS-10417
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3bfa86c98c60 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 141873c
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15498/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15498/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15498/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15498/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 34s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 47s trunk passed +1 javadoc 1m 4s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 1m 3s the patch passed -1 unit 60m 12s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 80m 33s Reason Tests Failed junit tests hadoop.hdfs.TestFileCreationDelete   hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805022/HDFS-10417.002.patch JIRA Issue HDFS-10417 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3bfa86c98c60 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 141873c Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15498/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15498/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15498/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15498/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 38s trunk passed
        +1 compile 0m 55s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 2m 6s trunk passed
        +1 javadoc 1m 19s trunk passed
        +1 mvninstall 1m 6s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 1m 5s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 1m 10s the patch passed
        -1 unit 62m 19s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        85m 52s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804983/HDFS-10417.002.patch
        JIRA Issue HDFS-10417
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2768d1cfd6d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 141873c
        Default Java 1.8.0_91
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15496/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15496/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15496/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 38s trunk passed +1 compile 0m 55s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 2m 6s trunk passed +1 javadoc 1m 19s trunk passed +1 mvninstall 1m 6s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 2s the patch passed +1 javadoc 1m 10s the patch passed -1 unit 62m 19s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 85m 52s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804983/HDFS-10417.002.patch JIRA Issue HDFS-10417 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2768d1cfd6d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 141873c Default Java 1.8.0_91 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15496/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15496/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15496/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        tianyin Tianyin Xu added a comment -

        the new patch that follow the style rule

        Show
        tianyin Tianyin Xu added a comment - the new patch that follow the style rule
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 5s trunk passed
        +1 compile 0m 42s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 38s trunk passed
        +1 javadoc 1m 6s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 40s the patch passed
        +1 javac 0m 40s the patch passed
        -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 193 unchanged - 0 fixed = 195 total (was 193)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 1m 3s the patch passed
        -1 unit 73m 30s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        92m 1s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804519/HDFS-10417.001.patch
        JIRA Issue HDFS-10417
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2d3b60306ac8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d4274c6
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15494/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15494/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15494/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15494/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15494/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 5s trunk passed +1 compile 0m 42s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 1m 6s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 193 unchanged - 0 fixed = 195 total (was 193) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 1m 3s the patch passed -1 unit 73m 30s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 92m 1s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804519/HDFS-10417.001.patch JIRA Issue HDFS-10417 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2d3b60306ac8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d4274c6 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15494/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15494/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15494/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15494/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15494/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        tianyin Tianyin Xu added a comment -

        Sorry for that. I changed the unit test, and passed the TestShortCircuitLocalRead. Thanks again, Kihwal Lee!

        Show
        tianyin Tianyin Xu added a comment - Sorry for that. I changed the unit test, and passed the TestShortCircuitLocalRead. Thanks again, Kihwal Lee !
        Hide
        tianyin Tianyin Xu added a comment -

        New patch with the unit test adjusted.

        Show
        tianyin Tianyin Xu added a comment - New patch with the unit test adjusted.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9806 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9806/)
        HDFS-10417. Improve error message from checkBlockLocalPathAccess. (kihwal: rev 0942954e8ab6bef636c2648d0d5a0227a50f799c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          Revert "HDFS-10417. Improve error message from (kihwal: rev 1356cbe9941c1692c6614201e63187916a3eebb0)
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9806 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9806/ ) HDFS-10417 . Improve error message from checkBlockLocalPathAccess. (kihwal: rev 0942954e8ab6bef636c2648d0d5a0227a50f799c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java Revert " HDFS-10417 . Improve error message from (kihwal: rev 1356cbe9941c1692c6614201e63187916a3eebb0) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        kihwal Kihwal Lee added a comment - - edited

        Sorry, I reverted it. It breaks a test case which compares the error string. It will be a simple fix. Please provide an update patch.

        See TestShortCircuitLocalRead.testDeprecatedGetBlockLocalPathInfoRpc.

        Show
        kihwal Kihwal Lee added a comment - - edited Sorry, I reverted it. It breaks a test case which compares the error string. It will be a simple fix. Please provide an update patch. See TestShortCircuitLocalRead.testDeprecatedGetBlockLocalPathInfoRpc .
        Hide
        tianyin Tianyin Xu added a comment -
        Show
        tianyin Tianyin Xu added a comment - Thanks a lot, Kihwal Lee ! Yes, I understand. The related docs are here, http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/ShortCircuitLocalReads.html
        Hide
        kihwal Kihwal Lee added a comment -

        +1. BTW, this is for the "legacy" short-circuit reads. The newer short-circuit read is more flexible and does not require special user setup.

        Show
        kihwal Kihwal Lee added a comment - +1. BTW, this is for the "legacy" short-circuit reads. The newer short-circuit read is more flexible and does not require special user setup.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 15m 58s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 28s trunk passed
        +1 compile 0m 52s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 49s trunk passed
        +1 javadoc 1m 12s trunk passed
        +1 mvninstall 0m 53s the patch passed
        +1 compile 0m 47s the patch passed
        +1 javac 0m 47s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 56s the patch passed
        +1 javadoc 1m 9s the patch passed
        -1 unit 71m 42s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        108m 43s



        Reason Tests
        Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
          hadoop.hdfs.TestAsyncDFSRename



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804331/HDFS-10417.000.patch
        JIRA Issue HDFS-10417
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b04494d73e26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2c91fd8
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15455/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15455/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15455/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15455/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 15m 58s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 28s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 1m 12s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 1m 9s the patch passed -1 unit 71m 42s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 108m 43s Reason Tests Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.TestAsyncDFSRename Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804331/HDFS-10417.000.patch JIRA Issue HDFS-10417 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b04494d73e26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c91fd8 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15455/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15455/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15455/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15455/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            tianyin Tianyin Xu
            Reporter:
            tianyin Tianyin Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development