Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10404

Fix formatting of CacheAdmin command usage help text

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: caching
    • Labels:
      None
    • Target Version/s:

      Description

      In CacheAdmin, there are two places that not completely showing the cmd usage message.

      $ hdfs cacheadmin
      Usage: bin/hdfs cacheadmin [COMMAND]
                [-addDirective -path <path> -pool <pool-name> [-force] [-replication <replication>] [-ttl <time-to-live>]]
                [-modifyDirective -id <id> [-path <path>] [-force] [-replication <replication>] [-pool <pool-name>] [-ttl <time-to-live>]]
                [-listDirectives [-stats] [-path <path>] [-pool <pool>] [-id <id>]
                [-removeDirective <id>]
                [-removeDirectives -path <path>]
                [-addPool <name> [-owner <owner>] [-group <group>] [-mode <mode>] [-limit <limit>] [-maxTtl <maxTtl>]
      

      The command -listDirectives and -addPool are not showing completely, they are both lacking a ']' in the end of line.

      In the CentralizedCacheManagement.md, there is also a similar problem. The page of CentralizedCacheManagement can also showed this, https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-hdfs/CentralizedCacheManagement.html

      1. HDFS-10404.002.patch
        3 kB
        Yiqun Lin
      2. HDFS-10404.001.patch
        2 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        I will post a patch later.

        Show
        linyiqun Yiqun Lin added a comment - I will post a patch later.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a simple patch for this, who can assign this JIRA to me? Thanks.

        Show
        linyiqun Yiqun Lin added a comment - Attach a simple patch for this, who can assign this JIRA to me? Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 39s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 56s trunk passed
        +1 compile 0m 45s trunk passed with JDK v1.8.0_91
        +1 compile 0m 45s trunk passed with JDK v1.7.0_101
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 3s trunk passed
        +1 javadoc 1m 9s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 58s trunk passed with JDK v1.7.0_101
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.8.0_91
        +1 javac 0m 42s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.7.0_101
        +1 javac 0m 42s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 28s the patch passed
        +1 javadoc 1m 9s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 56s the patch passed with JDK v1.7.0_101
        -1 unit 59m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        +1 unit 53m 17s hadoop-hdfs in the patch passed with JDK v1.7.0_101.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        154m 55s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestFileAppend



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804095/HDFS-10404.001.patch
        JIRA Issue HDFS-10404
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bc7073e0860f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f45bc5a
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15438/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15438/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15438/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15438/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 39s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 56s trunk passed +1 compile 0m 45s trunk passed with JDK v1.8.0_91 +1 compile 0m 45s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 1m 9s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 58s trunk passed with JDK v1.7.0_101 +1 mvninstall 0m 49s the patch passed +1 compile 0m 42s the patch passed with JDK v1.8.0_91 +1 javac 0m 42s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_101 +1 javac 0m 42s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_101 -1 unit 59m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 53m 17s hadoop-hdfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 154m 55s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestFileAppend Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804095/HDFS-10404.001.patch JIRA Issue HDFS-10404 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bc7073e0860f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f45bc5a Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15438/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15438/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15438/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15438/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        The failed unit test was tracked by HDFS-10333.

        Show
        linyiqun Yiqun Lin added a comment - The failed unit test was tracked by HDFS-10333 .
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Yiqun Lin, thanks for the patch! I added you as a contributor on JIRA so you can be assigned JIRAs now.

        One tiny nit, do you mind appending the ]\n string on a new line? That helps future-proof in case we add more options later. Otherwise +1.

        Show
        andrew.wang Andrew Wang added a comment - Hi Yiqun Lin , thanks for the patch! I added you as a contributor on JIRA so you can be assigned JIRAs now. One tiny nit, do you mind appending the ]\n string on a new line? That helps future-proof in case we add more options later. Otherwise +1.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Yiqun Lin
        thanks for the contribution. For completeness, could you also update the commands in HDFSCommands.md?

        Show
        jojochuang Wei-Chiu Chuang added a comment - Yiqun Lin thanks for the contribution. For completeness, could you also update the commands in HDFSCommands.md?
        Hide
        linyiqun Yiqun Lin added a comment -

        Hi, Andrew Wang, thank you so much for adding me as a contributor.And thanks Wei-Chiu Chuang,Andrew Wang for review. Update the patch for addressing the comments.

        Show
        linyiqun Yiqun Lin added a comment - Hi, Andrew Wang , thank you so much for adding me as a contributor.And thanks Wei-Chiu Chuang , Andrew Wang for review. Update the patch for addressing the comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 59s trunk passed
        +1 compile 0m 44s trunk passed with JDK v1.8.0_91
        +1 compile 0m 48s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 5s trunk passed
        +1 javadoc 1m 12s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 50s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.8.0_91
        +1 javac 0m 46s the patch passed
        +1 compile 0m 44s the patch passed with JDK v1.7.0_95
        +1 javac 0m 44s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 16s the patch passed
        +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 51s the patch passed with JDK v1.7.0_95
        -1 unit 92m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 72m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        193m 38s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.TestAsyncDFSRename
        JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
          hadoop.hdfs.TestAsyncDFSRename



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804156/HDFS-10404.002.patch
        JIRA Issue HDFS-10404
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 27e529e56c17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ad94411
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15444/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15444/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 59s trunk passed +1 compile 0m 44s trunk passed with JDK v1.8.0_91 +1 compile 0m 48s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 5s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 50s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 51s the patch passed +1 compile 0m 46s the patch passed with JDK v1.8.0_91 +1 javac 0m 46s the patch passed +1 compile 0m 44s the patch passed with JDK v1.7.0_95 +1 javac 0m 44s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 51s the patch passed with JDK v1.7.0_95 -1 unit 92m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 72m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 193m 38s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestAsyncDFSRename JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics   hadoop.hdfs.TestAsyncDFSRename Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804156/HDFS-10404.002.patch JIRA Issue HDFS-10404 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 27e529e56c17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ad94411 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15444/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15444/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15444/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Yiqun Lin.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Yiqun Lin .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9803 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9803/)
        HDFS-10404. Fix formatting of CacheAdmin command usage help text (Yiqun (cmccabe: rev 7cd5ae62f639a857f24f5463f2aefc099c631a14)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/CentralizedCacheManagement.md
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9803 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9803/ ) HDFS-10404 . Fix formatting of CacheAdmin command usage help text (Yiqun (cmccabe: rev 7cd5ae62f639a857f24f5463f2aefc099c631a14) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/CentralizedCacheManagement.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Colin P. McCabe for commit!

        Show
        linyiqun Yiqun Lin added a comment - Thanks Colin P. McCabe for commit!

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development