Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10375

Remove redundant TestMiniDFSCluster.testDualClusters

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Remove redundent TestMiniDFSCluster.testDualClusters to save time.

      Description

      Unit test TestMiniDFSCluster.testDualClusters is redundant because testClusterWithoutSystemProperties already proves cluster.getDataDirectory() == getProp(HDFS_MINIDFS_BASEDIR) + "/data". This unit test sets HDFS_MINIDFS_BASEDIR to 2 different values and brings up 2 clusters, of course they will have different data directory.

      Remove it to save the time to bring up 2 mini clusters.

      1. HDFS-10375.002.patch
        2 kB
        Jiayi Zhou
      2. HDFS-10375.003.patch
        2 kB
        Jiayi Zhou
      3. HDFS-10375.004.patch
        3 kB
        Jiayi Zhou

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        +1(non-binding) after reverting the change in ValueQueue.java. File a new jira to fix that typo.

        Show
        jzhuge John Zhuge added a comment - +1(non-binding) after reverting the change in ValueQueue.java . File a new jira to fix that typo.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s HDFS-10375 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808433/HDFS-10375.001.patch
        JIRA Issue HDFS-10375
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15663/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HDFS-10375 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808433/HDFS-10375.001.patch JIRA Issue HDFS-10375 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15663/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Jiayi Zhou for contributing the patches. There is no need to remove the the previous patch before adding a new one.

        +1(non-binding) LGTM.

        Show
        jzhuge John Zhuge added a comment - Thanks Jiayi Zhou for contributing the patches. There is no need to remove the the previous patch before adding a new one. +1(non-binding) LGTM.
        Hide
        clouderajiayi Jiayi Zhou added a comment -

        So I only need to git commit again on my local machine?

        Show
        clouderajiayi Jiayi Zhou added a comment - So I only need to git commit again on my local machine?
        Hide
        jzhuge John Zhuge added a comment -

        You can upload multiple patches as long as they are all numbered sequentially which you did.

        On you local machines, just run git commit --amend then git format-patch --stdout HEAD~ > HDFS-10375.NNN.patch (increment NNN each time).

        Show
        jzhuge John Zhuge added a comment - You can upload multiple patches as long as they are all numbered sequentially which you did. On you local machines, just run git commit --amend then git format-patch --stdout HEAD~ > HDFS-10375 .NNN.patch (increment NNN each time).
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 9s trunk passed
        +1 compile 1m 4s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 12s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 1m 16s trunk passed
        -1 mvninstall 0m 28s hadoop-hdfs in the patch failed.
        -1 compile 0m 28s hadoop-hdfs in the patch failed.
        -1 javac 0m 28s hadoop-hdfs in the patch failed.
        -1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 0 unchanged - 6 fixed = 3 total (was 6)
        -1 mvnsite 0m 30s hadoop-hdfs in the patch failed.
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 11s hadoop-hdfs in the patch failed.
        +1 javadoc 1m 4s the patch passed
        -1 unit 0m 29s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        19m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808441/HDFS-10375.002.patch
        JIRA Issue HDFS-10375
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8f1853535fc5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 35f255b
        Default Java 1.8.0_91
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15664/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15664/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 9s trunk passed +1 compile 1m 4s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 16s trunk passed -1 mvninstall 0m 28s hadoop-hdfs in the patch failed. -1 compile 0m 28s hadoop-hdfs in the patch failed. -1 javac 0m 28s hadoop-hdfs in the patch failed. -1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 0 unchanged - 6 fixed = 3 total (was 6) -1 mvnsite 0m 30s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 11s hadoop-hdfs in the patch failed. +1 javadoc 1m 4s the patch passed -1 unit 0m 29s hadoop-hdfs in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 19m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808441/HDFS-10375.002.patch JIRA Issue HDFS-10375 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8f1853535fc5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 35f255b Default Java 1.8.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15664/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15664/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15664/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        clouderajiayi Jiayi Zhou added a comment -

        Hi John, how can I run this Hadoop QA again? I think I have fixed the problem and it should work properly now.

        Show
        clouderajiayi Jiayi Zhou added a comment - Hi John, how can I run this Hadoop QA again? I think I have fixed the problem and it should work properly now.
        Hide
        jzhuge John Zhuge added a comment - - edited

        Jiayi Zhou The patch 003 is wrong because it is incremental to 002. It should be a diff from the trunk. It seems your local branch is ahead of trunk by 2 commits : the older one for patch 002 and the newer one for patch 003. Please merge them into 1 commit by running git rebase -i HEAD~2 (fixup the newer commit) then run format-patch again.

        Show
        jzhuge John Zhuge added a comment - - edited Jiayi Zhou The patch 003 is wrong because it is incremental to 002. It should be a diff from the trunk. It seems your local branch is ahead of trunk by 2 commits : the older one for patch 002 and the newer one for patch 003. Please merge them into 1 commit by running git rebase -i HEAD~2 (fixup the newer commit) then run format-patch again.
        Hide
        clouderajiayi Jiayi Zhou added a comment - - edited

        I've merged them into 1 commit now. How about this new patch 003?

        Show
        clouderajiayi Jiayi Zhou added a comment - - edited I've merged them into 1 commit now. How about this new patch 003?
        Hide
        jzhuge John Zhuge added a comment -

        Looks good. BTW, it shoulda been named 004.

        Show
        jzhuge John Zhuge added a comment - Looks good. BTW, it shoulda been named 004.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 8s trunk passed
        +1 compile 0m 54s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 51s trunk passed
        +1 javadoc 1m 8s trunk passed
        +1 mvninstall 0m 54s the patch passed
        +1 compile 0m 48s the patch passed
        +1 javac 0m 48s the patch passed
        -1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 56s the patch passed
        +1 javadoc 1m 8s the patch passed
        +1 unit 58m 35s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        79m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808496/HDFS-10375.003.patch
        JIRA Issue HDFS-10375
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f3161f01f9c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a3f78d8
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15670/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15670/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15670/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 8s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 1m 8s trunk passed +1 mvninstall 0m 54s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed -1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 58m 35s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 79m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808496/HDFS-10375.003.patch JIRA Issue HDFS-10375 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f3161f01f9c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a3f78d8 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15670/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15670/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15670/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        004 patch LGTM, will commit once Jenkins comes back clean. Thanks for the patch Jiayi and John for doing reviews.

        Show
        andrew.wang Andrew Wang added a comment - 004 patch LGTM, will commit once Jenkins comes back clean. Thanks for the patch Jiayi and John for doing reviews.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 46s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 40s trunk passed
        +1 compile 0m 47s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 1m 45s trunk passed
        +1 javadoc 1m 5s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 45s the patch passed
        +1 javac 0m 45s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 49s the patch passed
        +1 javadoc 1m 4s the patch passed
        +1 unit 58m 24s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        78m 23s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808511/HDFS-10375.004.patch
        JIRA Issue HDFS-10375
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ef434b3411f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6de9213
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15672/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15672/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 46s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 40s trunk passed +1 compile 0m 47s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 1m 5s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 1m 4s the patch passed +1 unit 58m 24s hadoop-hdfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 78m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808511/HDFS-10375.004.patch JIRA Issue HDFS-10375 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ef434b3411f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6de9213 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15672/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15672/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Backported through 2.8. Thanks Jiayi for the patch, and John for originally reporting this issue and reviewing!

        Show
        andrew.wang Andrew Wang added a comment - Backported through 2.8. Thanks Jiayi for the patch, and John for originally reporting this issue and reviewing!
        Hide
        andrew.wang Andrew Wang added a comment -

        For future git log greppers, I forgot to include the JIRA #. My bad.

        Show
        andrew.wang Andrew Wang added a comment - For future git log greppers, I forgot to include the JIRA #. My bad.

          People

          • Assignee:
            clouderajiayi Jiayi Zhou
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development