Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10337

OfflineEditsViewer stats option should print 0 instead of null for the count of operations

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      The output of "hdfs oev -p stats" has changed. The option prints 0 instead of null for the count of the operations that have never been executed.
    1. HDFS-10337.001.patch
      1.0 kB
      Yiqun Lin
    2. HDFS-10337.002.patch
      1 kB
      Yiqun Lin
    3. HDFS-10337.003.patch
      3 kB
      Yiqun Lin

      Activity

      Hide
      linyiqun Yiqun Lin added a comment -

      HI, Akira Ajisaka, I attach a patch for this, can this patch satisfied your issue?

      Show
      linyiqun Yiqun Lin added a comment - HI, Akira Ajisaka , I attach a patch for this, can this patch satisfied your issue?
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      -1 docker 0m 5s Docker failed to build yetus/hadoop:7b1c37a.



      Subsystem Report/Notes
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801167/HDFS-10337.001.patch
      JIRA Issue HDFS-10337
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15312/console
      Powered by Apache Yetus 0.2.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 5s Docker failed to build yetus/hadoop:7b1c37a. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801167/HDFS-10337.001.patch JIRA Issue HDFS-10337 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15312/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
      Hide
      ajisakaa Akira Ajisaka added a comment -

      Thank you for your patch. Yes, it fixes this issue. In addition, would you use StringBuilder instead of StringBuffer? I'm +1 if that is addressed.

      Show
      ajisakaa Akira Ajisaka added a comment - Thank you for your patch. Yes, it fixes this issue. In addition, would you use StringBuilder instead of StringBuffer? I'm +1 if that is addressed.
      Hide
      linyiqun Yiqun Lin added a comment -

      Thanks for the quick review. Update the latest patch for addressing the comment.

      Show
      linyiqun Yiqun Lin added a comment - Thanks for the quick review. Update the latest patch for addressing the comment.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 7m 31s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 8m 43s trunk passed
      +1 compile 1m 12s trunk passed with JDK v1.8.0_92
      +1 compile 0m 57s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 28s trunk passed
      +1 mvnsite 1m 14s trunk passed
      +1 mvneclipse 0m 22s trunk passed
      +1 findbugs 2m 35s trunk passed
      +1 javadoc 1m 33s trunk passed with JDK v1.8.0_92
      +1 javadoc 2m 29s trunk passed with JDK v1.7.0_95
      +1 mvninstall 1m 3s the patch passed
      +1 compile 1m 6s the patch passed with JDK v1.8.0_92
      +1 javac 1m 6s the patch passed
      +1 compile 0m 57s the patch passed with JDK v1.7.0_95
      +1 javac 0m 57s the patch passed
      -1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 11 unchanged - 1 fixed = 12 total (was 12)
      +1 mvnsite 1m 7s the patch passed
      +1 mvneclipse 0m 15s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      -1 findbugs 2m 46s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
      +1 javadoc 1m 31s the patch passed with JDK v1.8.0_92
      +1 javadoc 2m 18s the patch passed with JDK v1.7.0_95
      -1 unit 113m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_92.
      -1 unit 85m 21s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 26s Patch does not generate ASF License warnings.
      241m 16s



      Reason Tests
      FindBugs module:hadoop-hdfs-project/hadoop-hdfs
        Boxed value is unboxed and then immediately reboxed in org.apache.hadoop.hdfs.tools.offlineEditsViewer.StatisticsEditsVisitor.getStatisticsString() At StatisticsEditsVisitor.java:then immediately reboxed in org.apache.hadoop.hdfs.tools.offlineEditsViewer.StatisticsEditsVisitor.getStatisticsString() At StatisticsEditsVisitor.java:[line 116]
      JDK v1.8.0_92 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID
        hadoop.hdfs.server.namenode.ha.TestEditLogTailer
        hadoop.hdfs.server.blockmanagement.TestBlockManager
        hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
        hadoop.hdfs.security.TestDelegationTokenForProxyUser
        hadoop.hdfs.TestLocalDFS
        hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
        hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
        hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
        hadoop.hdfs.server.datanode.TestDirectoryScanner
      JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestXAttrConfigFlag
      JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestPersistBlocks
        hadoop.hdfs.TestErasureCodeBenchmarkThroughput
        hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
        hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:7b1c37a
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801179/HDFS-10337.002.patch
      JIRA Issue HDFS-10337
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 859223a84721 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 6f26b66
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
      findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
      unit https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt
      unit https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15313/testReport/
      modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15313/console
      Powered by Apache Yetus 0.2.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 7m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 43s trunk passed +1 compile 1m 12s trunk passed with JDK v1.8.0_92 +1 compile 0m 57s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 2m 35s trunk passed +1 javadoc 1m 33s trunk passed with JDK v1.8.0_92 +1 javadoc 2m 29s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 3s the patch passed +1 compile 1m 6s the patch passed with JDK v1.8.0_92 +1 javac 1m 6s the patch passed +1 compile 0m 57s the patch passed with JDK v1.7.0_95 +1 javac 0m 57s the patch passed -1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 11 unchanged - 1 fixed = 12 total (was 12) +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 2m 46s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 31s the patch passed with JDK v1.8.0_92 +1 javadoc 2m 18s the patch passed with JDK v1.7.0_95 -1 unit 113m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_92. -1 unit 85m 21s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 241m 16s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Boxed value is unboxed and then immediately reboxed in org.apache.hadoop.hdfs.tools.offlineEditsViewer.StatisticsEditsVisitor.getStatisticsString() At StatisticsEditsVisitor.java:then immediately reboxed in org.apache.hadoop.hdfs.tools.offlineEditsViewer.StatisticsEditsVisitor.getStatisticsString() At StatisticsEditsVisitor.java: [line 116] JDK v1.8.0_92 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestXAttrConfigFlag JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:7b1c37a JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801179/HDFS-10337.002.patch JIRA Issue HDFS-10337 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 859223a84721 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6f26b66 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15313/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15313/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15313/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
      Hide
      ajisakaa Akira Ajisaka added a comment -

      Thanks Yiqun Lin for updating the patch. Three comments:

      • Would you fix the findbugs warning?
                count == null ? 0 : count));
        

        According to https://sourceforge.net/p/findbugs/bugs/1184/, if count is not null, count is unboxed and then immediately reboxed. We can fix it by

                count == null ? Long.valueOf(0L) : count));
        
      • Would you fix the checkstyle warning?
      • Would you add a regression test for this issue?
      Show
      ajisakaa Akira Ajisaka added a comment - Thanks Yiqun Lin for updating the patch. Three comments: Would you fix the findbugs warning? count == null ? 0 : count)); According to https://sourceforge.net/p/findbugs/bugs/1184/ , if count is not null, count is unboxed and then immediately reboxed. We can fix it by count == null ? Long .valueOf(0L) : count)); Would you fix the checkstyle warning? Would you add a regression test for this issue?
      Hide
      linyiqun Yiqun Lin added a comment -

      Thanks for review again. Update the patch for addressing the comments.

      Show
      linyiqun Yiqun Lin added a comment - Thanks for review again. Update the patch for addressing the comments.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 12s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
      +1 mvninstall 6m 48s trunk passed
      +1 compile 0m 40s trunk passed with JDK v1.8.0_91
      +1 compile 0m 42s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 21s trunk passed
      +1 mvnsite 0m 52s trunk passed
      +1 mvneclipse 0m 14s trunk passed
      +1 findbugs 1m 57s trunk passed
      +1 javadoc 1m 8s trunk passed with JDK v1.8.0_91
      +1 javadoc 1m 48s trunk passed with JDK v1.7.0_95
      +1 mvninstall 0m 46s the patch passed
      +1 compile 0m 38s the patch passed with JDK v1.8.0_91
      +1 javac 0m 38s the patch passed
      +1 compile 0m 38s the patch passed with JDK v1.7.0_95
      +1 javac 0m 38s the patch passed
      +1 checkstyle 0m 17s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 8 unchanged - 4 fixed = 8 total (was 12)
      +1 mvnsite 0m 49s the patch passed
      +1 mvneclipse 0m 12s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 2m 9s the patch passed
      +1 javadoc 1m 4s the patch passed with JDK v1.8.0_91
      +1 javadoc 1m 41s the patch passed with JDK v1.7.0_95
      -1 unit 59m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
      -1 unit 54m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 24s Patch does not generate ASF License warnings.
      139m 36s



      Reason Tests
      JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
      JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestFileAppend
        hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:cf2ee45
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802588/HDFS-10337.003.patch
      JIRA Issue HDFS-10337
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 18bc7855ad32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 2835f14
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      unit https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
      unit https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15382/testReport/
      modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15382/console
      Powered by Apache Yetus 0.2.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 48s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_91 +1 compile 0m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 48s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_91 +1 javac 0m 38s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed +1 checkstyle 0m 17s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 8 unchanged - 4 fixed = 8 total (was 12) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 41s the patch passed with JDK v1.7.0_95 -1 unit 59m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 54m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 139m 36s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802588/HDFS-10337.003.patch JIRA Issue HDFS-10337 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 18bc7855ad32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2835f14 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15382/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15382/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15382/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
      Hide
      ajisakaa Akira Ajisaka added a comment -

      +1, the test failure is unrelated and it is tracked by HDFS-10372.

      Show
      ajisakaa Akira Ajisaka added a comment - +1, the test failure is unrelated and it is tracked by HDFS-10372 .
      Hide
      ajisakaa Akira Ajisaka added a comment -

      Committed to trunk. Thanks Yiqun Lin for the contribution!

      Show
      ajisakaa Akira Ajisaka added a comment - Committed to trunk. Thanks Yiqun Lin for the contribution!
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #9736 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9736/)
      HDFS-10337. OfflineEditsViewer stats option should print 0 instead of (aajisaka: rev 411fb4b2b792ad71722f47b61a1c6745e61bd5e5)

      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/StatisticsEditsVisitor.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9736 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9736/ ) HDFS-10337 . OfflineEditsViewer stats option should print 0 instead of (aajisaka: rev 411fb4b2b792ad71722f47b61a1c6745e61bd5e5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/StatisticsEditsVisitor.java
      Hide
      linyiqun Yiqun Lin added a comment -

      Thanks Akira Ajisaka for commit!

      Show
      linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for commit!

        People

        • Assignee:
          linyiqun Yiqun Lin
          Reporter:
          ajisakaa Akira Ajisaka
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development