Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10324

Trash directory in an encryption zone should be pre-created with correct permissions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: encryption
    • Labels:
      None
    • Environment:

      CDH5.7.0

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      HDFS will create a ".Trash" subdirectory when creating a new encryption zone to support soft delete for files deleted within the encryption zone. A new "crypto -provisionTrash" command has been introduced to provision trash directories for encryption zones created with Apache Hadoop minor releases prior to 2.8.0.
      Show
      HDFS will create a ".Trash" subdirectory when creating a new encryption zone to support soft delete for files deleted within the encryption zone. A new "crypto -provisionTrash" command has been introduced to provision trash directories for encryption zones created with Apache Hadoop minor releases prior to 2.8.0.

      Description

      We encountered a bug in HDFS-8831:
      After HDFS-8831, a deleted file in an encryption zone is moved to a .Trash subdirectory within the encryption zone.

      However, if this .Trash subdirectory is not created beforehand, it will be created and owned by the first user who deleted a file, with permission drwx------. This creates a serious bug because any other non-privileged user will not be able to delete any files within the encryption zone, because they do not have the permission to move directories to the trash directory.

      We should fix this bug, by pre-creating the .Trash directory with sticky bit.

      1. HDFS-10324.001.patch
        6 kB
        Wei-Chiu Chuang
      2. HDFS-10324.002.patch
        10 kB
        Wei-Chiu Chuang
      3. HDFS-10324.003.patch
        17 kB
        Wei-Chiu Chuang
      4. HDFS-10324.004.patch
        21 kB
        Wei-Chiu Chuang
      5. HDFS-10324.005.patch
        26 kB
        Wei-Chiu Chuang
      6. HDFS-10324.006.patch
        57 kB
        Wei-Chiu Chuang
      7. HDFS-10324.007.patch
        58 kB
        Wei-Chiu Chuang
      8. HDFS-10324.008.patch
        58 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Attach my patch v001.

          I am not entirely sure if this should be part of NameNode createEncryptionZone() operation (which is atomic), or be fixed by a dfsclient which creates .Trash dirctory after it creates an EZ. This first patch takes the latter approach. I feel the doing it in NN is better, but I'm a bit afraid of changing anything within NameNode namespace.

          Also, attached a test case which illustrates how the bug can be reproduced.

          Xiaoyu Yao Zhe Zhang Andrew Wang Arpit Agarwal could you take a look? Thanks.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Attach my patch v001. I am not entirely sure if this should be part of NameNode createEncryptionZone() operation (which is atomic), or be fixed by a dfsclient which creates .Trash dirctory after it creates an EZ. This first patch takes the latter approach. I feel the doing it in NN is better, but I'm a bit afraid of changing anything within NameNode namespace. Also, attached a test case which illustrates how the bug can be reproduced. Xiaoyu Yao Zhe Zhang Andrew Wang Arpit Agarwal could you take a look? Thanks.
          Hide
          andrew.wang Andrew Wang added a comment -

          Not sure about this one. It doesn't handle existing EZs from an upgrade. Doing two ops in one at the DFS layer, non-atomically, without an opt-out or configuration, also doesn't feel great. It'd be a warty API.

          Maybe this behavior should be done in the hdfs crypto command instead, with a new cmdline option?

          Interested to hear what others think too.

          Show
          andrew.wang Andrew Wang added a comment - Not sure about this one. It doesn't handle existing EZs from an upgrade. Doing two ops in one at the DFS layer, non-atomically, without an opt-out or configuration, also doesn't feel great. It'd be a warty API. Maybe this behavior should be done in the hdfs crypto command instead, with a new cmdline option? Interested to hear what others think too.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Wei-Chiu Chuang for reporting the issue and posting the patch and Andrew Wang for the comments.

          Trash is mostly a client side feature. Mix it with createEncryptionZone API is not an ideal solution.

          Wei-Chiu Chuang, have you try handle create of trash root in TrashPolicyDefault#moveToTrash upon first deletion of file in the encryption zone. The code below is just to illustrate the idea. It needs additional tweak to work around the default UMASK enforced by FileSystem.mkdir() to have the FsAction.All for g/o and sticky bit set correctly. DistributedFileSystem#primitiveMkdir fits better here but is currently not exposed to FileSystem interface.

          private static final FsPermission ENCRYPTED_TRASH_ROOT_PERMISSION =
                new FsPermission(FsAction.ALL, FsAction.ALL, FsAction.ALL, true);
          ...
              Path trashRootParent = trashRoot.getParent();
              if (!fs.exists(trashRootParent) &&
                  fs.getFileStatus(trashRootParent.getParent()).isEncrypted()) {
                fs.mkdirs(trashRootParent, ENCRYPTED_TRASH_ROOT_PERMISSION);
              }
          

          Andrew Wang's suggestion to handle .Trash permission for encryption zone via hdfs crypto command looks fine but has a similar upgrade issue.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Wei-Chiu Chuang for reporting the issue and posting the patch and Andrew Wang for the comments. Trash is mostly a client side feature. Mix it with createEncryptionZone API is not an ideal solution. Wei-Chiu Chuang , have you try handle create of trash root in TrashPolicyDefault#moveToTrash upon first deletion of file in the encryption zone. The code below is just to illustrate the idea. It needs additional tweak to work around the default UMASK enforced by FileSystem.mkdir() to have the FsAction.All for g/o and sticky bit set correctly. DistributedFileSystem#primitiveMkdir fits better here but is currently not exposed to FileSystem interface. private static final FsPermission ENCRYPTED_TRASH_ROOT_PERMISSION = new FsPermission(FsAction.ALL, FsAction.ALL, FsAction.ALL, true ); ... Path trashRootParent = trashRoot.getParent(); if (!fs.exists(trashRootParent) && fs.getFileStatus(trashRootParent.getParent()).isEncrypted()) { fs.mkdirs(trashRootParent, ENCRYPTED_TRASH_ROOT_PERMISSION); } Andrew Wang 's suggestion to handle .Trash permission for encryption zone via hdfs crypto command looks fine but has a similar upgrade issue.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Cool! Thanks Xiaoyu. I initially had the similar fix, but I did not know how to determine if the path is in encryption zone. This is a much better fix than I posted.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Cool! Thanks Xiaoyu. I initially had the similar fix, but I did not know how to determine if the path is in encryption zone. This is a much better fix than I posted.
          Hide
          andrew.wang Andrew Wang added a comment -

          Does this work when the EZ root is not writable by the unprivileged user? e.g. if / is an EZ and the weichiu user deletes a file, weichiu won't have permissions to create /.Trash/.

          hdfs crypto and createEZ can only be used by the superuser, so creating .Trash there always works.

          Show
          andrew.wang Andrew Wang added a comment - Does this work when the EZ root is not writable by the unprivileged user? e.g. if / is an EZ and the weichiu user deletes a file, weichiu won't have permissions to create /.Trash/ . hdfs crypto and createEZ can only be used by the superuser, so creating .Trash there always works.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Also, if a directory is initialized as an EZ and a .Trash directory is created at the same time, the user won't be able to delete the EZ directory unless hdfs dfs -rm --ignore-fail-on-non-empty is used. Would this be considered a change of behavior?

          Show
          jojochuang Wei-Chiu Chuang added a comment - Also, if a directory is initialized as an EZ and a .Trash directory is created at the same time, the user won't be able to delete the EZ directory unless hdfs dfs -rm --ignore-fail-on-non-empty is used. Would this be considered a change of behavior?
          Hide
          andrew.wang Andrew Wang added a comment -

          Yes, that's why I suggested adding a new flag on hdfs crypto createZone to also create the Trash directory.

          Show
          andrew.wang Andrew Wang added a comment - Yes, that's why I suggested adding a new flag on hdfs crypto createZone to also create the Trash directory.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          What about this one:
          The second patch adds a configuration property fs.trash.encrypted.permission, which is "777" (globally readable, writable and executable) to specify the permission of trash directory when an encryption zone is created. A sticky bit is automatically added when calculating the final permission.

          Administrator can optionally override the default permission using -trashperm switch in a hdfs crypto command.

          Show
          jojochuang Wei-Chiu Chuang added a comment - What about this one: The second patch adds a configuration property fs.trash.encrypted.permission , which is "777" (globally readable, writable and executable) to specify the permission of trash directory when an encryption zone is created. A sticky bit is automatically added when calculating the final permission. Administrator can optionally override the default permission using -trashperm switch in a hdfs crypto command.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Wei-Chiu Chuang for updating the patch. Here are a few comments:

          1. Can we assume 1777 for the .Trash directory for an encryption zone without an additional configuration key fs.trash.encrypted.permission?
          I don't see a clear use case that requires customization of the .Trash permission.

          2. How to we handle upgrade?
          For newly created zone, .Trash will always be implicitly added without additional parameter as patch 002 does.
          For zone without .Trash (e.g., zone upgraded from previous version or .Trash got deleted by accident) or correct .Trash permission (e.g., permission modified by accident), maybe we can add a new crypto admin command "hdfs crypto -provisiontrash" that will fix them up. What do you think?

          Show
          xyao Xiaoyu Yao added a comment - Thanks Wei-Chiu Chuang for updating the patch. Here are a few comments: 1. Can we assume 1777 for the .Trash directory for an encryption zone without an additional configuration key fs.trash.encrypted.permission? I don't see a clear use case that requires customization of the .Trash permission. 2. How to we handle upgrade? For newly created zone, .Trash will always be implicitly added without additional parameter as patch 002 does. For zone without .Trash (e.g., zone upgraded from previous version or .Trash got deleted by accident) or correct .Trash permission (e.g., permission modified by accident), maybe we can add a new crypto admin command "hdfs crypto -provisiontrash" that will fix them up. What do you think?
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Xiaoyu Yao for the comments. Regarding #1, I don't have a strong opinion whether to keep it configurable or not.

          I am not so sure about #2 though. Essentially, adding a trash directory is equivalent to hdfs dfs -mkdir /ez/tmp; hdfs dfs -chmod 1777 /ez/tmp, and an extra command seems redundant to me. But if this command is designed to handled more complex cases, then I am certainly open to that.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Xiaoyu Yao for the comments. Regarding #1, I don't have a strong opinion whether to keep it configurable or not. I am not so sure about #2 though. Essentially, adding a trash directory is equivalent to hdfs dfs -mkdir /ez/tmp; hdfs dfs -chmod 1777 /ez/tmp , and an extra command seems redundant to me. But if this command is designed to handled more complex cases, then I am certainly open to that.
          Hide
          xyao Xiaoyu Yao added a comment -

          Wei-Chiu Chuang, I mentioned #2 because Trash is client feature that used to not require file system operation like hdfs dfs -mkdir /ez/tmp; hdfs dfs -chmod 1777 /ez/tmp for its operation. Since this is encryption zone specific, it might be easier to have a single crytoadmin cmd to handle it.

          Show
          xyao Xiaoyu Yao added a comment - Wei-Chiu Chuang , I mentioned #2 because Trash is client feature that used to not require file system operation like hdfs dfs -mkdir /ez/tmp; hdfs dfs -chmod 1777 /ez/tmp for its operation. Since this is encryption zone specific, it might be easier to have a single crytoadmin cmd to handle it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 40s trunk passed
          +1 compile 6m 4s trunk passed with JDK v1.8.0_77
          +1 compile 6m 45s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 28s trunk passed
          +1 javadoc 2m 0s trunk passed with JDK v1.8.0_77
          +1 javadoc 2m 52s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          +1 compile 6m 6s the patch passed with JDK v1.8.0_77
          +1 javac 6m 6s the patch passed
          +1 compile 6m 40s the patch passed with JDK v1.7.0_95
          +1 javac 6m 40s the patch passed
          -1 checkstyle 1m 6s root: patch generated 2 new + 194 unchanged - 0 fixed = 196 total (was 194)
          +1 mvnsite 1m 46s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 3m 58s the patch passed
          +1 javadoc 2m 2s the patch passed with JDK v1.8.0_77
          +1 javadoc 2m 59s the patch passed with JDK v1.7.0_95
          +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.8.0_77.
          -1 unit 61m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          +1 unit 8m 9s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 59m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          196m 19s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestDFSShell
            hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
            hadoop.cli.TestCryptoAdminCLI
            hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.cli.TestCryptoAdminCLI
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800523/HDFS-10324.002.patch
          JIRA Issue HDFS-10324
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 3b892864f4cb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bec5b4c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15276/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15276/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 6m 4s trunk passed with JDK v1.8.0_77 +1 compile 6m 45s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 5s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 28s trunk passed +1 javadoc 2m 0s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 52s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 6m 6s the patch passed with JDK v1.8.0_77 +1 javac 6m 6s the patch passed +1 compile 6m 40s the patch passed with JDK v1.7.0_95 +1 javac 6m 40s the patch passed -1 checkstyle 1m 6s root: patch generated 2 new + 194 unchanged - 0 fixed = 196 total (was 194) +1 mvnsite 1m 46s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 58s the patch passed +1 javadoc 2m 2s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 59s the patch passed with JDK v1.7.0_95 +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.8.0_77. -1 unit 61m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 8m 9s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 59m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 196m 19s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestDFSShell   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.balancer.TestBalancer   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800523/HDFS-10324.002.patch JIRA Issue HDFS-10324 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 3b892864f4cb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bec5b4c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15276/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15276/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          I'm somewhat concerned about the compatibility issues of automatically creating the trash dir on createZone. It means a simple workflow like mkdir /ez; createZone /ez; rmdir /ez won't work anymore. It's also true though that this won't be that common, and if we don't create the .Trash dir, trash won't work out-of-the-box.

          So overall I like Xiaoyu's proposal, except I would change #2 to only create/chmod if the .Trash dir doesn't exist. The trash might already be setup in a specific way by the admin. The error message can explain the manual steps, since it's not that complicated.

          We can also improve the error message when EZ trash fails to refer users to the new "hdfs crypto -provisionTrash" command. Right now the error message is rather non-specific.

          Show
          andrew.wang Andrew Wang added a comment - I'm somewhat concerned about the compatibility issues of automatically creating the trash dir on createZone . It means a simple workflow like mkdir /ez; createZone /ez; rmdir /ez won't work anymore. It's also true though that this won't be that common, and if we don't create the .Trash dir, trash won't work out-of-the-box. So overall I like Xiaoyu's proposal, except I would change #2 to only create/chmod if the .Trash dir doesn't exist. The trash might already be setup in a specific way by the admin. The error message can explain the manual steps, since it's not that complicated. We can also improve the error message when EZ trash fails to refer users to the new "hdfs crypto -provisionTrash" command. Right now the error message is rather non-specific.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Andrew Wang for the comments. I agree it is important to get trash work out-of-box and the error message improvements.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Andrew Wang for the comments. I agree it is important to get trash work out-of-box and the error message improvements.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Andrew Wang. I think your proposal is a reasonable plan, and the new patch should do what you proposed.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Andrew Wang . I think your proposal is a reasonable plan, and the new patch should do what you proposed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 27s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvninstall 6m 51s trunk passed
          +1 compile 5m 52s trunk passed with JDK v1.8.0_92
          +1 compile 6m 46s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 32s trunk passed
          +1 javadoc 1m 58s trunk passed with JDK v1.8.0_92
          +1 javadoc 2m 50s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 28s the patch passed
          +1 compile 5m 52s the patch passed with JDK v1.8.0_92
          +1 javac 5m 52s the patch passed
          +1 compile 6m 50s the patch passed with JDK v1.7.0_95
          +1 javac 6m 50s the patch passed
          +1 checkstyle 1m 4s root: patch generated 0 new + 12 unchanged - 2 fixed = 12 total (was 14)
          +1 mvnsite 1m 52s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 35s the patch passed
          +1 javadoc 2m 57s the patch passed with JDK v1.8.0_92
          +1 javadoc 2m 58s the patch passed with JDK v1.7.0_95
          +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.8.0_92.
          -1 unit 56m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_92.
          +1 unit 7m 20s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 55m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          199m 23s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800694/HDFS-10324.003.patch
          JIRA Issue HDFS-10324
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 5c8aef06a536 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8eadd71
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15286/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15286/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_92 +1 compile 6m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 32s trunk passed +1 javadoc 1m 58s trunk passed with JDK v1.8.0_92 +1 javadoc 2m 50s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 5m 52s the patch passed with JDK v1.8.0_92 +1 javac 5m 52s the patch passed +1 compile 6m 50s the patch passed with JDK v1.7.0_95 +1 javac 6m 50s the patch passed +1 checkstyle 1m 4s root: patch generated 0 new + 12 unchanged - 2 fixed = 12 total (was 14) +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 35s the patch passed +1 javadoc 2m 57s the patch passed with JDK v1.8.0_92 +1 javadoc 2m 58s the patch passed with JDK v1.7.0_95 +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.8.0_92. -1 unit 56m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_92. +1 unit 7m 20s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 55m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 199m 23s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800694/HDFS-10324.003.patch JIRA Issue HDFS-10324 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 5c8aef06a536 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8eadd71 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15286/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15286/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Failed tests are known, flaky tests reported in HDFS-10260 and HDFS-10169.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Failed tests are known, flaky tests reported in HDFS-10260 and HDFS-10169 .
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Wei-Chiu Chuang for update the patch. The patch v003 looks pretty good to me.

          One last comment: Do you want to update HdfsAdmin API/document for HdfsAdmin#createEncryptionZone() as well? Though I only find callers of this public API from unit tests, it seems to be a good place to implement permission change logic based on the class description below.

          HDFSAdmin.java
           * The public API for performing administrative functions on HDFS. Those writing
           * applications against HDFS should prefer this interface to directly accessing
           * functionality in DistributedFileSystem or DFSClient.
          

          If we decide not to change the Admin API, I still suggest an update to Javadocs of HdfsAdmin#createEncryptionZone() with the necessary permission changes for Trash of encryption zone support.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Wei-Chiu Chuang for update the patch. The patch v003 looks pretty good to me. One last comment: Do you want to update HdfsAdmin API/document for HdfsAdmin#createEncryptionZone() as well? Though I only find callers of this public API from unit tests, it seems to be a good place to implement permission change logic based on the class description below. HDFSAdmin.java * The public API for performing administrative functions on HDFS. Those writing * applications against HDFS should prefer this interface to directly accessing * functionality in DistributedFileSystem or DFSClient. If we decide not to change the Admin API, I still suggest an update to Javadocs of HdfsAdmin#createEncryptionZone() with the necessary permission changes for Trash of encryption zone support.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          It is true that this API is used only in unit tests in Hadoop, but downstream project might use it. What do we typically consider when changing public API?

          Show
          jojochuang Wei-Chiu Chuang added a comment - It is true that this API is used only in unit tests in Hadoop, but downstream project might use it. What do we typically consider when changing public API?
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for the discussion all, and Wei-Chiu for the patch.

          HdfsAdmin is a public API, so I don't think we should modify createZone there to also provisionTrash. It'd mean we have no way of creating a zone without a Trash directory (the old behavior) and also gets into my earlier concerns about atomicity.

          We can revisit this later if we find we need Java API access to provisionTrash, but that should be rare since you can just do it with mkdir and chmod.

          Review comments:

          • Shall we error if provisionTrash isn't called on an EZ root? That more clearly reflects that the Trash directory is an EZ-level construct.
          • If a Trash directory already exists, it might already be set up properly, so it seems harsh to tell the user to rename it. Instead, how about e.g. "Will not provision new trash directory for encryption zone /ez/, path already exists."
          • We can get fancy with the above, and print additional warnings if .Trash is a file, or the permissions are set wrong (and what the right permissions are).
          • In the md file, let's not add a step that will return an error return code to the example usage. Instead, we should add some help text to the "createZone" command, and update the md file too.
          • The provisionTrash help description also needs to be added to the md file.
          • We can talk about the pre-2.8.0 behavior, sticky bit, and provisionTrash in the "Rename and Trash considerations" section.
          • One of the unit tests should verify that the sticky bit is set on a provisioned Trash directory.
          Show
          andrew.wang Andrew Wang added a comment - Thanks for the discussion all, and Wei-Chiu for the patch. HdfsAdmin is a public API, so I don't think we should modify createZone there to also provisionTrash. It'd mean we have no way of creating a zone without a Trash directory (the old behavior) and also gets into my earlier concerns about atomicity. We can revisit this later if we find we need Java API access to provisionTrash, but that should be rare since you can just do it with mkdir and chmod. Review comments: Shall we error if provisionTrash isn't called on an EZ root? That more clearly reflects that the Trash directory is an EZ-level construct. If a Trash directory already exists, it might already be set up properly, so it seems harsh to tell the user to rename it. Instead, how about e.g. "Will not provision new trash directory for encryption zone /ez/, path already exists." We can get fancy with the above, and print additional warnings if .Trash is a file, or the permissions are set wrong (and what the right permissions are). In the md file, let's not add a step that will return an error return code to the example usage. Instead, we should add some help text to the "createZone" command, and update the md file too. The provisionTrash help description also needs to be added to the md file. We can talk about the pre-2.8.0 behavior, sticky bit, and provisionTrash in the "Rename and Trash considerations" section. One of the unit tests should verify that the sticky bit is set on a provisioned Trash directory.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Andrew Wang and Wei-Chiu Chuang. I agree with you analysis that we probably don't need a provisionTrash API separately. I mean to have an overload version of HdfsAdmin#createEncryptionZone with a provisionTrash parameter and switch crypto CLI to call the new API. This way, we can deprecate the existing API that does not create .Trash with permissions in the next few releases. Give this will be an Admin wrapper API over DFS API with opt-out parameter, I think it is an acceptable solution to save future document/support cost. What do you think?

          Show
          xyao Xiaoyu Yao added a comment - Thanks Andrew Wang and Wei-Chiu Chuang . I agree with you analysis that we probably don't need a provisionTrash API separately. I mean to have an overload version of HdfsAdmin#createEncryptionZone with a provisionTrash parameter and switch crypto CLI to call the new API. This way, we can deprecate the existing API that does not create .Trash with permissions in the next few releases. Give this will be an Admin wrapper API over DFS API with opt-out parameter, I think it is an acceptable solution to save future document/support cost. What do you think?
          Hide
          andrew.wang Andrew Wang added a comment -

          Sounds good to me Xiaoyu Yao. Let's also do the provisionTrash flag as an EnumSet to future-proof.

          Show
          andrew.wang Andrew Wang added a comment - Sounds good to me Xiaoyu Yao . Let's also do the provisionTrash flag as an EnumSet to future-proof.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Xiaoyu and Andrew. I'm currently per-occupied by other stuff but I expect to post a new patch next week.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Xiaoyu and Andrew. I'm currently per-occupied by other stuff but I expect to post a new patch next week.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Revision 4. With this patch, it addresses all of Andrew's comments in the last round. Thanks again for the review!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Revision 4. With this patch, it addresses all of Andrew's comments in the last round. Thanks again for the review!
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks Wei-Chiu, LGTM overall. I think this is ready for commit, though it looks like you didn't do the HdfsAdmin refactor that Xiaoyu asked for?

          Show
          andrew.wang Andrew Wang added a comment - Thanks Wei-Chiu, LGTM overall. I think this is ready for commit, though it looks like you didn't do the HdfsAdmin refactor that Xiaoyu asked for?
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Yeah I didn't do that. I was under the impression Xiaoyu filed a JIRA for that (HDFS-10344), but apparently I was wrong. I can add that part for sure.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Yeah I didn't do that. I was under the impression Xiaoyu filed a JIRA for that ( HDFS-10344 ), but apparently I was wrong. I can add that part for sure.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Andrew Wang and Wei-Chiu Chuang. HDFS-10344 is for a different issue. Let's have the HdfsAdmin refactor included in HDFS-10324 and I will review it when Wei-Chiu Chuang have a new patch available.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Andrew Wang and Wei-Chiu Chuang . HDFS-10344 is for a different issue. Let's have the HdfsAdmin refactor included in HDFS-10324 and I will review it when Wei-Chiu Chuang have a new patch available.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 48s trunk passed
          +1 compile 6m 15s trunk passed with JDK v1.8.0_91
          +1 compile 6m 48s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 31s trunk passed
          +1 javadoc 1m 59s trunk passed with JDK v1.8.0_91
          +1 javadoc 2m 51s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 29s the patch passed
          +1 compile 5m 52s the patch passed with JDK v1.8.0_91
          +1 javac 5m 52s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          -1 checkstyle 1m 5s root: patch generated 3 new + 11 unchanged - 3 fixed = 14 total (was 14)
          +1 mvnsite 1m 50s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 3m 54s the patch passed
          +1 javadoc 1m 57s the patch passed with JDK v1.8.0_91
          +1 javadoc 2m 50s the patch passed with JDK v1.7.0_95
          -1 unit 21m 10s hadoop-common in the patch failed with JDK v1.8.0_91.
          -1 unit 56m 40s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          -1 unit 7m 15s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 53m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          199m 4s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.TestDFSUpgradeFromImage
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801794/HDFS-10324.004.patch
          JIRA Issue HDFS-10324
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 6d8b0eeeb518 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4ee4e5c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15343/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15343/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 48s trunk passed +1 compile 6m 15s trunk passed with JDK v1.8.0_91 +1 compile 6m 48s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 4s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 31s trunk passed +1 javadoc 1m 59s trunk passed with JDK v1.8.0_91 +1 javadoc 2m 51s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 5m 52s the patch passed with JDK v1.8.0_91 +1 javac 5m 52s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed -1 checkstyle 1m 5s root: patch generated 3 new + 11 unchanged - 3 fixed = 14 total (was 14) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 54s the patch passed +1 javadoc 1m 57s the patch passed with JDK v1.8.0_91 +1 javadoc 2m 50s the patch passed with JDK v1.7.0_95 -1 unit 21m 10s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 56m 40s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 7m 15s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 53m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 199m 4s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801794/HDFS-10324.004.patch JIRA Issue HDFS-10324 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 6d8b0eeeb518 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4ee4e5c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15343/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15343/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15343/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev05: Thanks Xiaoyu Yao and Andrew Wang.
          I added an overloaded HdfsAdmin#createEncryptionZone API as well as a new HdfsAdmin#provisionEncryptionZoneTrash API. The crypto CLI now calls these two HdfsAdmin APIs instead of using DistributedFileSystem directly.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev05: Thanks Xiaoyu Yao and Andrew Wang . I added an overloaded HdfsAdmin#createEncryptionZone API as well as a new HdfsAdmin#provisionEncryptionZoneTrash API. The crypto CLI now calls these two HdfsAdmin APIs instead of using DistributedFileSystem directly.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 6m 8s trunk passed with JDK v1.8.0_91
          +1 compile 7m 10s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 1m 51s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 32s trunk passed
          +1 javadoc 2m 15s trunk passed with JDK v1.8.0_91
          +1 javadoc 2m 51s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 27s the patch passed
          +1 compile 5m 49s the patch passed with JDK v1.8.0_91
          -1 javac 7m 31s root-jdk1.8.0_91 with JDK v1.8.0_91 generated 57 new + 724 unchanged - 0 fixed = 781 total (was 724)
          +1 javac 5m 49s the patch passed
          +1 compile 6m 35s the patch passed with JDK v1.7.0_95
          -1 javac 14m 6s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 57 new + 719 unchanged - 0 fixed = 776 total (was 719)
          +1 javac 6m 35s the patch passed
          -1 checkstyle 1m 4s root: patch generated 5 new + 15 unchanged - 3 fixed = 20 total (was 18)
          +1 mvnsite 1m 50s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 7s the patch passed
          +1 javadoc 2m 23s the patch passed with JDK v1.8.0_91
          +1 javadoc 2m 57s the patch passed with JDK v1.7.0_95
          +1 unit 9m 11s hadoop-common in the patch passed with JDK v1.8.0_91.
          -1 unit 60m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 55m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 26s Patch generated 1 ASF License warnings.
          193m 33s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.TestDFSUpgradeFromImage
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestAclsEndToEnd
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802019/HDFS-10324.005.patch
          JIRA Issue HDFS-10324
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 05e7767ae384 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c6b4839
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_91.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15349/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15349/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 6m 8s trunk passed with JDK v1.8.0_91 +1 compile 7m 10s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 4s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 32s trunk passed +1 javadoc 2m 15s trunk passed with JDK v1.8.0_91 +1 javadoc 2m 51s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 5m 49s the patch passed with JDK v1.8.0_91 -1 javac 7m 31s root-jdk1.8.0_91 with JDK v1.8.0_91 generated 57 new + 724 unchanged - 0 fixed = 781 total (was 724) +1 javac 5m 49s the patch passed +1 compile 6m 35s the patch passed with JDK v1.7.0_95 -1 javac 14m 6s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 57 new + 719 unchanged - 0 fixed = 776 total (was 719) +1 javac 6m 35s the patch passed -1 checkstyle 1m 4s root: patch generated 5 new + 15 unchanged - 3 fixed = 20 total (was 18) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 7s the patch passed +1 javadoc 2m 23s the patch passed with JDK v1.8.0_91 +1 javadoc 2m 57s the patch passed with JDK v1.7.0_95 +1 unit 9m 11s hadoop-common in the patch passed with JDK v1.8.0_91. -1 unit 60m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 55m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 26s Patch generated 1 ASF License warnings. 193m 33s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestAclsEndToEnd   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802019/HDFS-10324.005.patch JIRA Issue HDFS-10324 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 05e7767ae384 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c6b4839 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_91.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15349/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15349/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15349/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev06: fixed code style issue, javadoc warning and asf license warning.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev06: fixed code style issue, javadoc warning and asf license warning.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Wei-Chiu Chuang for updating the patch. The patch looks good to me overall. I just have a few minor issues listed below:

          1. TrashPolicyDefault#TRASH is a unused private and can be removed.

          2. TrasnparentEncryption.md can we highlight only the root path of the encryption zone is allowed.
          | path | The path of the encryption zone. | => | path | The path to the root of the encryption zone. |

          3. TestRpcProgramNfs3.java
          Unused import: import org.apache.hadoop.crypto.key.KeyProviderFactory;

          4. CreateEncryptionZoneFlag.java
          I see we use noFlag to fix the unit tests that call the deprecated HdfsAdmin#createEncyrption API. Do you consider add this as a flag such as NO_FLAG((shot)) 0x0) to CreateEncryptionZoneFlag so that 3rd party can easily migrate existing code to the new API?

            protected final EnumSet< CreateEncryptionZoneFlag > noFlag =
            EnumSet.noneOf(CreateEncryptionZoneFlag.class);
          

          5. HDFSCommands.md, the new CLI option have a <path> argument without -path. Do we want to to be consistent here using {{ -path <path>}} like the existing hdfs crypto -createZone -keyName <keyName> -path <path>?

          hdfs crypto -provisionTrash <path>
          

          6. HdfsAdmin.java
          For the new API HdfsAdmin#CreateEncryptionZone, Can you highlight the difference in the javadoc? For example, "additional provision steps such as Trash can be enabled with the new flags parameter."

          HdfsAdmin#provisionEZTrash can we change trashPermission to be class static?

          7. CryptoAdmin.java
          Same as 5. Suggest adding a -path before <path> to be consistent.
          Suggest change "The path to the encryption zone." to "The path to the root of the encryption zone" in the code below.

           listing.addRow("<path>", "The path to the encryption zone. ");
          
          Show
          xyao Xiaoyu Yao added a comment - Thanks Wei-Chiu Chuang for updating the patch. The patch looks good to me overall. I just have a few minor issues listed below: 1. TrashPolicyDefault#TRASH is a unused private and can be removed. 2. TrasnparentEncryption.md can we highlight only the root path of the encryption zone is allowed. | path | The path of the encryption zone. | => | path | The path to the root of the encryption zone. | 3. TestRpcProgramNfs3.java Unused import: import org.apache.hadoop.crypto.key.KeyProviderFactory; 4. CreateEncryptionZoneFlag.java I see we use noFlag to fix the unit tests that call the deprecated HdfsAdmin#createEncyrption API. Do you consider add this as a flag such as NO_FLAG((shot)) 0x0) to CreateEncryptionZoneFlag so that 3rd party can easily migrate existing code to the new API? protected final EnumSet< CreateEncryptionZoneFlag > noFlag = EnumSet.noneOf(CreateEncryptionZoneFlag.class); 5. HDFSCommands.md, the new CLI option have a <path> argument without -path. Do we want to to be consistent here using {{ -path <path>}} like the existing hdfs crypto -createZone -keyName <keyName> -path <path> ? hdfs crypto -provisionTrash <path> 6. HdfsAdmin.java For the new API HdfsAdmin#CreateEncryptionZone, Can you highlight the difference in the javadoc? For example, "additional provision steps such as Trash can be enabled with the new flags parameter." HdfsAdmin#provisionEZTrash can we change trashPermission to be class static? 7. CryptoAdmin.java Same as 5. Suggest adding a -path before <path> to be consistent. Suggest change "The path to the encryption zone." to "The path to the root of the encryption zone" in the code below. listing.addRow( "<path>" , "The path to the encryption zone. " );
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks again for the quick review!
          I've updated the patch based on the comments below:

          1. TrashPolicyDefault#TRASH is a unused private and can be removed.

          Done.

          2. TrasnparentEncryption.md can we highlight only the root path of the encryption zone is allowed.

          Done.

          TestRpcProgramNfs3.java Unused import

          Done.

          CreateEncryptionZoneFlag.java

          I added a new NO_TRASH type into it, and refactored the tests to use

          protected static final EnumSet< CreateEncryptionZoneFlag > NO_TRASH =
                EnumSet.of(CreateEncryptionZoneFlag.NO_TRASH);
          

          HDFSCommands.md

          Done. I think it's a good idea to be consistent.

          HdfsAdmin.java

          I refactored it to make it static final, and changed the name to TRASH_PERMISSION.

          CryptoAdmin.java

          Done.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks again for the quick review! I've updated the patch based on the comments below: 1. TrashPolicyDefault#TRASH is a unused private and can be removed. Done. 2. TrasnparentEncryption.md can we highlight only the root path of the encryption zone is allowed. Done. TestRpcProgramNfs3.java Unused import Done. CreateEncryptionZoneFlag.java I added a new NO_TRASH type into it, and refactored the tests to use protected static final EnumSet< CreateEncryptionZoneFlag > NO_TRASH = EnumSet.of(CreateEncryptionZoneFlag.NO_TRASH); HDFSCommands.md Done. I think it's a good idea to be consistent. HdfsAdmin.java I refactored it to make it static final, and changed the name to TRASH_PERMISSION . CryptoAdmin.java Done.
          Hide
          xyao Xiaoyu Yao added a comment -

          +1 for the v7 patch pending Jenkins.

          Show
          xyao Xiaoyu Yao added a comment - +1 for the v7 patch pending Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 6m 45s trunk passed
          +1 compile 6m 27s trunk passed with JDK v1.8.0_91
          +1 compile 6m 59s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 2m 6s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 3m 53s trunk passed
          +1 javadoc 2m 14s trunk passed with JDK v1.8.0_91
          +1 javadoc 3m 5s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 45s the patch passed
          +1 compile 6m 6s the patch passed with JDK v1.8.0_91
          +1 javac 6m 6s the patch passed
          +1 compile 6m 50s the patch passed with JDK v1.7.0_95
          +1 javac 6m 50s the patch passed
          -1 checkstyle 1m 5s root: patch generated 2 new + 15 unchanged - 4 fixed = 17 total (was 19)
          +1 mvnsite 2m 5s the patch passed
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 42s the patch passed
          +1 javadoc 2m 11s the patch passed with JDK v1.8.0_91
          +1 javadoc 3m 2s the patch passed with JDK v1.7.0_95
          +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.8.0_91.
          -1 unit 58m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed with JDK v1.8.0_91.
          -1 unit 7m 27s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 54m 48s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 50s hadoop-hdfs-nfs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          195m 49s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestHFlush
          JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS
            hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802295/HDFS-10324.007.patch
          JIRA Issue HDFS-10324
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 123de88cfe88 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9e37fe3
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15365/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15365/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 45s trunk passed +1 compile 6m 27s trunk passed with JDK v1.8.0_91 +1 compile 6m 59s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 4s trunk passed +1 mvnsite 2m 6s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 3m 53s trunk passed +1 javadoc 2m 14s trunk passed with JDK v1.8.0_91 +1 javadoc 3m 5s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 45s the patch passed +1 compile 6m 6s the patch passed with JDK v1.8.0_91 +1 javac 6m 6s the patch passed +1 compile 6m 50s the patch passed with JDK v1.7.0_95 +1 javac 6m 50s the patch passed -1 checkstyle 1m 5s root: patch generated 2 new + 15 unchanged - 4 fixed = 17 total (was 19) +1 mvnsite 2m 5s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 42s the patch passed +1 javadoc 2m 11s the patch passed with JDK v1.8.0_91 +1 javadoc 3m 2s the patch passed with JDK v1.7.0_95 +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.8.0_91. -1 unit 58m 13s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed with JDK v1.8.0_91. -1 unit 7m 27s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 54m 48s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 unit 1m 50s hadoop-hdfs-nfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 195m 49s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestHFlush JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS   hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802295/HDFS-10324.007.patch JIRA Issue HDFS-10324 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 123de88cfe88 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e37fe3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15365/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15365/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15365/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev08: fix checkstyle warning.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev08: fix checkstyle warning.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Attach again.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Attach again.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 1m 56s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 5m 50s trunk passed with JDK v1.8.0_91
          +1 compile 6m 42s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 2m 11s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 4m 3s trunk passed
          +1 javadoc 2m 7s trunk passed with JDK v1.8.0_91
          +1 javadoc 3m 4s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 42s the patch passed
          +1 compile 5m 44s the patch passed with JDK v1.8.0_91
          +1 javac 5m 44s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          +1 checkstyle 1m 5s root: patch generated 0 new + 15 unchanged - 4 fixed = 15 total (was 19)
          +1 mvnsite 2m 9s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 44s the patch passed
          +1 javadoc 2m 13s the patch passed with JDK v1.8.0_91
          +1 javadoc 3m 5s the patch passed with JDK v1.7.0_95
          -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.8.0_91.
          -1 unit 59m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          +1 unit 1m 45s hadoop-hdfs-nfs in the patch passed with JDK v1.8.0_91.
          -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 54m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 1m 49s hadoop-hdfs-nfs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          197m 19s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestDecommissionWithStriped
          JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802347/HDFS-10324.008.patch
          JIRA Issue HDFS-10324
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux dd12a7999c74 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1268cf5
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15366/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15366/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 1m 56s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 5m 50s trunk passed with JDK v1.8.0_91 +1 compile 6m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 2m 11s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 4m 3s trunk passed +1 javadoc 2m 7s trunk passed with JDK v1.8.0_91 +1 javadoc 3m 4s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 5m 44s the patch passed with JDK v1.8.0_91 +1 javac 5m 44s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed +1 checkstyle 1m 5s root: patch generated 0 new + 15 unchanged - 4 fixed = 15 total (was 19) +1 mvnsite 2m 9s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 44s the patch passed +1 javadoc 2m 13s the patch passed with JDK v1.8.0_91 +1 javadoc 3m 5s the patch passed with JDK v1.7.0_95 -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 59m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 1m 45s hadoop-hdfs-nfs in the patch passed with JDK v1.8.0_91. -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 54m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 1m 49s hadoop-hdfs-nfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 197m 19s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.TestHFlush   hadoop.hdfs.TestDecommissionWithStriped JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802347/HDFS-10324.008.patch JIRA Issue HDFS-10324 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux dd12a7999c74 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1268cf5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15366/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15366/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15366/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Wei-Chiu Chuang for fixing the checkstyle issues. The latest patch looks good to me. The unit test failures are known flaky tests tracked by HDFS-2043, HADOOP-13101 and HDFS-10371.

          I will hold off committing today in case Andrew Wang has additional comments.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Wei-Chiu Chuang for fixing the checkstyle issues. The latest patch looks good to me. The unit test failures are known flaky tests tracked by HDFS-2043 , HADOOP-13101 and HDFS-10371 . I will hold off committing today in case Andrew Wang has additional comments.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Wei-Chiu Chuang for the contribution and Andrew Wang for the discussion and code review. I've committed the patch to trunk, branch-2 and branch-2.8.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Wei-Chiu Chuang for the contribution and Andrew Wang for the discussion and code review. I've committed the patch to trunk, branch-2 and branch-2.8.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9727 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9727/)
          HDFS-10324. Trash directory in an encryption zone should be pre-created (xyao: rev dacd1f50feb24ccdf6155b2b7a6126fe21a47ad0)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/CreateEncryptionZoneFlag.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithHA.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/package-info.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CryptoAdmin.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestRpcProgramNfs3.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReservedRawPaths.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsAdmin.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithKMS.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCryptoConf.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9727 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9727/ ) HDFS-10324 . Trash directory in an encryption zone should be pre-created (xyao: rev dacd1f50feb24ccdf6155b2b7a6126fe21a47ad0) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/CreateEncryptionZoneFlag.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithHA.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/package-info.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CryptoAdmin.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestRpcProgramNfs3.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReservedRawPaths.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZonesWithKMS.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCryptoConf.xml
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Xiaoyu Yao and Andrew Wang, really appreciate your review!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Xiaoyu Yao and Andrew Wang , really appreciate your review!
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Added a release note. Wei-Chiu Chuang can you please review it for correctness?

          Show
          arpitagarwal Arpit Agarwal added a comment - Added a release note. Wei-Chiu Chuang can you please review it for correctness?
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Arpit Agarwal for the great summary. I made a minor change to the release note based on your summary.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Arpit Agarwal for the great summary. I made a minor change to the release note based on your summary.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thank you for the quick review and update!

          Show
          arpitagarwal Arpit Agarwal added a comment - Thank you for the quick review and update!

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development