Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10273

Remove duplicate logSync() and log message in FSN#enterSafemode()

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.9.0
    • 2.9.0, 3.0.0-alpha1
    • None
    • None

    Description

      Remove duplicate logSync() and log message in FSN#enterSafemode()

      FSN#enterSafemode(..)
            // Before Editlog is in OpenForWrite mode, editLogStream will be null. So,
            // logSyncAll call can be called only when Edlitlog is in OpenForWrite mode
            if (isEditlogOpenForWrite) {
              getEditLog().logSyncAll();
            }
            setManualAndResourceLowSafeMode(!resourcesLow, resourcesLow);
            NameNode.stateChangeLog.info("STATE* Safe mode is ON.\n" +
                getSafeModeTip());
            if (isEditlogOpenForWrite) {
              getEditLog().logSyncAll();
            }
            NameNode.stateChangeLog.info("STATE* Safe mode is ON" + getSafeModeTip());
      

      Attachments

        1. HDFS-10273-01.patch
          1 kB
          Vinayakumar B

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            vinayakumarb Vinayakumar B
            vinayakumarb Vinayakumar B
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment