Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10273

Remove duplicate logSync() and log message in FSN#enterSafemode()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Remove duplicate logSync() and log message in FSN#enterSafemode()

      FSN#enterSafemode(..)
            // Before Editlog is in OpenForWrite mode, editLogStream will be null. So,
            // logSyncAll call can be called only when Edlitlog is in OpenForWrite mode
            if (isEditlogOpenForWrite) {
              getEditLog().logSyncAll();
            }
            setManualAndResourceLowSafeMode(!resourcesLow, resourcesLow);
            NameNode.stateChangeLog.info("STATE* Safe mode is ON.\n" +
                getSafeModeTip());
            if (isEditlogOpenForWrite) {
              getEditLog().logSyncAll();
            }
            NameNode.stateChangeLog.info("STATE* Safe mode is ON" + getSafeModeTip());
      

        Activity

        Hide
        vinayrpet Vinayakumar B added a comment -

        Attached simple patch to remove duplicate lines.

        Show
        vinayrpet Vinayakumar B added a comment - Attached simple patch to remove duplicate lines.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 9s trunk passed
        +1 compile 1m 3s trunk passed with JDK v1.8.0_77
        +1 compile 0m 56s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 34s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 16s trunk passed
        +1 javadoc 1m 49s trunk passed with JDK v1.8.0_77
        +1 javadoc 3m 21s trunk passed with JDK v1.7.0_95
        +1 mvninstall 1m 23s the patch passed
        +1 compile 1m 46s the patch passed with JDK v1.8.0_77
        +1 javac 1m 46s the patch passed
        +1 compile 1m 12s the patch passed with JDK v1.7.0_95
        +1 javac 1m 12s the patch passed
        +1 checkstyle 0m 30s the patch passed
        +1 mvnsite 1m 10s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 9s the patch passed
        +1 javadoc 2m 17s the patch passed with JDK v1.8.0_77
        +1 javadoc 3m 17s the patch passed with JDK v1.7.0_95
        -1 unit 107m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 89m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 36s Patch does not generate ASF License warnings.
        236m 12s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.fs.contract.hdfs.TestHDFSContractSeek
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.fs.contract.hdfs.TestHDFSContractSeek



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797854/HDFS-10273-01.patch
        JIRA Issue HDFS-10273
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 20eda80e1b07 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fcb3fcd
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15126/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15126/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 9s trunk passed +1 compile 1m 3s trunk passed with JDK v1.8.0_77 +1 compile 0m 56s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 16s trunk passed +1 javadoc 1m 49s trunk passed with JDK v1.8.0_77 +1 javadoc 3m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 23s the patch passed +1 compile 1m 46s the patch passed with JDK v1.8.0_77 +1 javac 1m 46s the patch passed +1 compile 1m 12s the patch passed with JDK v1.7.0_95 +1 javac 1m 12s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 9s the patch passed +1 javadoc 2m 17s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 17s the patch passed with JDK v1.7.0_95 -1 unit 107m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 89m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 36s Patch does not generate ASF License warnings. 236m 12s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestEditLog   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.fs.contract.hdfs.TestHDFSContractSeek JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.fs.contract.hdfs.TestHDFSContractSeek Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797854/HDFS-10273-01.patch JIRA Issue HDFS-10273 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 20eda80e1b07 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fcb3fcd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15126/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15126/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Vinayakumar B.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Vinayakumar B .
        Hide
        cmccabe Colin P. McCabe added a comment -

        Committed to 2.9. Thanks.

        Show
        cmccabe Colin P. McCabe added a comment - Committed to 2.9. Thanks.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9598 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9598/)
        HDFS-10273. Remove duplicate logSync() and log message in (cmccabe: rev 600d129bb8d52ae820e7b74b8ce363aabd69d25c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9598 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9598/ ) HDFS-10273 . Remove duplicate logSync() and log message in (cmccabe: rev 600d129bb8d52ae820e7b74b8ce363aabd69d25c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

          People

          • Assignee:
            vinayrpet Vinayakumar B
            Reporter:
            vinayrpet Vinayakumar B
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development