Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.9.0
-
Fix Version/s: 2.9.0, 3.0.0-alpha1
-
Component/s: None
-
Labels:None
-
Target Version/s:
Description
Remove duplicate logSync() and log message in FSN#enterSafemode()
FSN#enterSafemode(..)
// Before Editlog is in OpenForWrite mode, editLogStream will be null. So,
// logSyncAll call can be called only when Edlitlog is in OpenForWrite mode
if (isEditlogOpenForWrite) {
getEditLog().logSyncAll();
}
setManualAndResourceLowSafeMode(!resourcesLow, resourcesLow);
NameNode.stateChangeLog.info("STATE* Safe mode is ON.\n" +
getSafeModeTip());
if (isEditlogOpenForWrite) {
getEditLog().logSyncAll();
}
NameNode.stateChangeLog.info("STATE* Safe mode is ON" + getSafeModeTip());
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 16s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 8m 9s | trunk passed |
| +1 | compile | 1m 3s | trunk passed with JDK v1.8.0_77 |
| +1 | compile | 0m 56s | trunk passed with JDK v1.7.0_95 |
| +1 | checkstyle | 0m 34s | trunk passed |
| +1 | mvnsite | 1m 7s | trunk passed |
| +1 | mvneclipse | 0m 15s | trunk passed |
| +1 | findbugs | 2m 16s | trunk passed |
| +1 | javadoc | 1m 49s | trunk passed with JDK v1.8.0_77 |
| +1 | javadoc | 3m 21s | trunk passed with JDK v1.7.0_95 |
| +1 | mvninstall | 1m 23s | the patch passed |
| +1 | compile | 1m 46s | the patch passed with JDK v1.8.0_77 |
| +1 | javac | 1m 46s | the patch passed |
| +1 | compile | 1m 12s | the patch passed with JDK v1.7.0_95 |
| +1 | javac | 1m 12s | the patch passed |
| +1 | checkstyle | 0m 30s | the patch passed |
| +1 | mvnsite | 1m 10s | the patch passed |
| +1 | mvneclipse | 0m 13s | the patch passed |
| +1 | whitespace | 0m 0s | Patch has no whitespace issues. |
| +1 | findbugs | 3m 9s | the patch passed |
| +1 | javadoc | 2m 17s | the patch passed with JDK v1.8.0_77 |
| +1 | javadoc | 3m 17s | the patch passed with JDK v1.7.0_95 |
| -1 | unit | 107m 23s | hadoop-hdfs in the patch failed with JDK v1.8.0_77. |
| -1 | unit | 89m 32s | hadoop-hdfs in the patch failed with JDK v1.7.0_95. |
| +1 | asflicense | 0m 36s | Patch does not generate ASF License warnings. |
| 236m 12s |
| Reason | Tests |
|---|---|
| JDK v1.8.0_77 Failed junit tests | hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl |
| hadoop.hdfs.security.TestDelegationTokenForProxyUser | |
| hadoop.hdfs.server.namenode.TestEditLog | |
| hadoop.fs.TestSymlinkHdfsFileContext | |
| hadoop.hdfs.server.datanode.TestDirectoryScanner | |
| hadoop.fs.contract.hdfs.TestHDFSContractSeek | |
| JDK v1.7.0_95 Failed junit tests | hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl |
| hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA | |
| hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs | |
| hadoop.hdfs.server.namenode.ha.TestHAAppend | |
| hadoop.fs.TestSymlinkHdfsFileContext | |
| hadoop.fs.contract.hdfs.TestHDFSContractSeek |
This message was automatically generated.
+1. Thanks, Vinayakumar B.
Committed to 2.9. Thanks.
FAILURE: Integrated in Hadoop-trunk-Commit #9598 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9598/)
HDFS-10273. Remove duplicate logSync() and log message in (cmccabe: rev 600d129bb8d52ae820e7b74b8ce363aabd69d25c)
- hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
Attached simple patch to remove duplicate lines.