Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.7.3
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Link

      https://builds.apache.org/job/PreCommit-HDFS-Build/15036/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html

      Following seen in HDFS-9917 jenkins run.

      Code	Warning
      IS	Inconsistent synchronization of org.apache.hadoop.hdfs.DFSOutputStream.streamer; locked 85% of time
      Bug type IS2_INCONSISTENT_SYNC (click for details) 
      In class org.apache.hadoop.hdfs.DFSOutputStream
      Field org.apache.hadoop.hdfs.DFSOutputStream.streamer
      Synchronized 85% of the time
      Unsynchronized access at DFSOutputStream.java:[line 2372]
      Unsynchronized access at DFSOutputStream.java:[line 2390]
      Unsynchronized access at DFSOutputStream.java:[line 1722]
      Synchronized access at DFSOutputStream.java:[line 2178]
      Synchronized access at DFSOutputStream.java:[line 2100]
      Synchronized access at DFSOutputStream.java:[line 2103]
      Synchronized access at DFSOutputStream.java:[line 2264]
      Synchronized access at DFSOutputStream.java:[line 1555]
      Synchronized access at DFSOutputStream.java:[line 1558]
      Synchronized access at DFSOutputStream.java:[line 2166]
      Synchronized access at DFSOutputStream.java:[line 2208]
      Synchronized access at DFSOutputStream.java:[line 2216]
      Synchronized access at DFSOutputStream.java:[line 2209]
      Synchronized access at DFSOutputStream.java:[line 2216]
      Synchronized access at DFSOutputStream.java:[line 2037]
      Synchronized access at DFSOutputStream.java:[line 2037]
      Synchronized access at DFSOutputStream.java:[line 2038]
      Synchronized access at DFSOutputStream.java:[line 2062]
      Synchronized access at DFSOutputStream.java:[line 2063]
      Synchronized access at DFSOutputStream.java:[line 2355]
      
      1. HDFS-10245-002-branch-2.7.patch
        2 kB
        Brahma Reddy Battula
      2. HDFS-10245-branch-2.7.patch
        1 kB
        Brahma Reddy Battula
      3. HDFS-10245-branch-2.7-002.patch
        2 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch.Kindly Review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch.Kindly Review..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 6s HDFS-10245 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796783/HDFS-10245-branch-2.7%20.patch
        JIRA Issue HDFS-10245
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15053/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HDFS-10245 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796783/HDFS-10245-branch-2.7%20.patch JIRA Issue HDFS-10245 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15053/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 8m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 17s branch-2.7 passed
        +1 compile 1m 8s branch-2.7 passed with JDK v1.8.0_77
        +1 compile 1m 0s branch-2.7 passed with JDK v1.7.0_95
        +1 checkstyle 0m 28s branch-2.7 passed
        +1 mvnsite 0m 53s branch-2.7 passed
        +1 mvneclipse 0m 12s branch-2.7 passed
        -1 findbugs 2m 53s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings.
        +1 javadoc 1m 6s branch-2.7 passed with JDK v1.8.0_77
        +1 javadoc 1m 54s branch-2.7 passed with JDK v1.7.0_95
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 54s the patch passed with JDK v1.8.0_77
        +1 javac 0m 54s the patch passed
        +1 compile 0m 57s the patch passed with JDK v1.7.0_95
        +1 javac 0m 57s the patch passed
        -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 120 unchanged - 1 fixed = 121 total (was 121)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        -1 whitespace 0m 0s The patch has 1239 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 27s The patch has 248 line(s) with tabs.
        +1 findbugs 3m 22s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
        +1 javadoc 1m 18s the patch passed with JDK v1.8.0_77
        +1 javadoc 2m 4s the patch passed with JDK v1.7.0_95
        -1 unit 49m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 45m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 asflicense 1m 9s Patch generated 65 ASF License warnings.
        133m 59s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.tools.TestJMXGet
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.web.TestHttpsFileSystem
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.ha.TestDNFencing
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
        JDK v1.7.0_95 Failed junit tests hadoop.tools.TestJMXGet
          hadoop.hdfs.web.TestHttpsFileSystem
          hadoop.hdfs.TestDatanodeRegistration
          hadoop.hdfs.web.TestWebHdfsTokens
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.datanode.TestBlockReplacement



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:c420dfe
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796784/HDFS-10245-branch-2.7.patch
        JIRA Issue HDFS-10245
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f45e274a6004 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / 353f379
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15055/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15055/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 8m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 17s branch-2.7 passed +1 compile 1m 8s branch-2.7 passed with JDK v1.8.0_77 +1 compile 1m 0s branch-2.7 passed with JDK v1.7.0_95 +1 checkstyle 0m 28s branch-2.7 passed +1 mvnsite 0m 53s branch-2.7 passed +1 mvneclipse 0m 12s branch-2.7 passed -1 findbugs 2m 53s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings. +1 javadoc 1m 6s branch-2.7 passed with JDK v1.8.0_77 +1 javadoc 1m 54s branch-2.7 passed with JDK v1.7.0_95 +1 mvninstall 0m 51s the patch passed +1 compile 0m 54s the patch passed with JDK v1.8.0_77 +1 javac 0m 54s the patch passed +1 compile 0m 57s the patch passed with JDK v1.7.0_95 +1 javac 0m 57s the patch passed -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 120 unchanged - 1 fixed = 121 total (was 121) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1239 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 27s The patch has 248 line(s) with tabs. +1 findbugs 3m 22s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 1m 18s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 4s the patch passed with JDK v1.7.0_95 -1 unit 49m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 45m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 1m 9s Patch generated 65 ASF License warnings. 133m 59s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.tools.TestJMXGet   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots JDK v1.7.0_95 Failed junit tests hadoop.tools.TestJMXGet   hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796784/HDFS-10245-branch-2.7.patch JIRA Issue HDFS-10245 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f45e274a6004 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 353f379 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15055/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15055/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15055/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Hi Allen Wittenauer

        Seems to be, findbug report shows branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html instead of patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html

        After Patch shows "0" warnings. which is not considered for QA

        ============================================================================
        ============================================================================
                                 Patch findbugs detection
        ============================================================================
        ============================================================================
        
        
        cd /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs
        mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.7-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt 2>&1
        Elapsed:   3m  1s
        Starting with /testptch/hadoop/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.xml
        Merging /testptch/hadoop/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.xml
        Writing /testptch/hadoop/patchprocess/combined-findbugs-hadoop-hdfs-project_hadoop-hdfs.xml
        
        hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
        

        Pre-patch shows "1" warning, same reported in QA.

        ============================================================================
        ============================================================================
                               Pre-patch findbugs detection
        ============================================================================
        ============================================================================
        
        
        cd /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs
        mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.7-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt 2>&1
        Elapsed:   2m 50s
        
        hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings.
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - Hi Allen Wittenauer Seems to be, findbug report shows branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html instead of patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html After Patch shows "0" warnings. which is not considered for QA ============================================================================ ============================================================================ Patch findbugs detection ============================================================================ ============================================================================ cd /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.7-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt 2>&1 Elapsed: 3m 1s Starting with /testptch/hadoop/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.xml Merging /testptch/hadoop/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.xml Writing /testptch/hadoop/patchprocess/combined-findbugs-hadoop-hdfs-project_hadoop-hdfs.xml hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) Pre-patch shows "1" warning, same reported in QA. ============================================================================ ============================================================================ Pre-patch findbugs detection ============================================================================ ============================================================================ cd /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-branch-2.7-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt 2>&1 Elapsed: 2m 50s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings.
        Hide
        aw Allen Wittenauer added a comment -

        Seems to be, findbug report shows branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html instead of patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html

        Nope, findbugs report is acting as expected.

        There was 1 findbugs found in prepatch so it points to the branch log to show you what that one is. There are no additional findbugs messages therefore there is no report. There is no value at pointing to an empty log.

        Show
        aw Allen Wittenauer added a comment - Seems to be, findbug report shows branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html instead of patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html Nope, findbugs report is acting as expected. There was 1 findbugs found in prepatch so it points to the branch log to show you what that one is. There are no additional findbugs messages therefore there is no report. There is no value at pointing to an empty log.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        There was 1 findbugs found in prepatch.

        Yes exactly, this Jira itself is to fix that. In which case, findbug report should point to post-patch findbugs. No matter whether its empty.
        No explicit filtered report for findbugs induced from the patch is not required.
        But, 0 new + 0 unchanged - 1 fixed = 0 total (was 1) this message at the end, similar to checkstyle fixes will help to indentify changes.

        Show
        brahmareddy Brahma Reddy Battula added a comment - There was 1 findbugs found in prepatch. Yes exactly, this Jira itself is to fix that. In which case, findbug report should point to post-patch findbugs. No matter whether its empty. No explicit filtered report for findbugs induced from the patch is not required. But, 0 new + 0 unchanged - 1 fixed = 0 total (was 1) this message at the end, similar to checkstyle fixes will help to indentify changes.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        I am thinking this Jira also should go to 2.7.3,Allen Wittenauer/Akira Ajisaka can you look into this issue ..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - I am thinking this Jira also should go to 2.7.3, Allen Wittenauer / Akira Ajisaka can you look into this issue ..?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Brahma Reddy Battula for the patch. Adding synchronization in getBlock() and getPipelineRecoveryCount() is okay because it is used only by test code, that is, there is no effect on performance. However, we don't need to synchronize out in newStreamForAppend method because out.streamer cannot be touched by other threads. It is false-positive.
        Therefore I'm +1 for ignoring the warning by adding a section to findbugsExcludeFile.xml.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for the patch. Adding synchronization in getBlock() and getPipelineRecoveryCount() is okay because it is used only by test code, that is, there is no effect on performance. However, we don't need to synchronize out in newStreamForAppend method because out.streamer cannot be touched by other threads. It is false-positive. Therefore I'm +1 for ignoring the warning by adding a section to findbugsExcludeFile.xml.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Akira Ajisaka thanks a lot for taking a look into this issue.. Uploaded the patch to address your comments.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks a lot for taking a look into this issue.. Uploaded the patch to address your comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 1s Docker mode activated.
        -1 patch 0m 3s HDFS-10245 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800369/HDFS-10245-002-branch-2.7.patch
        JIRA Issue HDFS-10245
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15264/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. -1 patch 0m 3s HDFS-10245 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800369/HDFS-10245-002-branch-2.7.patch JIRA Issue HDFS-10245 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15264/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 10m 49s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 13s branch-2.7 passed
        +1 compile 1m 20s branch-2.7 passed with JDK v1.8.0_77
        +1 compile 1m 3s branch-2.7 passed with JDK v1.7.0_95
        +1 checkstyle 0m 24s branch-2.7 passed
        +1 mvnsite 0m 58s branch-2.7 passed
        +1 mvneclipse 0m 13s branch-2.7 passed
        -1 findbugs 3m 8s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings.
        +1 javadoc 1m 34s branch-2.7 passed with JDK v1.8.0_77
        +1 javadoc 2m 8s branch-2.7 passed with JDK v1.7.0_95
        +1 mvninstall 0m 58s the patch passed
        +1 compile 1m 34s the patch passed with JDK v1.8.0_77
        +1 javac 1m 34s the patch passed
        +1 compile 1m 26s the patch passed with JDK v1.7.0_95
        +1 javac 1m 26s the patch passed
        +1 checkstyle 0m 35s the patch passed
        +1 mvnsite 1m 21s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        -1 whitespace 0m 0s The patch has 1749 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 1m 5s The patch has 248 line(s) with tabs.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 42s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
        +1 javadoc 1m 39s the patch passed with JDK v1.8.0_77
        +1 javadoc 3m 2s the patch passed with JDK v1.7.0_95
        -1 unit 77m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 60m 44s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 asflicense 1m 4s Patch generated 66 ASF License warnings.
        186m 57s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.TestLeaseManager
          hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.TestSafeMode
          hadoop.hdfs.server.namenode.TestDecommissioningStatus



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:c420dfe
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800370/HDFS-10245-branch-2.7-002.patch
        JIRA Issue HDFS-10245
        Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a259a741dd24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / 0bb23e2
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15265/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15265/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 49s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 13s branch-2.7 passed +1 compile 1m 20s branch-2.7 passed with JDK v1.8.0_77 +1 compile 1m 3s branch-2.7 passed with JDK v1.7.0_95 +1 checkstyle 0m 24s branch-2.7 passed +1 mvnsite 0m 58s branch-2.7 passed +1 mvneclipse 0m 13s branch-2.7 passed -1 findbugs 3m 8s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings. +1 javadoc 1m 34s branch-2.7 passed with JDK v1.8.0_77 +1 javadoc 2m 8s branch-2.7 passed with JDK v1.7.0_95 +1 mvninstall 0m 58s the patch passed +1 compile 1m 34s the patch passed with JDK v1.8.0_77 +1 javac 1m 34s the patch passed +1 compile 1m 26s the patch passed with JDK v1.7.0_95 +1 javac 1m 26s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 16s the patch passed -1 whitespace 0m 0s The patch has 1749 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 1m 5s The patch has 248 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 42s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 1m 39s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 2s the patch passed with JDK v1.7.0_95 -1 unit 77m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 60m 44s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 1m 4s Patch generated 66 ASF License warnings. 186m 57s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestLeaseManager   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.TestSecurityTokenEditLog   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.TestDecommissioningStatus Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800370/HDFS-10245-branch-2.7-002.patch JIRA Issue HDFS-10245 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a259a741dd24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 0bb23e2 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15265/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/15265/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15265/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, committing this.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, committing this.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to branch-2.7. Thanks Brahma Reddy Battula for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.7. Thanks Brahma Reddy Battula for the contribution.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Akira Ajisaka thanks a lot for review and commit..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks a lot for review and commit..
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development