Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10219

Change the default value for dfs.namenode.reconstruction.pending.timeout-sec from -1 to 300

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None

      Description

      The default value for "dfs.namenode.replication.pending.timeout-sec" (DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_DEFAULT) is -1, but the timeout is 5 minutes by default.

      BlockManager.java
          pendingReplications = new PendingReplicationBlocks(conf.getInt(
            DFSConfigKeys.DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_KEY,
            DFSConfigKeys.DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_DEFAULT) * 1000L);
      
      PendingReplicationBlocks.java
        private long timeout = 5 * 60 * 1000;
        private final static long DEFAULT_RECHECK_INTERVAL = 5 * 60 * 1000;
      
        PendingReplicationBlocks(long timeoutPeriod) {
          if ( timeoutPeriod > 0 ) {
            this.timeout = timeoutPeriod;
          }
          pendingReplications = new HashMap<>();
          timedOutItems = new ArrayList<>();
        }
      

      I'm thinking we can change DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_DEFAULT from -1 to 300 for improving readability.

      1. HDFS-10219.001.patch
        2 kB
        Yiqun Lin
      2. HDFS-10219.002.patch
        1 kB
        Yiqun Lin
      3. HDFS-10219.003.patch
        3 kB
        Yiqun Lin

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'm thinking this change is compatible because it has no effect on the behavior.

        Show
        ajisakaa Akira Ajisaka added a comment - I'm thinking this change is compatible because it has no effect on the behavior.
        Hide
        linyiqun Yiqun Lin added a comment -

        I'm not sure for that if this change will has effect on unit tests, because it seems many tests has used this config. I'm glad to work for this, upload a simple patch from me. In addition, I found this config was missing in hdfs-default.xml. I have added in my patch.Pending jenkins.

        Show
        linyiqun Yiqun Lin added a comment - I'm not sure for that if this change will has effect on unit tests, because it seems many tests has used this config. I'm glad to work for this, upload a simple patch from me. In addition, I found this config was missing in hdfs-default.xml. I have added in my patch.Pending jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 21s trunk passed
        +1 compile 0m 57s trunk passed with JDK v1.8.0_74
        +1 compile 0m 46s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 2m 9s trunk passed
        +1 javadoc 1m 22s trunk passed with JDK v1.8.0_74
        +1 javadoc 2m 3s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 53s the patch passed with JDK v1.8.0_74
        +1 javac 0m 53s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.7.0_95
        +1 javac 0m 46s the patch passed
        -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 394 unchanged - 1 fixed = 395 total (was 395)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 2m 16s the patch passed
        +1 javadoc 1m 16s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 57s the patch passed with JDK v1.7.0_95
        -1 unit 86m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 83m 59s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
        199m 28s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.TestEncryptionZones



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795610/HDFS-10219.001.patch
        JIRA Issue HDFS-10219
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 075fea0e31c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d8383c6
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14956/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14956/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 21s trunk passed +1 compile 0m 57s trunk passed with JDK v1.8.0_74 +1 compile 0m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 9s trunk passed +1 javadoc 1m 22s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 51s the patch passed +1 compile 0m 53s the patch passed with JDK v1.8.0_74 +1 javac 0m 53s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_95 +1 javac 0m 46s the patch passed -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 394 unchanged - 1 fixed = 395 total (was 395) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 16s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 57s the patch passed with JDK v1.7.0_95 -1 unit 86m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 83m 59s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 199m 28s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795610/HDFS-10219.001.patch JIRA Issue HDFS-10219 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 075fea0e31c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8383c6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14956/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14956/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14956/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        The name PendingReplicationBlocks has been renamed to PendingReconstructionBlocks. Attach a new patch.

        Hi Akira Ajisaka, does this JIRA still makes sense? I think this is a improvement here.

        Show
        linyiqun Yiqun Lin added a comment - The name PendingReplicationBlocks has been renamed to PendingReconstructionBlocks . Attach a new patch. Hi Akira Ajisaka , does this JIRA still makes sense? I think this is a improvement here.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 15m 32s trunk passed
        +1 compile 1m 14s trunk passed
        +1 checkstyle 0m 42s trunk passed
        +1 mvnsite 1m 5s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 22s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 1m 15s the patch passed
        +1 compile 1m 13s the patch passed
        +1 javac 1m 13s the patch passed
        +1 checkstyle 0m 39s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 399 unchanged - 1 fixed = 399 total (was 400)
        +1 mvnsite 1m 21s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 2m 47s the patch passed
        +1 javadoc 0m 50s the patch passed
        -1 unit 83m 37s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        116m 17s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
        Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          org.apache.hadoop.hdfs.server.datanode.TestDiskError



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-10219
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849653/HDFS-10219.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux a2850746ebb8 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2034315
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18282/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18282/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18282/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 15m 32s trunk passed +1 compile 1m 14s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 22s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 1m 15s the patch passed +1 compile 1m 13s the patch passed +1 javac 1m 13s the patch passed +1 checkstyle 0m 39s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 399 unchanged - 1 fixed = 399 total (was 400) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 47s the patch passed +1 javadoc 0m 50s the patch passed -1 unit 83m 37s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 116m 17s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   org.apache.hadoop.hdfs.server.datanode.TestDiskError Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10219 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849653/HDFS-10219.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux a2850746ebb8 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2034315 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18282/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18282/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18282/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Would you update the following code

        PendingReconstructionBlocks.java
          private long timeout = 5 * 60 * 1000;
        

        to use DFS_NAMENODE_RECONSTRUCTION_PENDING_TIMEOUT_SEC_DEFAULT? That way we can easily update the default value when we need to do this.

        Show
        ajisakaa Akira Ajisaka added a comment - Would you update the following code PendingReconstructionBlocks.java private long timeout = 5 * 60 * 1000; to use DFS_NAMENODE_RECONSTRUCTION_PENDING_TIMEOUT_SEC_DEFAULT ? That way we can easily update the default value when we need to do this.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for taking a look. The comment makes sense for me. New patch attached to address the comment.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for taking a look. The comment makes sense for me. New patch attached to address the comment.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 31s trunk passed
        +1 compile 0m 56s trunk passed
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 2m 0s trunk passed
        +1 javadoc 0m 43s trunk passed
        +1 mvninstall 0m 54s the patch passed
        +1 compile 0m 48s the patch passed
        +1 javac 0m 48s the patch passed
        +1 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 406 unchanged - 1 fixed = 406 total (was 407)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 1m 59s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 67m 42s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        95m 50s



        Reason Tests
        Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-10219
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850981/HDFS-10219.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 0e10eea3ccf3 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3ea6d35
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18328/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18328/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18328/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 31s trunk passed +1 compile 0m 56s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 0s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 54s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed +1 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 406 unchanged - 1 fixed = 406 total (was 407) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 67m 42s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 95m 50s Reason Tests Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10219 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850981/HDFS-10219.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 0e10eea3ccf3 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3ea6d35 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18328/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18328/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18328/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, the test failure is not related to the patch.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, the test failure is not related to the patch.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the review. Committed to trunk.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the review. Committed to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11214 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11214/)
        HDFS-10219. Change the default value for (yqlin: rev 663e683adfbbbffeacdddcd846bd336c121df5c7)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11214 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11214/ ) HDFS-10219 . Change the default value for (yqlin: rev 663e683adfbbbffeacdddcd846bd336c121df5c7) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/PendingReconstructionBlocks.java

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development