Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10199

Unit tests TestCopyFiles, TestDistCh, TestLogalyzer under org.apache.hadoop.tools are failing

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Due to logging changes introduced in HDFS-9402 the TestCopyFiles, TestDistCh, TestLogalyzer are
      failing due to ClassCastException thrown from org.apache.hadoop.tools.TestCopyFiles' constructor.

      Error message:

      Running org.apache.hadoop.tools.TestLogalyzer
      Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.213 sec - in org.apache.hadoop.tools.TestLogalyzer
      
      Results :
      
      Failed tests:
        TestSuite$1.warning Exception in constructor: testDeleteLocal (java.lang.ClassCastException: org.slf4j.impl.Log4jLoggerAdapter cannot be cast to org.apache.commons.logging.impl.Log4JLogger
              at org.apache.hadoop.tools.TestCopyFiles.<init>(TestCopyFiles.java:63)
              at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
              at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
              at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
              at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
              at junit.framework.TestSuite.createTest(TestSuite.java:63)
              at junit.framework.TestSuite.addTestMethod(TestSuite.java:310)
              at junit.framework.TestSuite.addTestsFromTestCase(TestSuite.java:153)
              at junit.framework.TestSuite.<init>(TestSuite.java:132)
              at org.junit.internal.runners.JUnit38ClassRunner.<init>(JUnit38ClassRunner.java:72)
              at org.junit.internal.builders.JUnit3Builder.runnerForClass(JUnit3Builder.java:11)
              at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
              at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26)
              at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
              at org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:26)
              at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:262)
              at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
              at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
              at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
              at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
              at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
      )
      
      1. HDFS-10199-branch-2.01.patch
        0.8 kB
        Tibor Kiss
      2. HDFS-10199.01.patch
        0.8 kB
        Tibor Kiss

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        Oh, I've missed the above conversations. Thanks Arpit Agarwal and Chris Nauroth for the help!

        Show
        ajisakaa Akira Ajisaka added a comment - Oh, I've missed the above conversations. Thanks Arpit Agarwal and Chris Nauroth for the help!
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Looks like the patch is for branch-2/2.8. Hi Tibor Kiss, would you rename the patch to HADOOP-10199-branch-2.01.patch to run jenkins on branch-2?

        Show
        ajisakaa Akira Ajisaka added a comment - Looks like the patch is for branch-2/2.8. Hi Tibor Kiss , would you rename the patch to HADOOP-10199 -branch-2.01.patch to run jenkins on branch-2?
        Hide
        tibor.kiss@gmail.com Tibor Kiss added a comment -
        Show
        tibor.kiss@gmail.com Tibor Kiss added a comment - Thanks Arpit Agarwal & Chris Nauroth !
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for the patch. I have committed this to branch-2 and branch-2.8. Tibor Kiss, thank you for finding this and fixing it. Arpit Agarwal, thank you for code reviewing too.

        Show
        cnauroth Chris Nauroth added a comment - +1 for the patch. I have committed this to branch-2 and branch-2.8. Tibor Kiss , thank you for finding this and fixing it. Arpit Agarwal , thank you for code reviewing too.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 28s branch-2 passed
        +1 compile 0m 12s branch-2 passed with JDK v1.8.0_74
        +1 compile 0m 15s branch-2 passed with JDK v1.7.0_95
        +1 checkstyle 0m 16s branch-2 passed
        +1 mvnsite 0m 25s branch-2 passed
        +1 mvneclipse 0m 18s branch-2 passed
        +1 findbugs 0m 38s branch-2 passed
        +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_74
        +1 javadoc 0m 13s branch-2 passed with JDK v1.7.0_95
        +1 mvninstall 0m 16s the patch passed
        +1 compile 0m 10s the patch passed with JDK v1.8.0_74
        +1 javac 0m 10s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.7.0_95
        +1 javac 0m 13s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 39s the patch passed
        +1 javadoc 0m 9s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 11s the patch passed with JDK v1.7.0_95
        +1 unit 2m 17s hadoop-extras in the patch passed with JDK v1.8.0_74.
        +1 unit 2m 18s hadoop-extras in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        19m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:babe025
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795013/HDFS-10199-branch-2.01.patch
        JIRA Issue HDFS-10199
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ae5eab79f832 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 7660216
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14910/testReport/
        modules C: hadoop-tools/hadoop-extras U: hadoop-tools/hadoop-extras
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14910/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 28s branch-2 passed +1 compile 0m 12s branch-2 passed with JDK v1.8.0_74 +1 compile 0m 15s branch-2 passed with JDK v1.7.0_95 +1 checkstyle 0m 16s branch-2 passed +1 mvnsite 0m 25s branch-2 passed +1 mvneclipse 0m 18s branch-2 passed +1 findbugs 0m 38s branch-2 passed +1 javadoc 0m 12s branch-2 passed with JDK v1.8.0_74 +1 javadoc 0m 13s branch-2 passed with JDK v1.7.0_95 +1 mvninstall 0m 16s the patch passed +1 compile 0m 10s the patch passed with JDK v1.8.0_74 +1 javac 0m 10s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_95 +1 javac 0m 13s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 9s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 11s the patch passed with JDK v1.7.0_95 +1 unit 2m 17s hadoop-extras in the patch passed with JDK v1.8.0_74. +1 unit 2m 18s hadoop-extras in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 19m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795013/HDFS-10199-branch-2.01.patch JIRA Issue HDFS-10199 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ae5eab79f832 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 7660216 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14910/testReport/ modules C: hadoop-tools/hadoop-extras U: hadoop-tools/hadoop-extras Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14910/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        tibor.kiss@gmail.com Tibor Kiss added a comment -

        Thanks Arpit Agarwal, just renamed & uploaded the patch.

        Show
        tibor.kiss@gmail.com Tibor Kiss added a comment - Thanks Arpit Agarwal , just renamed & uploaded the patch.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the patch Tibor Kiss. Looks like the affected tests were removed by HADOOP-11698 so it wasn't caught in trunk. Could you please rename the patch file to HDFS-10199-branch-2.01.patch to trigger Jenkins to use branch-2?

        +1 pending Jenkins.

        Thanks.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the patch Tibor Kiss . Looks like the affected tests were removed by HADOOP-11698 so it wasn't caught in trunk. Could you please rename the patch file to HDFS-10199 -branch-2.01.patch to trigger Jenkins to use branch-2? +1 pending Jenkins. Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s HDFS-10199 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794994/HDFS-10199.01.patch
        JIRA Issue HDFS-10199
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14907/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HDFS-10199 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794994/HDFS-10199.01.patch JIRA Issue HDFS-10199 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14907/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        tibor.kiss@gmail.com Tibor Kiss added a comment -

        Attached a trivial fix.

        Show
        tibor.kiss@gmail.com Tibor Kiss added a comment - Attached a trivial fix.

          People

          • Assignee:
            tibor.kiss@gmail.com Tibor Kiss
            Reporter:
            tibor.kiss@gmail.com Tibor Kiss
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development