Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1014

Error in reading delegation tokens from edit logs.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When delegation tokens are read from the edit logs...same object is used to read the identifier and is stored in the token cache. This is wrong because same object is getting updated.

      1. HDFS-1014-y20.1.patch
        7 kB
        Jitendra Nath Pandey
      2. HDFS-1014.2.patch
        6 kB
        Jitendra Nath Pandey
      3. ASF.LICENSE.NOT.GRANTED--HDFS-1014.3.patch
        6 kB
        Jitendra Nath Pandey

        Activity

        Jitendra Nath Pandey created issue -
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for hadoop-20 is uploaded.

        Show
        Jitendra Nath Pandey added a comment - Patch for hadoop-20 is uploaded.
        Jitendra Nath Pandey made changes -
        Field Original Value New Value
        Attachment HDFS-1014-y20.1.patch [ 12437547 ]
        Jitendra Nath Pandey made changes -
        Assignee Jitendra Nath Pandey [ jnp ]
        Hide
        Konstantin Shvachko added a comment -

        +1 Patch looks good to me.

        Show
        Konstantin Shvachko added a comment - +1 Patch looks good to me.
        Jitendra Nath Pandey made changes -
        Attachment HDFS-1014.2.patch [ 12437557 ]
        Hide
        Jitendra Nath Pandey added a comment -

        HDFS-1014.2.patch is for trunk.

        Show
        Jitendra Nath Pandey added a comment - HDFS-1014 .2.patch is for trunk.
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12437557/HDFS-1014.2.patch
        against trunk revision 916902.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12437557/HDFS-1014.2.patch against trunk revision 916902. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/120/console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        Updated patch rebased against the latest trunk.

        Show
        Jitendra Nath Pandey added a comment - Updated patch rebased against the latest trunk.
        Jitendra Nath Pandey made changes -
        Attachment HDFS-1014.3.patch [ 12441764 ]
        Jitendra Nath Pandey made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jitendra Nath Pandey made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jitendra Nath Pandey added a comment -

        test-patch results

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        ant test was run manually. All tests pass except TestDiskError which also fails without this patch.

        Show
        Jitendra Nath Pandey added a comment - test-patch results [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. ant test was run manually. All tests pass except TestDiskError which also fails without this patch.
        Hide
        Jakob Homan added a comment -

        +1 on trunk patch (3).

        Show
        Jakob Homan added a comment - +1 on trunk patch (3).
        Jakob Homan made changes -
        Hadoop Flags [Reviewed]
        Hide
        Jakob Homan added a comment -

        I've just committed this. Resolving as fixed. Thanks for the contribution, Jitendra.

        Show
        Jakob Homan added a comment - I've just committed this. Resolving as fixed. Thanks for the contribution, Jitendra.
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Resolution Fixed [ 1 ]
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314046 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        43d 19h 11m 2 Jitendra Nath Pandey 14/Apr/10 22:06
        Open Open Patch Available Patch Available
        1h 13m 3 Jitendra Nath Pandey 14/Apr/10 22:06
        Patch Available Patch Available Resolved Resolved
        5d 3h 43m 1 Jakob Homan 20/Apr/10 01:50
        Resolved Resolved Closed Closed
        126d 20h 1m 1 Tom White 24/Aug/10 21:52

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development