Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1011

Improve Logging in HDFSProxy to include cluster name associated with the request

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: contrib/hdfsproxy
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Improve Logging in HDFSProxy to include cluster name associated with the request

      1. HDFS-1011.patch
        6 kB
        Srikanth Sundarrajan
      2. HDFS-1011.patch
        12 kB
        Srikanth Sundarrajan
      3. HDFS-1011.patch
        6 kB
        Srikanth Sundarrajan
      4. HDFS-1011-bp-y20.patch
        5 kB
        Srikanth Sundarrajan
      5. HDFS-1011-bp-y20s.patch
        7 kB
        Srikanth Sundarrajan
      6. HDFS-1011-bp-y20s.patch
        7 kB
        Srikanth Sundarrajan

        Activity

        Srikanth Sundarrajan created issue -
        Ramesh Sekaran made changes -
        Field Original Value New Value
        Assignee Ramesh Sekaran [ ramsek ]
        Ramesh Sekaran made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Srikanth Sundarrajan added a comment -

        Setting the thread name to be the name of the request context path. Extended logger pattern to include thread name. This will ensure that all logged message will include the context path.

        Patches for HDFS-481, HDFS-1010 need to be applied before this patch can be applied

        Backport patches to y20 included. Not for commit.

        Show
        Srikanth Sundarrajan added a comment - Setting the thread name to be the name of the request context path. Extended logger pattern to include thread name. This will ensure that all logged message will include the context path. Patches for HDFS-481 , HDFS-1010 need to be applied before this patch can be applied Backport patches to y20 included. Not for commit.
        Srikanth Sundarrajan made changes -
        Attachment HDFS-1011.patch [ 12439441 ]
        Attachment HDFS-1011-bp-y20.patch [ 12439442 ]
        Attachment HDFS-1011-bp-y20s.patch [ 12439443 ]
        Srikanth Sundarrajan made changes -
        Assignee Ramesh Sekaran [ ramsek ] Srikanth Sundarrajan [ sriksun ]
        Srikanth Sundarrajan made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Affects Version/s 0.21.0 [ 12314046 ]
        Affects Version/s 0.20.1 [ 12314048 ]
        Affects Version/s 0.20.2 [ 12314204 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Srikanth Sundarrajan made changes -
        Assignee Srikanth Sundarrajan [ sriksun ] Ramesh Sekaran [ ramsek ]
        Srikanth Sundarrajan made changes -
        Attachment HDFS-1011.patch [ 12439444 ]
        Srikanth Sundarrajan made changes -
        Attachment HDFS-1011.patch [ 12439441 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12439444/HDFS-1011.patch
        against trunk revision 925509.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/277/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439444/HDFS-1011.patch against trunk revision 925509. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/277/console This message is automatically generated.
        Hide
        Srikanth Sundarrajan added a comment -

        Output from test-patch and test-contrib

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        test:

        BUILD SUCCESSFUL
        Total time: 4 minutes 34 seconds

        ----------

        No new tests included with this patch. This patch has been tested manually. log4j.xml under tomcat_home/lib folder has been modified to include [%t] in the pattern layout for file and console appender. War file for hdfsproxy deployed under tomcat webapp with context name cluster1. The logs generated by the webapp includes [cluster1] in the logs.

        Show
        Srikanth Sundarrajan added a comment - Output from test-patch and test-contrib [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. test: BUILD SUCCESSFUL Total time: 4 minutes 34 seconds ---------- No new tests included with this patch. This patch has been tested manually. log4j.xml under tomcat_home/lib folder has been modified to include [%t] in the pattern layout for file and console appender. War file for hdfsproxy deployed under tomcat webapp with context name cluster1. The logs generated by the webapp includes [cluster1] in the logs.
        Srikanth Sundarrajan made changes -
        Attachment HDFS-1011.patch [ 12440951 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1
        I also like the changes in hdfsproxy/build.xml.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 I also like the changes in hdfsproxy/build.xml.
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Hi Srikanth, the patch file has some problem. Could you fix it?

        Show
        Tsz Wo Nicholas Sze added a comment - Hi Srikanth, the patch file has some problem. Could you fix it?
        Hide
        Srikanth Sundarrajan added a comment -

        Revising patch. Earlier patch was incorrect.

        Show
        Srikanth Sundarrajan added a comment - Revising patch. Earlier patch was incorrect.
        Srikanth Sundarrajan made changes -
        Attachment HDFS-1011.patch [ 12440960 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Srikanth!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Srikanth!
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/233/)
        . hdfsproxy: Improve log messages by restoring the previous thread name. Contributed by Srikanth Sundarrajan

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/233/ ) . hdfsproxy: Improve log messages by restoring the previous thread name. Contributed by Srikanth Sundarrajan
        Hide
        Srikanth Sundarrajan added a comment -

        Revised backport patch in sync with trunk patch for yhadoop20s.

        Show
        Srikanth Sundarrajan added a comment - Revised backport patch in sync with trunk patch for yhadoop20s.
        Srikanth Sundarrajan made changes -
        Attachment HDFS-1011-bp-y20s.patch [ 12441031 ]
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314046 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        20d 9h 13m 1 Ramesh Sekaran 21/Mar/10 16:47
        In Progress In Progress Patch Available Patch Available
        17h 7m 1 Srikanth Sundarrajan 22/Mar/10 09:55
        Patch Available Patch Available Resolved Resolved
        15d 12h 43m 1 Tsz Wo Nicholas Sze 06/Apr/10 23:38
        Resolved Resolved Closed Closed
        139d 22h 13m 1 Tom White 24/Aug/10 21:51

          People

          • Assignee:
            Ramesh Sekaran
            Reporter:
            Srikanth Sundarrajan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development