[HDDS-9902] Decommission: Admin monitor should call RM.checkContainerState to check for under-replication

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: SCM
• Labels: pull-request-available
• Assignee: Stephen O'Donnell
• Reporter: Stephen O'Donnell
• Created: 11/Dec/23 17:28
• Updated: 13/Dec/23 21:34
• Resolved: 13/Dec/23 21:34

Description

The logic in ReplicationManager is increasingly complex due to various edge cases around unhealthy and quasi-closed containers, and the differences between EC and Ratis.

It therefore makes sense for DatanodeAdminMonitor to call the new API replicationManager.checkContainerState and then check the report for under-replicated, rather than using the ReplicaCount objects.

In making this change, I needed to make a change in the EC under-replication handling where the container is unhealthy / unrecoverable but also has decommissioning indexes, as it was not being reported as under-replicated previously.

I also refactored the decommission monitor slightly to remove references to containers as "unhealthy" when they are really unclosed - renaming the metrics and variables to unClosed.

Issue Links

• links to: GitHub Pull Request #5770