[HDDS-9731] Fix false positive findbugs warnings in CodecBuffer

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: 1.4.0
• Fix Version/s: 1.4.0
• Labels: pull-request-available
• Target Version/s: 1.4.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 20/Nov/23 21:01
• Updated: 21/Nov/23 06:10
• Resolved: 21/Nov/23 06:10

Description

M D RV: Return value of org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf.writeByte(int) ignored, but method has no side effect  At CodecBuffer.java:[line 415]
M D RV: Return value of org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf.setIndex(int, int) ignored, but method has no side effect  At CodecBuffer.java:[line 452]
M D RV: Return value of org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf.setIndex(int, int) ignored, but method has no side effect  At CodecBuffer.java:[line 473]
M D RV: Return value of org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf.setIndex(int, int) ignored, but method has no side effect  At CodecBuffer.java:[line 500]
M D RV: Return value of org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf.writeInt(int) ignored, but method has no side effect  At CodecBuffer.java:[line 393]
M D RV: Return value of org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf.writeLong(long) ignored, but method has no side effect  At CodecBuffer.java:[line 404]
M D RV: Return value of org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf.writeShort(int) ignored, but method has no side effect  At CodecBuffer.java:[line 382]

These warnings are reported by SpotBugs in various PRs that do not touch CodecBuffer.

Issue Links

• links to: GitHub Pull Request #5638