[HDDS-9650] Remove dead code using getRequestType via reflections

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Done
• Fix Version/s: 2.0.0
• Component/s: Ozone Manager
• Labels: GoodForNewContributors good-first-issue pull-request-available
• Assignee: David
• Reporter: Attila Doroszlai
• Created: 08/Nov/23 12:11
• Updated: 05/Jan/24 17:40
• Resolved: 05/Jan/24 17:40

Description

HDDS-5333 removed getRequestType method from OM request classes. There is some leftover usage of this method via reflection. Such code is dead (tests are disabled, production code is unused.)

https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMLayoutVersionManager.java#L130-L157

https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java#L108-L141

https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java#L104-L106

Please don't forget to also remove any imports that become unused.

Issue Links

• depends upon: HDDS-9496 Migrate simple tests in ozone-manager to JUnit5
• is related to: HDDS-5333 Remove getRequestType method from OM request classes.
• links to: GitHub Pull Request #5927