[HDDS-9529] Fix authentication check for Vault S3 secret store

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Affects Version/s: 1.4.0
• Fix Version/s: 1.4.0
• Labels: pull-request-available s3
• Assignee: Mikhail Pochatkin
• Reporter: Mikhail Pochatkin
• Created: 25/Oct/23 07:43
• Updated: 26/Oct/23 13:15
• Resolved: 26/Oct/23 13:15

Description

Currently in VaultS3SecretStore we check that auth token is valid before each operation, for example 

checkAuth();
vault.logical().write(secretPath + '/' + kerberosId,
        Collections.singletonMap(kerberosId, secret.getAwsSecret())); 

So, its possible that authentication token is valid on check action but not valid on operation (expiration occurred between operations). 

 

Issue Links

• fixes: HDDS-9250 Test failure in VaultS3SecretStoreTest#testAuthFail
• links to: GitHub Pull Request #5486