[HDDS-9527] Race condition in RocksDatabase

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0, 1.4.1
• Component/s: db
• Labels: pull-request-available
• Target Version/s: 1.4.1
• Assignee: Sumit Agrawal
• Reporter: Tsz-wo Sze
• Created: 24/Oct/23 21:05
• Updated: 29/Jan/24 09:51
• Resolved: 10/Jan/24 16:56

Description

Suppose thread 1 just has passed assertClose() as shown below. Since isClosed is false and counter is 0, thread 2 can call close() successfully. Then, the JVM will crash as described in HDDS-7284.

  public void put(ColumnFamily family, byte[] key, byte[] value)
      throws IOException {
    assertClose();
//                                     <-----------  thread 1, isClosed is false, counter is 0
    try {
      counter.incrementAndGet();
      db.get().put(family.getHandle(), writeOptions, key, value);
    } catch (RocksDBException e) {
      closeOnError(e, true);
      throw toIOException(this, "put " + bytes2String(key), e);
    } finally {
      counter.decrementAndGet();
    }
  }

Issue Links

• is caused by: HDDS-7284 JVM crash for rocksdb for read/write after close
• links to: GitHub Pull Request #5947