[HDDS-9322] Remove duplicate containers when loading volumes on a datanode

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Labels: pull-request-available
• Assignee: Stephen O'Donnell
• Reporter: Stephen O'Donnell
• Created: 19/Sep/23 15:23
• Updated: 20/Dec/23 20:06
• Resolved: 20/Dec/23 20:06

Description

Prior to HDDS-5032, if the same container is found on multiple volumes, then the second volume to load it fails the entire volume.

After HDDS-5032, the exception is caught so the volume doesn't fail, but depending on which container is loaded faster, either one of the replicas could win. Over several restarts, the container on either volume could be the one loaded, potentially resulting in inconsistencies.

This change catches the error, and then removes one of the duplicates based on the BCSID. The container with the largest BCSID is the one kept, while the other is removed.

This will free the disk space taken by the duplicate container, and also avoid the chance of a different copy being loaded on each restart.

Issue Links

• links to: GitHub Pull Request #5324