[HDDS-9318] Prevent bucket from being deleted if incomplete MPUs exist

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Affects Version/s: 1.3.0
• Fix Version/s: 1.4.0
• Component/s: OM
• Labels: pull-request-available
• Target Version/s: 1.4.0
• Assignee: Ivan Andika
• Reporter: Ivan Andika
• Created: 19/Sep/23 09:44
• Updated: 08/Nov/23 12:24
• Resolved: 08/Nov/23 12:06

Description

While working on the MPU cleanup service, there are possible scenarios that might cause issues when cleaning up / abort incomplete MPUs:

1. Cleaning up / abort MPUs whose bucket has been deleted
2. Cleaning up / abort MPUs whose bucket has just been recreated
3. Cleaning up / abort MPUs whose bucket has changed layout (i.e. delete the original bucket with OBS layout and creating an FSO bucket with the same name)

For case 1, the incomplete MPU will not be able to be aborted since S3MultipartUploadAbortRequest will fail when bucket doesn't exist.

For case 2, if we abort the newly created bucket, the bucket might end up with negative usedBytes since S3MultipartUploadAbortRequest will substract from the bucket quota.

For case 3, if the bucket is change layout from OBS -> FSO, the abort MPU will fail since the MPU open key is located in the openKeyTable, but due to the new FSO bucket layout, it will check openFileTable.

Therefore, to resolve above cases, let's have an invariant that "all incomplete MPUs must belongs to an existing bucket" by disallowing bucket deletion until all the MPUs have been aborted.

 

Incomplete multipart uploads are also one of the criteria of bucket being empty: https://repost.aws/knowledge-center/s3-empty-bucket-lifecycle-rule

Issue Links

• links to: GitHub Pull Request #5326