[HDDS-9207] Snapshot Bootstrap creates incorrect hard links.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Component/s: Snapshot
• Labels: pull-request-available
• Assignee: George Jahad
• Reporter: George Jahad
• Created: 24/Aug/23 01:22
• Updated: 05/Sep/23 23:41
• Resolved: 05/Sep/23 23:41

Description

The Snapshot bootstrap tarball creation code was incorrectly assuming that two sst files with the same name, (but different directories,) were hard linked to each other.

This assumption will not be true in cases, like the following, where  the files are initially created in different rocksdb directories.  For example:

1. Suppose the active fs and snap1 consist of sst files: s1.sst-s10.sst.  

2. Then some delete records get added to snap1.  Those get put into s11.sst.  

3. Meanwhile more keyTable entries are added to the active fs; they could get put into a different file named also s11.sst.

To remedy this, the tarball creator must check the INodes of each file to confirm they are equal before linking them together.

Issue Links

• links to: GitHub Pull Request #5215