[HDDS-8675] Fix expectation in testUnderRepSentToOverRepHandlerIfNoNewNodes

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 1.4.0
• Assignee: Siddhant Sangwan
• Reporter: Siddhant Sangwan
• Created: 23/May/23 07:27
• Updated: 31/May/23 08:05
• Resolved: 31/May/23 08:05

Description

Looks like we're writing the expected result into the actual result and comparing them:

      Set<Pair<DatanodeDetails, SCMCommand<?>>> expectedDelete =
          new HashSet<>();
      expectedDelete.add(Pair.of(overRepReplica.getDatanodeDetails(),
          createDeleteContainerCommand(container,
              overRepReplica.getReplicaIndex())));

      Mockito.when(replicationManager.processOverReplicatedContainer(
          underRep)).thenAnswer(invocationOnMock -> {
            commandsSent.addAll(expectedDelete);
            return expectedDelete.size();
          });
      commandsSent.clear();
      assertThrows(SCMException.class,
          () -> ecURH.processAndSendCommands(availableReplicas,
              Collections.emptyList(), underRep, 2));
      Mockito.verify(replicationManager, times(1))
          .processOverReplicatedContainer(underRep);
      Assertions.assertEquals(true, expectedDelete.equals(commandsSent));

commandsSent should be populated with the actual command that was sent.

Issue Links

• links to: GitHub Pull Request #4795