[HDDS-8554] Thread pool size needs to be decreased in different order in ReplicationSupervisor

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.4.0
• Component/s: Ozone Datanode
• Labels: pull-request-available
• Target Version/s: 1.4.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 05/May/23 19:04
• Updated: 27/Jun/23 20:05
• Resolved: 06/May/23 07:15

Description

https://github.com/apache/ozone/blob/a455597815a4a12ded9479f334780a83116a2123/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java#L164-L165

          tpe.setMaximumPoolSize(threadCount);
          tpe.setCorePoolSize(threadCount);

The above code works when increasing thread pool size, but fails when decreasing it:

java.lang.IllegalArgumentException
	at java.util.concurrent.ThreadPoolExecutor.setMaximumPoolSize(ThreadPoolExecutor.java:1680)
	at org.apache.hadoop.ozone.container.replication.ReplicationSupervisor$Builder.lambda$build$1(ReplicationSupervisor.java:164)
	at org.apache.hadoop.ozone.container.replication.ReplicationSupervisor.nodeStateUpdated(ReplicationSupervisor.java:294)

Core pool size needs to be decreased first to satisfy preconditions.

Issue Links

• links to: GitHub Pull Request #4669