[HDDS-8359] ReplicationManager: Fix getContainerReplicationHealth() so that it builds ContainerCheckRequest correctly

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 1.4.0
• Assignee: Siddhant Sangwan
• Reporter: Siddhant Sangwan
• Created: 03/Apr/23 05:49
• Updated: 05/May/23 15:22
• Resolved: 04/Apr/23 10:08

Description

getContainerReplicationHealth() in ReplicationManager does not set pendingOps and maintenanceRedundancy when building ContainerCheckRequest. This leads to errors such as:

scm_1         | java.lang.NullPointerException
scm_1         | 	at java.base/java.util.Collections$UnmodifiableCollection.<init>(Collections.java:1030)
scm_1         | 	at java.base/java.util.Collections$UnmodifiableList.<init>(Collections.java:1303)
scm_1         | 	at java.base/java.util.Collections.unmodifiableList(Collections.java:1290)
scm_1         | 	at org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest.<init>(ContainerCheckRequest.java:45)
scm_1         | 	at org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest.<init>(ContainerCheckRequest.java:31)
scm_1         | 	at org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest$Builder.build(ContainerCheckRequest.java:119)
scm_1         | 	at org.apache.hadoop.hdds.scm.container.replication.ReplicationManager.getContainerReplicationHealth(ReplicationManager.java:923)
scm_1         | 	at org.apache.hadoop.hdds.scm.container.balancer.MoveManager.move(MoveManager.java:253)
...

Issue Links

• is required by: HDDS-8170 Let ContainerBalancer consider EC containers for balancing
• links to: GitHub Pull Request #4528