[HDDS-8358] Fix the space usage comparator in ContainerBalancerSelectionCriteria

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 1.4.0
• Assignee: Siddhant Sangwan
• Reporter: Siddhant Sangwan
• Created: 03/Apr/23 05:42
• Updated: 05/May/23 15:22
• Resolved: 04/Apr/23 15:17

Description

ContainerBalancerSelectionCriteria has a Comparator orderContainersByUsedBytes which is used for comparing containers on the basis of used space. This comparator calls isContainerMoreUsed, which does not have consistent behaviour when used space for two containers is equal.

This bug was exposed when fixing the setup of TestContainerBalancerTask.
createReplicasForContainers() in TestContainerBalancerTask creates additional container replicas but does not add them to datanodeToContainersMap, the map being used to track these. This jira intends to fix the bug and the test setup.

Issue Links

• is required by: HDDS-8170 Let ContainerBalancer consider EC containers for balancing
• links to: GitHub Pull Request #4527