[HDDS-8337] ReplicationManager: MisReplicationHandler should throw an exception if partially successful

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Labels: pull-request-available
• Assignee: Attila Doroszlai
• Reporter: Stephen O'Donnell
• Created: 30/Mar/23 16:55
• Updated: 11/Apr/23 11:23
• Resolved: 11/Apr/23 11:23

Description

In MisReplicationHandler.getTargetDatanodes() the logic tries to get the required nodes and if it cannot it tries for less nodes to allow a partial recovery.

If the requested node count does not equal the number returned, it currently logs a warning:

    if (targetDatanodes.size() < replicasToBeReplicated.size()) {
      LOG.warn("Placement Policy {} found only {} nodes for Container: {}," +
               " number of required nodes: {}, usedNodes : {}",
              containerPlacement.getClass(), targetDatanodes.size(),
              container.getContainerID(), replicasToBeReplicated.size(),
              usedDns);
    }

In such a case, after sending the commands we can, it should thrown an exception to it is requeued for retry later, rather than returning successfully.

Issue Links

• links to: GitHub Pull Request #4536