[HDDS-8077] Enforce new checkstyle: NewlineAtEndOfFile

• Type: Wish
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Fix Version/s: 1.4.0
• Labels: pull-request-available
• Assignee: Siyao Meng
• Reporter: Siyao Meng
• Created: 04/Mar/23 01:02
• Updated: 08/Mar/23 19:58
• Resolved: 05/Mar/23 13:41

Description

It is brought up by hemantkumar.dindi a while back that we generally want a new line at the end of a file: https://github.com/apache/ozone/pull/4125#discussion_r1087167605

and it also makes sense in terms of diff output, from doc:

Rationale: Any source files and text files in general should end with a line separator to let other easily add new content at the end of file and "diff" command does not show previous lines as changed.

Back in HDDS-2119, nanda actually added the NewlineAtEndOfFile check but it is commented out to this day for some reason. Though I didn't find any objections in the PR.

In order to add the check we just need to uncomment that line, and fix whatever existing files that don't have a new line at EOF, similar to what I did in HDDS-6208.

Issue Links

• links to: GitHub Pull Request #4347